diff options
author | Vitaly Buka <vitalybuka@google.com> | 2016-01-22 11:38:37 -0800 |
---|---|---|
committer | Vitaly Buka <vitalybuka@google.com> | 2016-01-22 21:49:52 +0000 |
commit | 0dbbf605efb8f72b3c2c15c14e613323fc2ac0a2 (patch) | |
tree | 5ecb3c53691357a7ebf5d75debb9e612c7b32714 /src/privet/auth_manager.cc | |
parent | 48a8669ddc2e8d785aad9ad18a5abbf8f1224fde (diff) | |
download | libweave-0dbbf605efb8f72b3c2c15c14e613323fc2ac0a2.tar.gz |
AddTo will return AddToTypeProxy for convenience
Change-Id: If86496af0c68af31a3e0c618b0fae861975a4ebf
Reviewed-on: https://weave-review.googlesource.com/2321
Reviewed-by: Vitaly Buka <vitalybuka@google.com>
Diffstat (limited to 'src/privet/auth_manager.cc')
-rw-r--r-- | src/privet/auth_manager.cc | 48 |
1 files changed, 21 insertions, 27 deletions
diff --git a/src/privet/auth_manager.cc b/src/privet/auth_manager.cc index 0753a2b..66d04c4 100644 --- a/src/privet/auth_manager.cc +++ b/src/privet/auth_manager.cc @@ -65,14 +65,13 @@ bool CheckCaveatType(const UwMacaroonCaveat& caveat, ErrorPtr* error) { UwMacaroonCaveatType caveat_type{}; if (!uw_macaroon_caveat_get_type_(&caveat, &caveat_type)) { - Error::AddTo(error, FROM_HERE, kInvalidTokenError, "Unable to get type"); - return false; + return Error::AddTo(error, FROM_HERE, kInvalidTokenError, + "Unable to get type"); } if (caveat_type != type) { - Error::AddTo(error, FROM_HERE, kInvalidTokenError, - "Unexpected caveat type"); - return false; + return Error::AddTo(error, FROM_HERE, kInvalidTokenError, + "Unexpected caveat type"); } return true; @@ -86,8 +85,8 @@ bool ReadCaveat(const UwMacaroonCaveat& caveat, return false; if (!uw_macaroon_caveat_get_value_uint_(&caveat, value)) { - Error::AddTo(error, FROM_HERE, kInvalidTokenError, "Unable to read caveat"); - return false; + return Error::AddTo(error, FROM_HERE, kInvalidTokenError, + "Unable to read caveat"); } return true; @@ -103,8 +102,8 @@ bool ReadCaveat(const UwMacaroonCaveat& caveat, const uint8_t* start{nullptr}; size_t size{0}; if (!uw_macaroon_caveat_get_value_str_(&caveat, &start, &size)) { - Error::AddTo(error, FROM_HERE, kInvalidTokenError, "Unable to read caveat"); - return false; + return Error::AddTo(error, FROM_HERE, kInvalidTokenError, + "Unable to read caveat"); } value->assign(reinterpret_cast<const char*>(start), size); @@ -144,8 +143,8 @@ bool LoadMacaroon(const std::vector<uint8_t>& token, buffer->resize(kMaxMacaroonSize); if (!uw_macaroon_load_(token.data(), token.size(), buffer->data(), buffer->size(), macaroon)) { - Error::AddTo(error, FROM_HERE, kInvalidTokenError, "Invalid token format"); - return false; + return Error::AddTo(error, FROM_HERE, kInvalidTokenError, + "Invalid token format"); } return true; } @@ -155,9 +154,8 @@ bool VerifyMacaroon(const std::vector<uint8_t>& secret, ErrorPtr* error) { CHECK_EQ(kSha256OutputSize, secret.size()); if (!uw_macaroon_verify_(&macaroon, secret.data(), secret.size())) { - Error::AddTo(error, FROM_HERE, "invalid_signature", - "Invalid token signature"); - return false; + return Error::AddTo(error, FROM_HERE, "invalid_signature", + "Invalid token signature"); } return true; } @@ -271,23 +269,20 @@ bool AuthManager::ParseAccessToken(const std::vector<uint8_t>& token, &user_id, error) || !ReadCaveat(macaroon.caveats[2], kUwMacaroonCaveatTypeExpiration, &expiration, error)) { - Error::AddTo(error, FROM_HERE, errors::kInvalidAuthorization, - "Invalid token"); - return false; + return Error::AddTo(error, FROM_HERE, errors::kInvalidAuthorization, + "Invalid token"); } AuthScope auth_scope{FromMacaroonScope(scope)}; if (auth_scope == AuthScope::kNone) { - Error::AddTo(error, FROM_HERE, errors::kInvalidAuthorization, - "Invalid token data"); - return false; + return Error::AddTo(error, FROM_HERE, errors::kInvalidAuthorization, + "Invalid token data"); } base::Time time{base::Time::FromTimeT(expiration)}; if (time < clock_->Now()) { - Error::AddTo(error, FROM_HERE, errors::kAuthorizationExpired, - "Token is expired"); - return false; + return Error::AddTo(error, FROM_HERE, errors::kAuthorizationExpired, + "Token is expired"); } if (user_info) @@ -329,8 +324,7 @@ bool AuthManager::ConfirmClientAuthToken(const std::vector<uint8_t>& token, return auth.first->IsValidAuthToken(token, nullptr); }); if (claim == pending_claims_.end()) { - Error::AddTo(error, FROM_HERE, errors::kNotFound, "Unknown claim"); - return false; + return Error::AddTo(error, FROM_HERE, errors::kNotFound, "Unknown claim"); } SetAuthSecret(claim->first->GetAuthSecret(), claim->second); @@ -358,8 +352,8 @@ bool AuthManager::IsValidAuthToken(const std::vector<uint8_t>& token, UwMacaroon macaroon{}; if (!LoadMacaroon(token, &buffer, &macaroon, error) || !VerifyMacaroon(auth_secret_, macaroon, error)) { - Error::AddTo(error, FROM_HERE, errors::kInvalidAuthCode, "Invalid token"); - return false; + return Error::AddTo(error, FROM_HERE, errors::kInvalidAuthCode, + "Invalid token"); } return true; } |