diff options
author | Vitaly Buka <vitalybuka@google.com> | 2015-12-14 16:28:47 -0800 |
---|---|---|
committer | Vitaly Buka <vitalybuka@google.com> | 2015-12-15 07:32:12 +0000 |
commit | a10ab1ce7c4cd8e8a6c3c6c9a2b0bc8a5d013f56 (patch) | |
tree | 739cf81280ebb2b3acfead3566b9a97fa6283e5a /src/privet/auth_manager.cc | |
parent | 0c190b39cd7629168b7008b34555881f7830289d (diff) | |
download | libweave-a10ab1ce7c4cd8e8a6c3c6c9a2b0bc8a5d013f56.tar.gz |
Provide RootClientTokenOwner into ClaimRootClientAuthToken
ClaimRootClientAuthToken will check if token is already claimed and
block claim if needed.
BUG=25766815
Change-Id: I8d12578c99307830afccd280c322d2240234e435
Reviewed-on: https://weave-review.googlesource.com/1934
Reviewed-by: Alex Vakulenko <avakulenko@google.com>
Diffstat (limited to 'src/privet/auth_manager.cc')
-rw-r--r-- | src/privet/auth_manager.cc | 53 |
1 files changed, 35 insertions, 18 deletions
diff --git a/src/privet/auth_manager.cc b/src/privet/auth_manager.cc index 3a2f5e0..fa1d685 100644 --- a/src/privet/auth_manager.cc +++ b/src/privet/auth_manager.cc @@ -85,26 +85,41 @@ std::vector<uint8_t> CreateSecret() { AuthManager::AuthManager(Config* config, const std::vector<uint8_t>& certificate_fingerprint) : config_{config}, certificate_fingerprint_{certificate_fingerprint} { - SetSecret(config_ ? config_->GetSettings().secret : std::vector<uint8_t>{}); + if (config_) { + SetSecret(config_->GetSettings().secret, + config_->GetSettings().root_client_token_owner); + } else { + SetSecret({}, RootClientTokenOwner::kNone); + } } AuthManager::AuthManager(const std::vector<uint8_t>& secret, const std::vector<uint8_t>& certificate_fingerprint, base::Clock* clock) : AuthManager(nullptr, certificate_fingerprint) { - SetSecret(secret); + SetSecret(secret, RootClientTokenOwner::kNone); if (clock) clock_ = clock; } -void AuthManager::SetSecret(const std::vector<uint8_t>& secret) { - secret_ = secret.size() == kSha256OutputSize ? secret : CreateSecret(); - if (config_ && config_->GetSettings().secret != secret_) { - Config::Transaction change{config_}; - change.set_secret(secret); - change.set_root_client_token_owner(RootClientTokenOwner::kNone); - change.Commit(); +void AuthManager::SetSecret(const std::vector<uint8_t>& secret, + RootClientTokenOwner owner) { + secret_ = secret; + + if (secret.size() != kSha256OutputSize) { + secret_ = CreateSecret(); + owner = RootClientTokenOwner::kNone; } + + if (!config_ || (config_->GetSettings().secret == secret_ && + config_->GetSettings().root_client_token_owner == owner)) { + return; + } + + Config::Transaction change{config_}; + change.set_secret(secret); + change.set_root_client_token_owner(owner); + change.Commit(); } AuthManager::~AuthManager() {} @@ -130,12 +145,13 @@ UserInfo AuthManager::ParseAccessToken(const std::vector<uint8_t>& token, return SplitTokenData(std::string(data.begin(), data.end()), time); } -std::vector<uint8_t> AuthManager::ClaimRootClientAuthToken() { - pending_claims_.push_back( - std::unique_ptr<AuthManager>{new AuthManager{nullptr, {}}}); +std::vector<uint8_t> AuthManager::ClaimRootClientAuthToken( + RootClientTokenOwner owner) { + pending_claims_.push_back(std::make_pair( + std::unique_ptr<AuthManager>{new AuthManager{nullptr, {}}}, owner)); if (pending_claims_.size() > kMaxPendingClaims) pending_claims_.pop_front(); - return pending_claims_.back()->GetRootClientAuthToken(); + return pending_claims_.back().first->GetRootClientAuthToken(); } bool AuthManager::ConfirmAuthToken(const std::vector<uint8_t>& token) { @@ -143,14 +159,15 @@ bool AuthManager::ConfirmAuthToken(const std::vector<uint8_t>& token) { if (pending_claims_.empty() && IsValidAuthToken(token)) return true; - auto claim = std::find_if(pending_claims_.begin(), pending_claims_.end(), - [&token](const std::unique_ptr<AuthManager>& auth) { - return auth->IsValidAuthToken(token); - }); + auto claim = + std::find_if(pending_claims_.begin(), pending_claims_.end(), + [&token](const decltype(pending_claims_)::value_type& auth) { + return auth.first->IsValidAuthToken(token); + }); if (claim == pending_claims_.end()) return false; - secret_ = (*claim)->GetSecret(); + SetSecret(claim->first->GetSecret(), claim->second); pending_claims_.clear(); return true; } |