diff options
author | Adrian Prantl <aprantl@apple.com> | 2019-10-08 16:59:24 +0000 |
---|---|---|
committer | Adrian Prantl <aprantl@apple.com> | 2019-10-08 16:59:24 +0000 |
commit | 07ea010b9019c96f1a754a2a2ed73667ed7aead7 (patch) | |
tree | 4a07504074304ebe92066a0f2fd9b689fc2dfb8c /source | |
parent | f6c8172edba019d6f29146996a9d9d89995172a9 (diff) | |
download | lldb-07ea010b9019c96f1a754a2a2ed73667ed7aead7.tar.gz |
ObjectFileMachO: Replace std::map with llvm::DenseMap (NFC)
This makes parsing the symbol table of clang marginally faster. (Hashtable versus tree).
Differential Revision: https://reviews.llvm.org/D68605
git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@374084 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'source')
-rw-r--r-- | source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp | 28 |
1 files changed, 10 insertions, 18 deletions
diff --git a/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp b/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp index 46177e7bb..be02eaec2 100644 --- a/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp +++ b/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp @@ -2478,8 +2478,8 @@ size_t ObjectFileMachO::ParseSymtab() { std::vector<uint32_t> N_BRAC_indexes; std::vector<uint32_t> N_COMM_indexes; typedef std::multimap<uint64_t, uint32_t> ValueToSymbolIndexMap; - typedef std::map<uint32_t, uint32_t> NListIndexToSymbolIndexMap; - typedef std::map<const char *, uint32_t> ConstNameToSymbolIndexMap; + typedef llvm::DenseMap<uint32_t, uint32_t> NListIndexToSymbolIndexMap; + typedef llvm::DenseMap<const char *, uint32_t> ConstNameToSymbolIndexMap; ValueToSymbolIndexMap N_FUN_addr_to_sym_idx; ValueToSymbolIndexMap N_STSYM_addr_to_sym_idx; ConstNameToSymbolIndexMap N_GSYM_name_to_sym_idx; @@ -2689,8 +2689,8 @@ size_t ObjectFileMachO::ParseSymtab() { offset = 0; - typedef std::map<ConstString, uint16_t> UndefinedNameToDescMap; - typedef std::map<uint32_t, ConstString> SymbolIndexToName; + typedef llvm::DenseMap<ConstString, uint16_t> UndefinedNameToDescMap; + typedef llvm::DenseMap<uint32_t, ConstString> SymbolIndexToName; UndefinedNameToDescMap undefined_name_to_desc; SymbolIndexToName reexport_shlib_needs_fixup; @@ -3487,15 +3487,11 @@ size_t ObjectFileMachO::ParseSymtab() { // matches, then we can merge the two into just the // function symbol to avoid duplicate entries in // the symbol table - std::pair<ValueToSymbolIndexMap::const_iterator, - ValueToSymbolIndexMap::const_iterator> - range; - range = + auto range = N_FUN_addr_to_sym_idx.equal_range(nlist.n_value); if (range.first != range.second) { bool found_it = false; - for (ValueToSymbolIndexMap::const_iterator pos = - range.first; + for (const auto pos = range.first; pos != range.second; ++pos) { if (sym[sym_idx].GetMangled().GetName( lldb::eLanguageTypeUnknown, @@ -3536,15 +3532,11 @@ size_t ObjectFileMachO::ParseSymtab() { // matches, then we can merge the two into just the // Static symbol to avoid duplicate entries in the // symbol table - std::pair<ValueToSymbolIndexMap::const_iterator, - ValueToSymbolIndexMap::const_iterator> - range; - range = N_STSYM_addr_to_sym_idx.equal_range( + auto range = N_STSYM_addr_to_sym_idx.equal_range( nlist.n_value); if (range.first != range.second) { bool found_it = false; - for (ValueToSymbolIndexMap::const_iterator pos = - range.first; + for (const auto pos = range.first; pos != range.second; ++pos) { if (sym[sym_idx].GetMangled().GetName( lldb::eLanguageTypeUnknown, @@ -3667,8 +3659,8 @@ size_t ObjectFileMachO::ParseSymtab() { nlist_idx = 0; } - typedef std::map<ConstString, uint16_t> UndefinedNameToDescMap; - typedef std::map<uint32_t, ConstString> SymbolIndexToName; + typedef llvm::DenseMap<ConstString, uint16_t> UndefinedNameToDescMap; + typedef llvm::DenseMap<uint32_t, ConstString> SymbolIndexToName; UndefinedNameToDescMap undefined_name_to_desc; SymbolIndexToName reexport_shlib_needs_fixup; |