diff options
| author | Petr Machata <pmachata@redhat.com> | 2013-10-11 21:15:19 +0200 |
|---|---|---|
| committer | Petr Machata <pmachata@redhat.com> | 2013-10-11 21:29:10 +0200 |
| commit | 2f140bfae6d45ef119ad14252c0d99c30a91d3a6 (patch) | |
| tree | fc05c211b1e20569ae7d9bf365aa197297272a11 | |
| parent | dad1b779e2ed29c9fce17853ca71cb719240b9cf (diff) | |
| download | ltrace-2f140bfae6d45ef119ad14252c0d99c30a91d3a6.tar.gz | |
Commentary fixes
| -rw-r--r-- | breakpoint.h | 6 | ||||
| -rw-r--r-- | ltrace-elf.c | 4 | ||||
| -rw-r--r-- | sysdeps/sysdep.h | 9 |
3 files changed, 10 insertions, 9 deletions
diff --git a/breakpoint.h b/breakpoint.h index 3f63f63..c9884f0 100644 --- a/breakpoint.h +++ b/breakpoint.h @@ -58,14 +58,14 @@ struct breakpoint { struct arch_breakpoint_data arch; }; -/* Call on-hit handler of BP, if any is set. */ +/* Call ON_HIT handler of BP, if any is set. */ void breakpoint_on_hit(struct breakpoint *bp, struct process *proc); -/* Call on-continue handler of BP. If none is set, call +/* Call ON_CONTINUE handler of BP. If none is set, call * continue_after_breakpoint. */ void breakpoint_on_continue(struct breakpoint *bp, struct process *proc); -/* Call on-retract handler of BP, if any is set. This should be +/* Call ON_RETRACT handler of BP, if any is set. This should be * called before the breakpoints are destroyed. The reason for a * separate interface is that breakpoint_destroy has to be callable * without PROC. ON_DISABLE might be useful as well, but that would diff --git a/ltrace-elf.c b/ltrace-elf.c index 19cae88..c9caf56 100644 --- a/ltrace-elf.c +++ b/ltrace-elf.c @@ -621,10 +621,10 @@ populate_plt(struct process *proc, const char *filename, case PLT_DEFAULT: if (default_elf_add_plt_entry(proc, lte, name, &rela, i, &libsym) < 0) - /* fall-through */ + /* Fall through. */ case PLT_FAIL: return -1; - /* fall-through */ + /* Fall through. */ case PLT_OK: if (libsym != NULL) { /* If we are adding those symbols just diff --git a/sysdeps/sysdep.h b/sysdeps/sysdep.h index e8e287f..2a5d7f1 100644 --- a/sysdeps/sysdep.h +++ b/sysdeps/sysdep.h @@ -24,10 +24,11 @@ #include <arch.h> #ifndef ARCH_HAVE_ADDRESS_TYPES /* We should in general be able to trace 64-bit processes with 32-bit - * ltrace. (At least PPC has several PTRACE requests related to - * tracing 64-on-32, so presumably it should be possible.) But ltrace - * is currently hopelessly infested with using void* for host address. - * So keep with it, for now. */ + * ltrace (this is possible on PPC, and generally there should be no + * problem tracing x86_64 processes from x32 ltrace, though it isn't + * possible from i386 ltrace). But ltrace is currently hopelessly + * infested with using void* for host address. So keep with it, for + * now. */ typedef void *arch_addr_t; #endif |