diff options
| author | Fritz Koenig <frkoenig@chromium.org> | 2021-09-08 19:43:53 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2022-02-24 19:24:15 +0000 |
| commit | 407eb0ebf3ce52fd4b3d79712d1b86d7b021c29b (patch) | |
| tree | 889ec259c7672ffc733d3ea60a0403fdddd2735d | |
| parent | eaafb204fffeb8e87b86fb5a071fa3c0e8dfc512 (diff) | |
| download | minigbm-407eb0ebf3ce52fd4b3d79712d1b86d7b021c29b.tar.gz | |
Revert "minigbm/msm: Disable UBWC for video gtest"
This reverts commit 1d3637fbf629203c6647bacf585ebbbb3bf6e733.
The browser has support for disabling bandwidth compression
by passing the |disable-buffer-bw-compression| flag. This
makes the reliance on dlsym obsolete.
BUG=b:171260705
BUG=b:220910969
TEST=video_decode_accelerator_tests
Change-Id: Ic4d88b28c3a2cc095e5f782fc2255032ae20d281
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/minigbm/+/3150967
Reviewed-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Chia-I Wu <olv@google.com>
Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org>
Tested-by: Fritz Koenig <frkoenig@chromium.org>
Commit-Queue: Fritz Koenig <frkoenig@chromium.org>
| -rw-r--r-- | msm.c | 16 |
1 files changed, 0 insertions, 16 deletions
@@ -207,22 +207,6 @@ static bool should_avoid_ubwc(void) drv_log("WARNING: waffle detected, disabling UBWC\n"); return true; } - - /* The video_decode_accelerator_tests needs to read back the frames - * to verify they are correct. The frame verification relies on - * computing the MD5 of the video frame. UBWC results in a different - * MD5. This turns off UBWC for gtest until a proper frame - * comparison can be made - * Rely on the same mechanism that waffle is using, but this time check - * for a dynamic library function that is present in chrome, but missing - * in gtest. Cups is not loaded for video tests. - * - * See b/171260705 - */ - if (!dlsym(RTLD_DEFAULT, "cupsFilePrintf")) { - drv_log("WARNING: gtest detected, disabling UBWC\n"); - return true; - } #endif return false; } |