aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAng Li <angli@google.com>2018-01-23 09:51:02 -0800
committerGitHub <noreply@github.com>2018-01-23 09:51:02 -0800
commit9116d93c6980124968d952b29b057c61a13c3422 (patch)
treeea0643ce9544c8b5b08084cda9033f3f86f049d2
parentc2d947efa173968571cbcc11376159647a9ff356 (diff)
downloadmobly-snippet-lib-9116d93c6980124968d952b29b057c61a13c3422.tar.gz
Fix a crash caused by custom converter (#88)
Fix a bug where snippet lib crashes if no converter class is specified.
-rw-r--r--third_party/sl4a/src/main/java/com/google/android/mobly/snippet/manager/SnippetManager.java7
1 files changed, 6 insertions, 1 deletions
diff --git a/third_party/sl4a/src/main/java/com/google/android/mobly/snippet/manager/SnippetManager.java b/third_party/sl4a/src/main/java/com/google/android/mobly/snippet/manager/SnippetManager.java
index 9632b8b..7580441 100644
--- a/third_party/sl4a/src/main/java/com/google/android/mobly/snippet/manager/SnippetManager.java
+++ b/third_party/sl4a/src/main/java/com/google/android/mobly/snippet/manager/SnippetManager.java
@@ -95,7 +95,12 @@ public class SnippetManager {
throw new IllegalStateException("SnippetManager should not be re-initialized");
}
// Add custom object converter if user provided one.
- SnippetObjectConverterManager.addConverter(findSnippetObjectConverterFromMetadata(context));
+ Class<? extends SnippetObjectConverter> converterClazz =
+ findSnippetObjectConverterFromMetadata(context);
+ if (converterClazz != null) {
+ Log.d("Found custom converter class, adding...");
+ SnippetObjectConverterManager.addConverter(converterClazz);
+ }
Collection<Class<? extends Snippet>> classList = findSnippetClassesFromMetadata(context);
sInstance = new SnippetManager(classList);
return sInstance;