diff options
author | l-meng <lmeng@google.com> | 2017-06-20 11:32:03 -0700 |
---|---|---|
committer | David T.H. Kao <dthkao@gmail.com> | 2017-06-20 11:32:03 -0700 |
commit | 1dfee3c5a26e92e21501941251ce510cdc72a6b6 (patch) | |
tree | 8049743367fa1b3466a6c3383720d8daab5ce933 /third_party/sl4a/src/main/java | |
parent | b53f51e748533c8703828d8921fb185077e8d845 (diff) | |
download | mobly-snippet-lib-1dfee3c5a26e92e21501941251ce510cdc72a6b6.tar.gz |
Fix format warnings (#66)
Diffstat (limited to 'third_party/sl4a/src/main/java')
2 files changed, 3 insertions, 6 deletions
diff --git a/third_party/sl4a/src/main/java/com/google/android/mobly/snippet/rpc/MethodDescriptor.java b/third_party/sl4a/src/main/java/com/google/android/mobly/snippet/rpc/MethodDescriptor.java index a12716a..bc9bd48 100644 --- a/third_party/sl4a/src/main/java/com/google/android/mobly/snippet/rpc/MethodDescriptor.java +++ b/third_party/sl4a/src/main/java/com/google/android/mobly/snippet/rpc/MethodDescriptor.java @@ -91,8 +91,8 @@ public final class MethodDescriptor { * @return TODO */ // TODO(damonkohler): This signature is a bit weird (auto-refactored). The obvious alternative - // would be to work on one supplied parameter and return the converted parameter. However, that's - // problematic because you lose the ability to call the getXXX methods on the JSON array. + // would be to work on one supplied parameter and return the converted parameter. However, + // that's problematic because you lose the ability to call the getXXX methods on the JSON array. //@VisibleForTesting static Object convertParameter(final JSONArray parameters, int index, Type type) throws JSONException, RpcError { @@ -105,7 +105,7 @@ public final class MethodDescriptor { try { return parameters.getBoolean(index); } catch (JSONException e) { - return new Boolean(parameters.getInt(index) != 0); + return parameters.getInt(index) != 0; } } else if (type == Long.class || type == long.class) { return parameters.getLong(index); diff --git a/third_party/sl4a/src/main/java/com/google/android/mobly/snippet/schedulerpc/ScheduleRpcSnippet.java b/third_party/sl4a/src/main/java/com/google/android/mobly/snippet/schedulerpc/ScheduleRpcSnippet.java index 88dea24..2042b7f 100644 --- a/third_party/sl4a/src/main/java/com/google/android/mobly/snippet/schedulerpc/ScheduleRpcSnippet.java +++ b/third_party/sl4a/src/main/java/com/google/android/mobly/snippet/schedulerpc/ScheduleRpcSnippet.java @@ -17,7 +17,6 @@ package com.google.android.mobly.snippet.schedulerpc; import com.google.android.mobly.snippet.Snippet; -import com.google.android.mobly.snippet.manager.SnippetManager; import com.google.android.mobly.snippet.rpc.AsyncRpc; import com.google.android.mobly.snippet.util.RpcUtil; import org.json.JSONArray; @@ -25,11 +24,9 @@ import org.json.JSONArray; /** Snippet that provides {@link AsyncRpc} to schedule other RPCs. */ public class ScheduleRpcSnippet implements Snippet { - private final SnippetManager mReceiverManager; private final RpcUtil mRpcUtil; public ScheduleRpcSnippet() { - mReceiverManager = SnippetManager.getInstance(); mRpcUtil = new RpcUtil(); } |