From a59803b641f7eee45cfd0cf170e669dfe2b1eb8d Mon Sep 17 00:00:00 2001 From: ritchie Date: Sun, 10 May 2015 13:37:31 +0200 Subject: logging improved and all print stacktraces moved to logging --- .../src/main/java/fi/iki/elonen/NanoWebSocketServer.java | 11 +++++++++-- .../java/fi/iki/elonen/samples/echo/DebugWebSocketServer.java | 10 +++++++++- 2 files changed, 18 insertions(+), 3 deletions(-) (limited to 'websocket/src/main/java/fi/iki/elonen') diff --git a/websocket/src/main/java/fi/iki/elonen/NanoWebSocketServer.java b/websocket/src/main/java/fi/iki/elonen/NanoWebSocketServer.java index 3f1e1f4..9c3b8c7 100644 --- a/websocket/src/main/java/fi/iki/elonen/NanoWebSocketServer.java +++ b/websocket/src/main/java/fi/iki/elonen/NanoWebSocketServer.java @@ -45,12 +45,19 @@ import java.util.Arrays; import java.util.LinkedList; import java.util.List; import java.util.Map; +import java.util.logging.Level; +import java.util.logging.Logger; import fi.iki.elonen.NanoWebSocketServer.WebSocketFrame.CloseCode; import fi.iki.elonen.NanoWebSocketServer.WebSocketFrame.CloseFrame; import fi.iki.elonen.NanoWebSocketServer.WebSocketFrame.OpCode; public abstract class NanoWebSocketServer extends NanoHTTPD { + /** + * logger to log to. + */ + private static Logger LOG = Logger.getLogger(NanoWebSocketServer.class.getName()); + public static final String HEADER_UPGRADE = "upgrade"; public static final String HEADER_UPGRADE_VALUE = "websocket"; public static final String HEADER_CONNECTION = "connection"; @@ -307,14 +314,14 @@ public abstract class NanoWebSocketServer extends NanoHTTPD { try { in.close(); } catch (IOException e) { - e.printStackTrace(); + LOG.log(Level.FINE, "close failed",e); } } if (out != null) { try { out.close(); } catch (IOException e) { - e.printStackTrace(); + LOG.log(Level.FINE, "close failed",e); } } state = State.CLOSED; diff --git a/websocket/src/main/java/fi/iki/elonen/samples/echo/DebugWebSocketServer.java b/websocket/src/main/java/fi/iki/elonen/samples/echo/DebugWebSocketServer.java index 8d5b752..8aad58e 100644 --- a/websocket/src/main/java/fi/iki/elonen/samples/echo/DebugWebSocketServer.java +++ b/websocket/src/main/java/fi/iki/elonen/samples/echo/DebugWebSocketServer.java @@ -34,6 +34,9 @@ package fi.iki.elonen.samples.echo; */ import java.io.IOException; +import java.util.logging.Level; +import java.util.logging.Logger; + import fi.iki.elonen.NanoWebSocketServer; /** @@ -41,6 +44,11 @@ import fi.iki.elonen.NanoWebSocketServer; * On: 4/23/14 at 10:31 PM */ public class DebugWebSocketServer extends NanoWebSocketServer { + /** + * logger to log to. + */ + private static Logger LOG = Logger.getLogger(DebugWebSocketServer.class.getName()); + private final boolean debug; public DebugWebSocketServer(int port, boolean debug) { @@ -76,7 +84,7 @@ public class DebugWebSocketServer extends NanoWebSocketServer { @Override protected void onException(WebSocket socket, IOException e) { - e.printStackTrace(); + LOG.log(Level.SEVERE,"exception occured",e); } @Override -- cgit v1.2.3