SipSessionGroup: generating 32-bit random number for tag.

and confirm no action when receiving CANCEL in final state.

Change-Id: I6d001d34a5d0bb1b034cb68c769f1af9f6b1e035

1 files changed, 4 insertions, 5 deletions

diff --git a/src/com/android/sip/SipSessionGroup.java b/src/com/android/sip/SipSessionGroup.java
index 094e9d6..8ace93b 100644
--- a/src/com/android/sip/SipSessionGroup.java
+++ b/src/com/android/sip/SipSessionGroup.java
@@ -448,8 +448,8 @@ class SipSessionGroup implements SipListener {
         }
 
         protected String generateTag() {
-            // TODO: based on myself's profile
-            return String.valueOf((long) (Math.random() * 1000000L));
+            // 32-bit randomness
+            return String.valueOf((long) (Math.random() * 0x100000000L));
         }
 
         public String toString() {
@@ -755,9 +755,8 @@ class SipSessionGroup implements SipListener {
                 establishCall();
                 return true;
             } else if (isRequestEvent(Request.CANCEL, evt)) {
-                RequestEvent event = (RequestEvent) evt;
-                // TODO: what to do here? what happens when racing between
-                // OK-to-invite from callee and Cancel from caller
+                // http://tools.ietf.org/html/rfc3261#section-9.2
+                // Final response has been sent; do nothing here.
                 return true;
             }
             return false;