Age | Commit message (Collapse) | Author |
|
|
|
am: 2baece252f
Change-Id: I4e8dd05272e1bcef6032c89f022856ad70ed36e9
|
|
am: 832e01a099
Change-Id: If1f7eeb23b38f6556a200a460401f17d7c275907
|
|
am: 5edf30c23d
Change-Id: I74a9fecf5f9d9a2a21558738248dc41a38deab5a
|
|
|
|
bug:24535627
Change-Id: Ia26810f1f79f573161c0ca0b80a1dcabc883aec8
|
|
2aa19448cfc0dbd159e1f7dcad3e622ac08eb1d0 in master as merged." am: 95880e5eb1 am: e7a565e361
am: df2c3e714d
Change-Id: I922110d7a2e97326e6d40702113b79b4b3ced6a3
|
|
2aa19448cfc0dbd159e1f7dcad3e622ac08eb1d0 in master as merged." am: 95880e5eb1
am: e7a565e361
Change-Id: If9cdd4becb3b13bb7f8a0a1a21243b0ffa7f8e75
|
|
2aa19448cfc0dbd159e1f7dcad3e622ac08eb1d0 in master as merged."
am: 95880e5eb1
Change-Id: I7aceaae900e7b8d624986a7a1a126603f0b7c41e
|
|
2aa19448cfc0dbd159e1f7dcad3e622ac08eb1d0 in master as merged."
|
|
in master as merged.
BUG: 35224217
Change-Id: I9e08e97a686478f8f65f2ecbca59aa1244ac120f
|
|
When a HttpURLConnection is disconnected in the middle of connecting,
this can lead to an infinite loop because:
- StreamAllocation.findConnection() immediately throws
(before advancing the RouteSelector)
- StreamAllocation.recover() returns true, indicating that a
retry is permissible
- higher level logic then retries the connection indefinitely in
a busy loop
This bug does not occur in the latest version of OkHttp (3.5) but
can be reproduced directly on top of OkHttp 2.7.5.
To give us more time to figure out the best fix, this CL makes the
narrowest possible fix for the concrete behavior observed in the wild.
There are related cases where StreamAllocation.recover() returns true
but findConnection() immediately throws; these have not been observed
and are not addressed by this CL:
- StreamAllocation.released; this case looks at first glance like it
is not reachable via publicly exposed API (HttpURLConnection)
- canceled case for recover(IOException e, Sink requestBodyOut):
touching this breaks OkHttp's
CallTest.canceledBeforeIOSignalsOnFailure*() because the reported
error message becomes something like "Socket closed", rather
than reviewed "Canceled".
Test: CtsLibcoreTestCases
Test: CtsLibcoreOkHttpTestCases
Bug: 33763156
Change-Id: Ie8e80559f9364cbd0a01c54b441fc10402b37862
(cherry picked from commit 715f88092afc34bbe129118fa9ed737ad38ec050)
|
|
390c78c5cd am: 66ef890399 am: 3e1f83e9f5
am: 0b809cf8b1
Change-Id: Ib9516599c31ecce369ef10470cd14f672310937b
|
|
390c78c5cd am: 66ef890399
am: 3e1f83e9f5
Change-Id: I68937ee2cbfcc58a5569af40ed171ffd7065f4da
|
|
390c78c5cd
am: 66ef890399
Change-Id: I32e1850f51651f5ed18c7c52e0ef267eab9dbf96
|
|
am: 390c78c5cd
Change-Id: I48700dcc38ca41d857d982c913b32d9920e92ebf
|
|
|
|
When a HttpURLConnection is disconnected in the middle of connecting,
this can lead to an infinite loop because:
- StreamAllocation.findConnection() immediately throws
(before advancing the RouteSelector)
- StreamAllocation.recover() returns true, indicating that a
retry is permissible
- higher level logic then retries the connection indefinitely in
a busy loop
This bug does not occur in the latest version of OkHttp (3.5) but
can be reproduced directly on top of OkHttp 2.7.5.
To give us more time to figure out the best fix, this CL makes the
narrowest possible fix for the concrete behavior observed in the wild.
There are related cases where StreamAllocation.recover() returns true
but findConnection() immediately throws; these have not been observed
and are not addressed by this CL:
- StreamAllocation.released; this case looks at first glance like it
is not reachable via publicly exposed API (HttpURLConnection)
- canceled case for recover(IOException e, Sink requestBodyOut):
touching this breaks OkHttp's
CallTest.canceledBeforeIOSignalsOnFailure*() because the reported
error message becomes something like "Socket closed", rather
than reviewed "Canceled".
Test: CtsLibcoreTestCases
Test: CtsLibcoreOkHttpTestCases
Bug: 33763156
Change-Id: Ie8e80559f9364cbd0a01c54b441fc10402b37862
|
|
nougat-mr1-cts-dev as the commit was marked as DO NOT MERGE." into nougat-mr1-cts-dev am: 2aa19448cf -s ours am: bb26711fdd am: 6aa0b0565f am: 5515db3267
am: ef494fa4ca -s ours
Change-Id: I1de5158ad066af70dffa8c1b40404d5cad31ccb9
|
|
as the commit was marked as DO NOT MERGE. am: cfb32c0926 -s ours am: 72bd84cc18 am: f27b53025b am: 8b8772451b
am: c8ca5c0d22 -s ours
Change-Id: Icb5f1c6c36ab2c160532a33c5e67d1248240354c
|
|
nougat-mr1-cts-dev as the commit was marked as DO NOT MERGE." into nougat-mr1-cts-dev am: 2aa19448cf -s ours am: bb26711fdd am: 6aa0b0565f
am: 5515db3267
Change-Id: I57eabb8a39546703c91e6f3fcb29cc770500c699
|
|
as the commit was marked as DO NOT MERGE. am: cfb32c0926 -s ours am: 72bd84cc18 am: f27b53025b
am: 8b8772451b
Change-Id: I30eb8808b98362075ba6486f36d5c273ad9ca636
|
|
nougat-mr1-cts-dev as the commit was marked as DO NOT MERGE." into nougat-mr1-cts-dev am: 2aa19448cf -s ours am: bb26711fdd am: 6aa0b0565f am: d5de980a7a
am: 5dea99327a -s ours
Change-Id: I45679791cc4cf428a8e3c4ae4238b5bfc5f25c4e
|
|
as the commit was marked as DO NOT MERGE. am: cfb32c0926 -s ours am: 72bd84cc18 am: f27b53025b am: 43c9408dc0
am: 82f5a30c74 -s ours
Change-Id: I090d1b4eb9d22af9c44abd223ca6b5e80bfecf00
|
|
nougat-mr1-cts-dev as the commit was marked as DO NOT MERGE." into nougat-mr1-cts-dev am: 2aa19448cf -s ours am: bb26711fdd am: 6aa0b0565f
am: d5de980a7a
Change-Id: I7df0b7970686333242c584539969278ddadc51e2
|
|
as the commit was marked as DO NOT MERGE. am: cfb32c0926 -s ours am: 72bd84cc18 am: f27b53025b
am: 43c9408dc0
Change-Id: I48760821dea7077052a802dc495f99b17e8c24af
|
|
nougat-mr1-cts-dev as the commit was marked as DO NOT MERGE." into nougat-mr1-cts-dev am: 2aa19448cf -s ours am: bb26711fdd
am: 6aa0b0565f
Change-Id: I0c844fcddc94397683cd8e513c9bbcfcbd5aee07
|
|
nougat-mr1-cts-dev as the commit was marked as DO NOT MERGE." into nougat-mr1-cts-dev am: 2aa19448cf -s ours am: bb26711fdd
am: 6aa0b0565f
Change-Id: Ie424175ac5296feb654ac7e17620249e41411bf7
|
|
as the commit was marked as DO NOT MERGE. am: cfb32c0926 -s ours am: 72bd84cc18
am: f27b53025b
Change-Id: I0dde0ee1a9a93a78e4c76521c6a5c2bc2b686e99
|
|
as the commit was marked as DO NOT MERGE. am: cfb32c0926 -s ours am: 72bd84cc18
am: f27b53025b
Change-Id: I14a54dedd69969c8929dcbca0ccff0ebae4d7c01
|
|
nougat-mr1-cts-dev as the commit was marked as DO NOT MERGE." into nougat-mr1-cts-dev am: 2aa19448cf -s ours
am: bb26711fdd
Change-Id: Icef427c7bca9c030a987d46b4857710f4f353bd2
|
|
as the commit was marked as DO NOT MERGE. am: cfb32c0926 -s ours
am: 72bd84cc18
Change-Id: Ie4a89660150f29649ae21928df3364c05c8ca269
|
|
nougat-mr1-cts-dev as the commit was marked as DO NOT MERGE." into nougat-mr1-cts-dev
am: 2aa19448cf -s ours
Change-Id: I5b1e81a7048ca8567a91fbe459e22dbed6b74865
|
|
as the commit was marked as DO NOT MERGE.
am: cfb32c0926 -s ours
Change-Id: Ie39eb42ba4241ceff3cf97ca30e86e0e57fd3dfc
|
|
nougat-mr1-cts-dev as the commit was marked as DO NOT MERGE." into nougat-mr1-cts-dev
|
|
as the commit was marked as DO NOT MERGE.
BUG: 33090058
Change-Id: I52267eaa84eafa0905482a92aaf19717501cddef
|
|
480165aee0
am: 547297e0f7
Change-Id: I5ddacf5995a24724356707f2b8cf5cf45ed0abb5
|
|
am: 480165aee0
Change-Id: Idc2112e978581372a3f1c75ffdd4a7bc8926d52f
|
|
am: a22b7fe69a
Change-Id: I2ea949b5de8b2a2491851a4c951d3220a13228f0
|
|
am: 0663ccec7f
Change-Id: I9ec7026817b47bb258dd13f9274d893dfeaf1e62
|
|
|
|
Bug: 30188076
Test: make checkbuild
Change-Id: I726c2f80581b2ad5adecc13c3fff81d7f006077a
|
|
values" into nougat-cts-dev am: 92bbc8ec30 -s ours am: 7682043b2a am: 1e86b5a581 am: 182c873a7a am: 5c857a60c5 am: 68f1eabd5a
am: 313cc2e4b6 -s ours
Change-Id: I00abcd6faf9c602ceebbdd5ac41e35783ccda309
|
|
b0026778a4 -s ours am: 54446be3a6 am: 58bb4fe19a am: a148055d19 am: 242c35912b am: 9c64f85401
am: 1f52d62108 -s ours
Change-Id: Id877edc26455e28b23add142935981d6ebd98ea0
|
|
values" into nougat-cts-dev am: 92bbc8ec30 -s ours am: 7682043b2a am: 1e86b5a581 am: 182c873a7a am: 5c857a60c5
am: 68f1eabd5a
Change-Id: I39ffcb9eb537299bf293f6abcb37e483da7c9dd6
|
|
b0026778a4 -s ours am: 54446be3a6 am: 58bb4fe19a am: a148055d19 am: 242c35912b
am: 9c64f85401
Change-Id: I4473eb2d3db1dad975bbd1fae3793150ca5afcdb
|
|
values" into nougat-cts-dev am: 92bbc8ec30 -s ours am: 7682043b2a am: 1e86b5a581 am: 182c873a7a
am: 5c857a60c5
Change-Id: Ib8f2abcbc608667728f2dbb5e353e52c69090722
|
|
b0026778a4 -s ours am: 54446be3a6 am: 58bb4fe19a am: a148055d19
am: 242c35912b
Change-Id: I0f661347b37436db2f3b81141158fdcb22946e74
|
|
values" into nougat-cts-dev am: 92bbc8ec30 -s ours am: 7682043b2a am: 1e86b5a581 am: 182c873a7a am: 5c857a60c5 am: b3efabc628
am: b0d0b0a39f -s ours
Change-Id: Ib8ade3de046fc8e6bd7a84e38d748235d9d43158
|
|
b0026778a4 -s ours am: 54446be3a6 am: 58bb4fe19a am: a148055d19 am: 242c35912b am: c350923a85
am: 3705d23071 -s ours
Change-Id: I8487911d5a53157ef67e793b017fe65fb9c9ca91
|