aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYang Song <songy23@users.noreply.github.com>2017-05-16 12:01:38 -0700
committerGitHub <noreply@github.com>2017-05-16 12:01:38 -0700
commit0a34c32b05cce05dffaba2e947cb0581d0a1df5b (patch)
tree564480a361263c1aa00196d62db7e7ece276731c
parent2b6b1e87d82c7277cb5e4b76a18a62c3d048931b (diff)
downloadopencensus-java-0a34c32b05cce05dffaba2e947cb0581d0a1df5b.tar.gz
Fix a few style issues. (#307)
* Fix a few style issues. * Update check for doubles.
-rw-r--r--core/src/main/java/com/google/instrumentation/trace/TraceConfig.java3
-rw-r--r--core/src/test/java/com/google/instrumentation/stats/DistributionAggregationTest.java22
2 files changed, 15 insertions, 10 deletions
diff --git a/core/src/main/java/com/google/instrumentation/trace/TraceConfig.java b/core/src/main/java/com/google/instrumentation/trace/TraceConfig.java
index d7b97dbf..34b64b36 100644
--- a/core/src/main/java/com/google/instrumentation/trace/TraceConfig.java
+++ b/core/src/main/java/com/google/instrumentation/trace/TraceConfig.java
@@ -125,6 +125,9 @@ public abstract class TraceConfig {
*/
public abstract Builder toBuilder();
+ /**
+ * A {@code Builder} class for {@link TraceParams}.
+ */
@AutoValue.Builder
public abstract static class Builder {
diff --git a/core/src/test/java/com/google/instrumentation/stats/DistributionAggregationTest.java b/core/src/test/java/com/google/instrumentation/stats/DistributionAggregationTest.java
index 633de2bb..572412a2 100644
--- a/core/src/test/java/com/google/instrumentation/stats/DistributionAggregationTest.java
+++ b/core/src/test/java/com/google/instrumentation/stats/DistributionAggregationTest.java
@@ -15,9 +15,8 @@ package com.google.instrumentation.stats;
import static com.google.common.truth.Truth.assertThat;
-import com.google.instrumentation.stats.DistributionAggregation.Range;
-
import com.google.common.testing.EqualsTester;
+import com.google.instrumentation.stats.DistributionAggregation.Range;
import java.util.Arrays;
import java.util.List;
import org.junit.Test;
@@ -29,16 +28,19 @@ import org.junit.runners.JUnit4;
*/
@RunWith(JUnit4.class)
public final class DistributionAggregationTest {
+
+ private static final double TOLERANCE = 1e-6;
+
@Test
public void testDistributionAggregationWithOutBuckets() {
DistributionAggregation aggr = DistributionAggregation.create(10, 5.0, 30.0,
Range.create(1.0, 5.0), TAGS);
assertThat(aggr.getCount()).isEqualTo(10);
- assertThat(aggr.getMean()).isEqualTo(5.0);
- assertThat(aggr.getSum()).isEqualTo(30.0);
- assertThat(aggr.getRange().getMin()).isEqualTo(1.0);
- assertThat(aggr.getRange().getMax()).isEqualTo(5.0);
+ assertThat(aggr.getMean()).isWithin(TOLERANCE).of(5.0);
+ assertThat(aggr.getSum()).isWithin(TOLERANCE).of(30.0);
+ assertThat(aggr.getRange().getMin()).isWithin(TOLERANCE).of(1.0);
+ assertThat(aggr.getRange().getMax()).isWithin(TOLERANCE).of(5.0);
assertThat(aggr.getTags()).hasSize(TAGS.size());
for (int i = 0; i < aggr.getTags().size(); i++) {
assertThat(aggr.getTags().get(i)).isEqualTo(TAGS.get(i));
@@ -53,10 +55,10 @@ public final class DistributionAggregationTest {
Range.create(1.0, 5.0), TAGS, buckets);
assertThat(aggr.getCount()).isEqualTo(10);
- assertThat(aggr.getMean()).isEqualTo(5.0);
- assertThat(aggr.getSum()).isEqualTo(30.0);
- assertThat(aggr.getRange().getMin()).isEqualTo(1.0);
- assertThat(aggr.getRange().getMax()).isEqualTo(5.0);
+ assertThat(aggr.getMean()).isWithin(TOLERANCE).of(5.0);
+ assertThat(aggr.getSum()).isWithin(TOLERANCE).of(30.0);
+ assertThat(aggr.getRange().getMin()).isWithin(TOLERANCE).of(1.0);
+ assertThat(aggr.getRange().getMax()).isWithin(TOLERANCE).of(5.0);
assertThat(aggr.getBucketCounts()).isNotNull();
assertThat(aggr.getBucketCounts()).hasSize(buckets.size());
assertThat(aggr.getTags()).hasSize(TAGS.size());