aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBogdan Drutu <bdrutu@google.com>2017-09-02 13:21:17 -0700
committerGitHub <noreply@github.com>2017-09-02 13:21:17 -0700
commit8d4372eaa0c1b002a0c25ff02a794cf72f0c05d9 (patch)
tree1ac909b643ca5165cefdd3bd214da3b54fc8b901
parent8af5347dab5e0ded1997e67633efa7f8328176fa (diff)
downloadopencensus-java-8d4372eaa0c1b002a0c25ff02a794cf72f0c05d9.tar.gz
Add RedundantImport check and upgrade checkstyle to 8.0. (#579)
-rw-r--r--build.gradle2
-rw-r--r--buildscripts/checkstyle.xml1
-rw-r--r--impl/src/test/java/io/opencensus/impl/internal/DisruptorEventQueueTest.java1
-rw-r--r--impl_core/src/test/java/io/opencensus/implcore/internal/TimestampConverterTest.java1
-rw-r--r--impl_core/src/test/java/io/opencensus/implcore/trace/config/TraceConfigImplTest.java1
-rw-r--r--impl_core/src/test/java/io/opencensus/implcore/trace/internal/ConcurrentIntrusiveListTest.java1
-rw-r--r--impl_lite/src/test/java/io/opencensus/impllite/trace/TraceComponentImplLiteTest.java1
7 files changed, 2 insertions, 6 deletions
diff --git a/build.gradle b/build.gradle
index 1b5b154f..ff98f129 100644
--- a/build.gradle
+++ b/build.gradle
@@ -164,7 +164,7 @@ subprojects {
checkstyle {
configFile = file("$rootDir/buildscripts/checkstyle.xml")
- toolVersion = "7.6"
+ toolVersion = "8.0"
ignoreFailures = false
if (rootProject.hasProperty("checkstyle.ignoreFailures")) {
ignoreFailures = rootProject.properties["checkstyle.ignoreFailures"].toBoolean()
diff --git a/buildscripts/checkstyle.xml b/buildscripts/checkstyle.xml
index 16e10920..fdea0c5e 100644
--- a/buildscripts/checkstyle.xml
+++ b/buildscripts/checkstyle.xml
@@ -50,6 +50,7 @@
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
</module>
<module name="AvoidStarImport"/>
+ <module name="RedundantImport"/>
<module name="OneTopLevelClass"/>
<module name="NoLineWrap"/>
<module name="EmptyBlock">
diff --git a/impl/src/test/java/io/opencensus/impl/internal/DisruptorEventQueueTest.java b/impl/src/test/java/io/opencensus/impl/internal/DisruptorEventQueueTest.java
index 9f8fe1bb..f12498fa 100644
--- a/impl/src/test/java/io/opencensus/impl/internal/DisruptorEventQueueTest.java
+++ b/impl/src/test/java/io/opencensus/impl/internal/DisruptorEventQueueTest.java
@@ -18,7 +18,6 @@ package io.opencensus.impl.internal;
import static com.google.common.truth.Truth.assertThat;
-import io.opencensus.impl.internal.DisruptorEventQueue;
import io.opencensus.implcore.internal.EventQueue;
import org.junit.Test;
import org.junit.runner.RunWith;
diff --git a/impl_core/src/test/java/io/opencensus/implcore/internal/TimestampConverterTest.java b/impl_core/src/test/java/io/opencensus/implcore/internal/TimestampConverterTest.java
index 89d25c04..32a3e687 100644
--- a/impl_core/src/test/java/io/opencensus/implcore/internal/TimestampConverterTest.java
+++ b/impl_core/src/test/java/io/opencensus/implcore/internal/TimestampConverterTest.java
@@ -21,7 +21,6 @@ import static org.mockito.Mockito.when;
import io.opencensus.common.Clock;
import io.opencensus.common.Timestamp;
-import io.opencensus.implcore.internal.TimestampConverter;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
diff --git a/impl_core/src/test/java/io/opencensus/implcore/trace/config/TraceConfigImplTest.java b/impl_core/src/test/java/io/opencensus/implcore/trace/config/TraceConfigImplTest.java
index 77705846..ecaeda6d 100644
--- a/impl_core/src/test/java/io/opencensus/implcore/trace/config/TraceConfigImplTest.java
+++ b/impl_core/src/test/java/io/opencensus/implcore/trace/config/TraceConfigImplTest.java
@@ -18,7 +18,6 @@ package io.opencensus.implcore.trace.config;
import static com.google.common.truth.Truth.assertThat;
-import io.opencensus.implcore.trace.config.TraceConfigImpl;
import io.opencensus.trace.config.TraceParams;
import io.opencensus.trace.samplers.Samplers;
import org.junit.Test;
diff --git a/impl_core/src/test/java/io/opencensus/implcore/trace/internal/ConcurrentIntrusiveListTest.java b/impl_core/src/test/java/io/opencensus/implcore/trace/internal/ConcurrentIntrusiveListTest.java
index c3a86dd9..c78f435f 100644
--- a/impl_core/src/test/java/io/opencensus/implcore/trace/internal/ConcurrentIntrusiveListTest.java
+++ b/impl_core/src/test/java/io/opencensus/implcore/trace/internal/ConcurrentIntrusiveListTest.java
@@ -18,7 +18,6 @@ package io.opencensus.implcore.trace.internal;
import static com.google.common.truth.Truth.assertThat;
-import io.opencensus.implcore.trace.internal.ConcurrentIntrusiveList;
import io.opencensus.implcore.trace.internal.ConcurrentIntrusiveList.Element;
import org.junit.Rule;
import org.junit.Test;
diff --git a/impl_lite/src/test/java/io/opencensus/impllite/trace/TraceComponentImplLiteTest.java b/impl_lite/src/test/java/io/opencensus/impllite/trace/TraceComponentImplLiteTest.java
index 667a0c9c..0cc953ae 100644
--- a/impl_lite/src/test/java/io/opencensus/impllite/trace/TraceComponentImplLiteTest.java
+++ b/impl_lite/src/test/java/io/opencensus/impllite/trace/TraceComponentImplLiteTest.java
@@ -22,7 +22,6 @@ import io.opencensus.implcore.common.MillisClock;
import io.opencensus.implcore.trace.TracerImpl;
import io.opencensus.implcore.trace.export.ExportComponentImpl;
import io.opencensus.implcore.trace.propagation.PropagationComponentImpl;
-import io.opencensus.impllite.trace.TraceComponentImplLite;
import io.opencensus.trace.Tracing;
import org.junit.Test;
import org.junit.runner.RunWith;