diff options
author | Kristen Kozak <sebright@google.com> | 2018-06-13 16:28:51 -0700 |
---|---|---|
committer | Kristen Kozak <sebright@google.com> | 2018-06-13 16:28:51 -0700 |
commit | 372aa6d83035fb6d0bda2a2a8acaf0ce1825d4ba (patch) | |
tree | b7b4cc7b462790b1693118d5152b1d29ba22eed4 /api/src/test/java/io/opencensus | |
parent | 529688f2b63ec98e4e78bf071f8d1b4fbde96eb5 (diff) | |
download | opencensus-java-372aa6d83035fb6d0bda2a2a8acaf0ce1825d4ba.tar.gz |
Error Prone: 2.2.0 -> 2.3.1
This commit contains several other changes as part of the upgrade:
- Use -XepAllDisabledChecksAsWarnings to enable all available warnings so
that we don't need to enable each warning explicitly.
- Remove explicit suppression of warnings in generated code, since
-XepDisableWarningsInGeneratedCode is now sufficient to suppress all warnings
in AutoValue and Protocol Buffer generated classes.
- Remove a suppression of "ConstructorLeaksThis", since
https://github.com/google/error-prone/pull/789 was fixed.
- Fix a few occurrences of "FieldCanBeFinal".
Diffstat (limited to 'api/src/test/java/io/opencensus')
-rw-r--r-- | api/src/test/java/io/opencensus/tags/TagContextTest.java | 3 | ||||
-rw-r--r-- | api/src/test/java/io/opencensus/trace/SpanBuilderTest.java | 2 |
2 files changed, 1 insertions, 4 deletions
diff --git a/api/src/test/java/io/opencensus/tags/TagContextTest.java b/api/src/test/java/io/opencensus/tags/TagContextTest.java index 05473255..025c7bae 100644 --- a/api/src/test/java/io/opencensus/tags/TagContextTest.java +++ b/api/src/test/java/io/opencensus/tags/TagContextTest.java @@ -86,9 +86,6 @@ public final class TagContextTest { private static final class SimpleTagContext extends TagContext { @Nullable private final List<Tag> tags; - // This Error Prone warning doesn't seem correct, because the constructor is just calling - // another constructor. - @SuppressWarnings("ConstructorLeaksThis") SimpleTagContext(Tag... tags) { this(Lists.newArrayList(tags)); } diff --git a/api/src/test/java/io/opencensus/trace/SpanBuilderTest.java b/api/src/test/java/io/opencensus/trace/SpanBuilderTest.java index a929ad97..839c8945 100644 --- a/api/src/test/java/io/opencensus/trace/SpanBuilderTest.java +++ b/api/src/test/java/io/opencensus/trace/SpanBuilderTest.java @@ -37,7 +37,7 @@ import org.mockito.MockitoAnnotations; // Need to suppress warnings for MustBeClosed because Java-6 does not support try-with-resources. @SuppressWarnings("MustBeClosedChecker") public class SpanBuilderTest { - private Tracer tracer = Tracing.getTracer(); + private final Tracer tracer = Tracing.getTracer(); @Mock private SpanBuilder spanBuilder; @Mock private Span span; |