aboutsummaryrefslogtreecommitdiff
path: root/api/src/test/java/io
diff options
context:
space:
mode:
authordvfeinblum <dvfeinblum@gmail.com>2018-04-24 21:48:51 -0400
committersebright <sebright@google.com>2018-04-24 18:48:51 -0700
commit610ff80ebec2b831a7ea6cc73ad4614152a36ad9 (patch)
treee526ab6877484ef02cc49f4beae61868af681a56 /api/src/test/java/io
parent8ff7ff9abec6b7abe95391fb450d99866c6a2c3a (diff)
downloadopencensus-java-610ff80ebec2b831a7ea6cc73ad4614152a36ad9.tar.gz
Added null checking to Span implementations (#1150)
This PR adds null checking to classes that implement Span. Specifically, - BlankSpan - NoopSpan - Span - SpanImpl For the latter, I had to use Preconditions.checkNotNull because io.opencensus.internal shouldn't be imported into ImplCore.
Diffstat (limited to 'api/src/test/java/io')
-rw-r--r--api/src/test/java/io/opencensus/trace/NoopSpan.java22
1 files changed, 17 insertions, 5 deletions
diff --git a/api/src/test/java/io/opencensus/trace/NoopSpan.java b/api/src/test/java/io/opencensus/trace/NoopSpan.java
index 7c8d9b7a..e90f68cd 100644
--- a/api/src/test/java/io/opencensus/trace/NoopSpan.java
+++ b/api/src/test/java/io/opencensus/trace/NoopSpan.java
@@ -16,6 +16,7 @@
package io.opencensus.trace;
+import io.opencensus.internal.Utils;
import java.util.EnumSet;
import java.util.Map;
import javax.annotation.Nullable;
@@ -33,22 +34,33 @@ public class NoopSpan extends Span {
}
@Override
- public void putAttributes(Map<String, AttributeValue> attributes) {}
+ public void putAttributes(Map<String, AttributeValue> attributes) {
+ Utils.checkNotNull(attributes, "attributes");
+ }
@Override
- public void addAnnotation(String description, Map<String, AttributeValue> attributes) {}
+ public void addAnnotation(String description, Map<String, AttributeValue> attributes) {
+ Utils.checkNotNull(description, "description");
+ Utils.checkNotNull(attributes, "attributes");
+ }
@Override
- public void addAnnotation(Annotation annotation) {}
+ public void addAnnotation(Annotation annotation) {
+ Utils.checkNotNull(annotation, "annotation");
+ }
@Override
public void addNetworkEvent(NetworkEvent networkEvent) {}
@Override
- public void addMessageEvent(MessageEvent messageEvent) {}
+ public void addMessageEvent(MessageEvent messageEvent) {
+ Utils.checkNotNull(messageEvent, "messageEvent");
+ }
@Override
- public void addLink(Link link) {}
+ public void addLink(Link link) {
+ Utils.checkNotNull(link, "link");
+ }
@Override
public void end(EndSpanOptions options) {}