aboutsummaryrefslogtreecommitdiff
path: root/api/src/test
diff options
context:
space:
mode:
authorYang Song <songy23@users.noreply.github.com>2018-08-13 11:36:27 -0700
committerGitHub <noreply@github.com>2018-08-13 11:36:27 -0700
commit775816d699bd4f02788db5609a87386940e34aff (patch)
tree021d47fb4c67d0441a5861a9e4a69b8d168e572d /api/src/test
parent66ae2eed952579e6982b05c0bcebe0670afb0afe (diff)
downloadopencensus-java-775816d699bd4f02788db5609a87386940e34aff.tar.gz
Metrics: Implement ExportComponent, make ProducerManager abstract. (#1347)
* Metrics: Implement ExportComponent, make ProducerManager abstract. * Metrics: Add impl and impllite. * Resolve two TODOs. * Fix import path, leave a TODO for getMetricRegistry. * Make NoopMetricProducerManager private. Add missing since tag.
Diffstat (limited to 'api/src/test')
-rw-r--r--api/src/test/java/io/opencensus/metrics/export/MetricProducerManagerTest.java40
1 files changed, 4 insertions, 36 deletions
diff --git a/api/src/test/java/io/opencensus/metrics/export/MetricProducerManagerTest.java b/api/src/test/java/io/opencensus/metrics/export/MetricProducerManagerTest.java
index b79de213..07854927 100644
--- a/api/src/test/java/io/opencensus/metrics/export/MetricProducerManagerTest.java
+++ b/api/src/test/java/io/opencensus/metrics/export/MetricProducerManagerTest.java
@@ -19,7 +19,6 @@ package io.opencensus.metrics.export;
import static com.google.common.truth.Truth.assertThat;
import io.opencensus.metrics.MetricProducer;
-import java.util.Set;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
@@ -32,9 +31,9 @@ import org.mockito.MockitoAnnotations;
/** Unit tests for {@link MetricProducerManager}. */
@RunWith(JUnit4.class)
public class MetricProducerManagerTest {
- private final MetricProducerManager metricProducerManager = new MetricProducerManager();
+ private final MetricProducerManager metricProducerManager =
+ MetricProducerManager.newNoopMetricProducerManager();
@Mock private MetricProducer metricProducer;
- @Mock private MetricProducer metricProducerOther;
@Rule public final ExpectedException thrown = ExpectedException.none();
@@ -52,34 +51,13 @@ public class MetricProducerManagerTest {
@Test
public void add() {
metricProducerManager.add(metricProducer);
- assertThat(metricProducerManager.getAllMetricProducer()).containsExactly(metricProducer);
- }
-
- @Test
- public void add_DuplicateElement() {
- metricProducerManager.add(metricProducer);
- Set<MetricProducer> metricProducerSet = metricProducerManager.getAllMetricProducer();
- assertThat(metricProducerSet).containsExactly(metricProducer);
- metricProducerManager.add(metricProducer);
- // Returns the same object.
- assertThat(metricProducerManager.getAllMetricProducer()).isSameAs(metricProducerSet);
- }
-
- @Test
- public void add_MultipleElements() {
- metricProducerManager.add(metricProducer);
- Set<MetricProducer> metricProducerSet = metricProducerManager.getAllMetricProducer();
- assertThat(metricProducerSet).containsExactly(metricProducer);
- metricProducerManager.add(metricProducerOther);
- // Returns the same object.
- assertThat(metricProducerManager.getAllMetricProducer())
- .containsExactly(metricProducer, metricProducerOther);
+ assertThat(metricProducerManager.getAllMetricProducer()).isEmpty();
}
@Test
public void addAndRemove() {
metricProducerManager.add(metricProducer);
- assertThat(metricProducerManager.getAllMetricProducer()).containsExactly(metricProducer);
+ assertThat(metricProducerManager.getAllMetricProducer()).isEmpty();
metricProducerManager.remove(metricProducer);
assertThat(metricProducerManager.getAllMetricProducer()).isEmpty();
}
@@ -97,16 +75,6 @@ public class MetricProducerManagerTest {
}
@Test
- public void remove_NotPresent() {
- metricProducerManager.add(metricProducer);
- Set<MetricProducer> metricProducerSet = metricProducerManager.getAllMetricProducer();
- assertThat(metricProducerSet).containsExactly(metricProducer);
- metricProducerManager.remove(metricProducerOther);
- // Returns the same object.
- assertThat(metricProducerManager.getAllMetricProducer()).isSameAs(metricProducerSet);
- }
-
- @Test
public void getAllMetricProducer_empty() {
assertThat(metricProducerManager.getAllMetricProducer()).isEmpty();
}