aboutsummaryrefslogtreecommitdiff
path: root/api
diff options
context:
space:
mode:
authorsebright <sebright@google.com>2018-06-13 16:50:35 -0700
committerGitHub <noreply@github.com>2018-06-13 16:50:35 -0700
commit2ed7c02191c72028af1a5ec28bb6c127fc9e5ae2 (patch)
tree84068dbaa9a7858b9852a6cf336102c0dfe3494a /api
parent75a5135391e0e704db08e2291ad916ba4aeb7749 (diff)
parent372aa6d83035fb6d0bda2a2a8acaf0ce1825d4ba (diff)
downloadopencensus-java-2ed7c02191c72028af1a5ec28bb6c127fc9e5ae2.tar.gz
Error Prone: 2.2.0 -> 2.3.1
Diffstat (limited to 'api')
-rw-r--r--api/src/main/java/io/opencensus/trace/CurrentSpanUtils.java2
-rw-r--r--api/src/test/java/io/opencensus/tags/TagContextTest.java3
-rw-r--r--api/src/test/java/io/opencensus/trace/SpanBuilderTest.java2
3 files changed, 2 insertions, 5 deletions
diff --git a/api/src/main/java/io/opencensus/trace/CurrentSpanUtils.java b/api/src/main/java/io/opencensus/trace/CurrentSpanUtils.java
index a249d152..21511142 100644
--- a/api/src/main/java/io/opencensus/trace/CurrentSpanUtils.java
+++ b/api/src/main/java/io/opencensus/trace/CurrentSpanUtils.java
@@ -78,7 +78,7 @@ final class CurrentSpanUtils {
private static final class ScopeInSpan implements Scope {
private final Context origContext;
private final Span span;
- private boolean endSpan;
+ private final boolean endSpan;
/**
* Constructs a new {@link ScopeInSpan}.
diff --git a/api/src/test/java/io/opencensus/tags/TagContextTest.java b/api/src/test/java/io/opencensus/tags/TagContextTest.java
index 05473255..025c7bae 100644
--- a/api/src/test/java/io/opencensus/tags/TagContextTest.java
+++ b/api/src/test/java/io/opencensus/tags/TagContextTest.java
@@ -86,9 +86,6 @@ public final class TagContextTest {
private static final class SimpleTagContext extends TagContext {
@Nullable private final List<Tag> tags;
- // This Error Prone warning doesn't seem correct, because the constructor is just calling
- // another constructor.
- @SuppressWarnings("ConstructorLeaksThis")
SimpleTagContext(Tag... tags) {
this(Lists.newArrayList(tags));
}
diff --git a/api/src/test/java/io/opencensus/trace/SpanBuilderTest.java b/api/src/test/java/io/opencensus/trace/SpanBuilderTest.java
index a929ad97..839c8945 100644
--- a/api/src/test/java/io/opencensus/trace/SpanBuilderTest.java
+++ b/api/src/test/java/io/opencensus/trace/SpanBuilderTest.java
@@ -37,7 +37,7 @@ import org.mockito.MockitoAnnotations;
// Need to suppress warnings for MustBeClosed because Java-6 does not support try-with-resources.
@SuppressWarnings("MustBeClosedChecker")
public class SpanBuilderTest {
- private Tracer tracer = Tracing.getTracer();
+ private final Tracer tracer = Tracing.getTracer();
@Mock private SpanBuilder spanBuilder;
@Mock private Span span;