diff options
| author | Kristen Kozak <sebright@google.com> | 2018-03-23 15:14:29 -0700 |
|---|---|---|
| committer | Kristen Kozak <sebright@google.com> | 2018-03-23 19:41:50 -0700 |
| commit | cc7c7e1dbc516b57122e61284aebbc385cbecca1 (patch) | |
| tree | 317c94889e4313a5033e37b8194dd7ff0868ace8 /api | |
| parent | 63fb16f6cb331d4020fc3f6b8eec7006385cd32e (diff) | |
| download | opencensus-java-cc7c7e1dbc516b57122e61284aebbc385cbecca1.tar.gz | |
Enable FindBugs in tests.
This would have caught the unused variable that was fixed by #1082.
Changes in this commit:
- Enable FindBugs in tests in build.gradle.
- Fix some existing minor FindBugs issues in tests.
- Suppress some warnings in all test classes that are less important in test
code, such as requiring nested classes to be static whenever possible.
- Enable nullness-related FindBugs warnings in tests, since we don't run the
Checker Framework on test code.
Diffstat (limited to 'api')
| -rw-r--r-- | api/src/test/java/io/opencensus/trace/export/NoopSampledSpanStoreTest.java | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/api/src/test/java/io/opencensus/trace/export/NoopSampledSpanStoreTest.java b/api/src/test/java/io/opencensus/trace/export/NoopSampledSpanStoreTest.java index e18621ac..6e9c7b0f 100644 --- a/api/src/test/java/io/opencensus/trace/export/NoopSampledSpanStoreTest.java +++ b/api/src/test/java/io/opencensus/trace/export/NoopSampledSpanStoreTest.java @@ -23,9 +23,7 @@ import io.opencensus.trace.Status.CanonicalCode; import java.util.Collection; import java.util.Collections; import java.util.Set; -import org.junit.Rule; import org.junit.Test; -import org.junit.rules.ExpectedException; import org.junit.runner.RunWith; import org.junit.runners.JUnit4; @@ -33,7 +31,6 @@ import org.junit.runners.JUnit4; @RunWith(JUnit4.class) public final class NoopSampledSpanStoreTest { - @Rule public final ExpectedException thrown = ExpectedException.none(); private static final SampledSpanStore.PerSpanNameSummary EMPTY_PER_SPAN_NAME_SUMMARY = SampledSpanStore.PerSpanNameSummary.create( Collections.<SampledSpanStore.LatencyBucketBoundaries, Integer>emptyMap(), |