diff options
| author | Kristen Kozak <sebright@google.com> | 2017-12-19 20:02:00 -0800 |
|---|---|---|
| committer | Kristen Kozak <sebright@google.com> | 2017-12-19 20:02:00 -0800 |
| commit | 2fc0d4dd057ca28e1e9c37d18ebcfac6d2136de9 (patch) | |
| tree | e7f398cc1cb4a8cf52d04e1ea0875d873cff4412 /contrib | |
| parent | 18cf999ddea65775db2a482e00cea05d52961077 (diff) | |
| download | opencensus-java-2fc0d4dd057ca28e1e9c37d18ebcfac6d2136de9.tar.gz | |
Suppress some Checker Framework warnings and add TODOs (issue #359).
Fixing these warnings will require significant refactoring.
Diffstat (limited to 'contrib')
3 files changed, 11 insertions, 1 deletions
diff --git a/contrib/agent/src/main/java/io/opencensus/contrib/agent/bootstrap/ContextTrampoline.java b/contrib/agent/src/main/java/io/opencensus/contrib/agent/bootstrap/ContextTrampoline.java index dd250790..382a161d 100644 --- a/contrib/agent/src/main/java/io/opencensus/contrib/agent/bootstrap/ContextTrampoline.java +++ b/contrib/agent/src/main/java/io/opencensus/contrib/agent/bootstrap/ContextTrampoline.java @@ -31,6 +31,8 @@ package io.opencensus.contrib.agent.bootstrap; * <p>{@code ContextTrampoline} is implemented as a static class to allow for easy and fast use from * instrumented bytecode. We cannot use dependency injection for the instrumented bytecode. */ +// TODO(sebright): Fix the Checker Framework warnings. +@SuppressWarnings("nullness") public final class ContextTrampoline { // Not synchronized to avoid any synchronization costs after initialization. diff --git a/contrib/agent/src/main/java/io/opencensus/contrib/agent/bootstrap/TraceTrampoline.java b/contrib/agent/src/main/java/io/opencensus/contrib/agent/bootstrap/TraceTrampoline.java index 975caf99..b4501b45 100644 --- a/contrib/agent/src/main/java/io/opencensus/contrib/agent/bootstrap/TraceTrampoline.java +++ b/contrib/agent/src/main/java/io/opencensus/contrib/agent/bootstrap/TraceTrampoline.java @@ -35,6 +35,8 @@ import javax.annotation.Nullable; * <p>{@code TraceTrampoline} is implemented as a static class to allow for easy and fast use from * instrumented bytecode. We cannot use dependency injection for the instrumented bytecode. */ +// TODO(sebright): Fix the Checker Framework warnings. +@SuppressWarnings("nullness") public final class TraceTrampoline { // Not synchronized to avoid any synchronization costs after initialization. diff --git a/contrib/zpages/src/main/java/io/opencensus/contrib/zpages/TracezZPageHandler.java b/contrib/zpages/src/main/java/io/opencensus/contrib/zpages/TracezZPageHandler.java index a1f3545b..7a42c2c7 100644 --- a/contrib/zpages/src/main/java/io/opencensus/contrib/zpages/TracezZPageHandler.java +++ b/contrib/zpages/src/main/java/io/opencensus/contrib/zpages/TracezZPageHandler.java @@ -370,7 +370,7 @@ final class TracezZPageHandler extends ZPageHandler { .escape( event.getEvent() instanceof Annotation ? renderAnnotation((Annotation) event.getEvent()) - : renderNetworkEvents((NetworkEvent) event.getEvent()))); + : renderNetworkEvents((NetworkEvent) castNonNull(event.getEvent())))); lastTimestampNanos = event.getTimestamp(); } @@ -383,6 +383,12 @@ final class TracezZPageHandler extends ZPageHandler { "", htmlEscaper().escape(renderAttributes(span.getAttributes().getAttributeMap()))); } + // TODO(sebright): Remove this method. + @SuppressWarnings("nullness") + private static <T> T castNonNull(@Nullable T arg) { + return arg; + } + // Emits the summary table with links to all samples. private void emitSummaryTable(PrintWriter out, Formatter formatter) throws UnsupportedEncodingException { |