Merge pull request #1086 from sebright/run-findbugs-on-tests

Enable FindBugs in tests.

5 files changed, 8 insertions, 20 deletions

diff --git a/exporters/stats/prometheus/src/test/java/io/opencensus/exporter/stats/prometheus/PrometheusStatsCollectorTest.java b/exporters/stats/prometheus/src/test/java/io/opencensus/exporter/stats/prometheus/PrometheusStatsCollectorTest.java
index b10164e7..73f72dba 100644
--- a/exporters/stats/prometheus/src/test/java/io/opencensus/exporter/stats/prometheus/PrometheusStatsCollectorTest.java
+++ b/exporters/stats/prometheus/src/test/java/io/opencensus/exporter/stats/prometheus/PrometheusStatsCollectorTest.java
@@ -40,9 +40,7 @@ import io.prometheus.client.Collector.Type;
 import java.util.Arrays;
 import java.util.Collections;
 import org.junit.Before;
-import org.junit.Rule;
 import org.junit.Test;
-import org.junit.rules.ExpectedException;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
 import org.mockito.Mock;
@@ -52,8 +50,6 @@ import org.mockito.MockitoAnnotations;
 @RunWith(JUnit4.class)
 public class PrometheusStatsCollectorTest {
 
-  @Rule public final ExpectedException thrown = ExpectedException.none();
-
   private static final Cumulative CUMULATIVE = Cumulative.create();
   private static final BucketBoundaries BUCKET_BOUNDARIES =
       BucketBoundaries.create(Arrays.asList(-5.0, 0.0, 5.0));
diff --git a/exporters/stats/signalfx/src/test/java/io/opencensus/exporter/stats/signalfx/SignalFxSessionAdaptorTest.java b/exporters/stats/signalfx/src/test/java/io/opencensus/exporter/stats/signalfx/SignalFxSessionAdaptorTest.java
index 01caa8fe..3ce2e869 100644
--- a/exporters/stats/signalfx/src/test/java/io/opencensus/exporter/stats/signalfx/SignalFxSessionAdaptorTest.java
+++ b/exporters/stats/signalfx/src/test/java/io/opencensus/exporter/stats/signalfx/SignalFxSessionAdaptorTest.java
@@ -106,7 +106,7 @@ public class SignalFxSessionAdaptorTest {
             Aggregation.Sum.create(), AggregationWindow.Interval.create(ONE_SECOND)));
     assertNull(
         SignalFxSessionAdaptor.getMetricTypeForAggregation(
-            Aggregation.Distribution.create(BucketBoundaries.create(ImmutableList.of(3.14d))),
+            Aggregation.Distribution.create(BucketBoundaries.create(ImmutableList.of(3.15d))),
             AggregationWindow.Cumulative.create()));
   }
 
@@ -143,7 +143,7 @@ public class SignalFxSessionAdaptorTest {
   public void unsupportedAggregationYieldsNoDatapoints() {
     Mockito.when(view.getAggregation())
         .thenReturn(
-            Aggregation.Distribution.create(BucketBoundaries.create(ImmutableList.of(3.14d))));
+            Aggregation.Distribution.create(BucketBoundaries.create(ImmutableList.of(3.15d))));
     Mockito.when(view.getWindow()).thenReturn(AggregationWindow.Cumulative.create());
     List<DataPoint> datapoints = SignalFxSessionAdaptor.adapt(viewData);
     assertEquals(0, datapoints.size());
@@ -159,12 +159,12 @@ public class SignalFxSessionAdaptorTest {
 
   @Test
   public void createDatumFromDoubleSum() {
-    SumDataDouble data = SumDataDouble.create(3.14d);
+    SumDataDouble data = SumDataDouble.create(3.15d);
     Datum datum = SignalFxSessionAdaptor.createDatum(data);
     assertTrue(datum.hasDoubleValue());
     assertFalse(datum.hasIntValue());
     assertFalse(datum.hasStrValue());
-    assertEquals(3.14d, datum.getDoubleValue(), 0d);
+    assertEquals(3.15d, datum.getDoubleValue(), 0d);
   }
 
   @Test
@@ -189,12 +189,12 @@ public class SignalFxSessionAdaptorTest {
 
   @Test
   public void createDatumFromMean() {
-    MeanData data = MeanData.create(3.14d, 2L);
+    MeanData data = MeanData.create(3.15d, 2L);
     Datum datum = SignalFxSessionAdaptor.createDatum(data);
     assertTrue(datum.hasDoubleValue());
     assertFalse(datum.hasIntValue());
     assertFalse(datum.hasStrValue());
-    assertEquals(3.14d, datum.getDoubleValue(), 0d);
+    assertEquals(3.15d, datum.getDoubleValue(), 0d);
   }
 
   @Test
diff --git a/exporters/stats/signalfx/src/test/java/io/opencensus/exporter/stats/signalfx/SignalFxStatsExporterWorkerThreadTest.java b/exporters/stats/signalfx/src/test/java/io/opencensus/exporter/stats/signalfx/SignalFxStatsExporterWorkerThreadTest.java
index 5f03304d..d8852d5f 100644
--- a/exporters/stats/signalfx/src/test/java/io/opencensus/exporter/stats/signalfx/SignalFxStatsExporterWorkerThreadTest.java
+++ b/exporters/stats/signalfx/src/test/java/io/opencensus/exporter/stats/signalfx/SignalFxStatsExporterWorkerThreadTest.java
@@ -126,7 +126,7 @@ public class SignalFxStatsExporterWorkerThreadTest {
     Mockito.when(viewData.getAggregationMap())
         .thenReturn(
             ImmutableMap.<List<TagValue>, AggregationData>of(
-                ImmutableList.of(TagValue.create("cat")), MeanData.create(3.14d, 1)));
+                ImmutableList.of(TagValue.create("cat")), MeanData.create(3.15d, 1)));
 
     Mockito.when(viewManager.getAllExportedViews()).thenReturn(ImmutableSet.of(view));
     Mockito.when(viewManager.getView(Mockito.eq(viewName))).thenReturn(viewData);
@@ -141,7 +141,7 @@ public class SignalFxStatsExporterWorkerThreadTest {
             .setMetric("test")
             .setMetricType(MetricType.GAUGE)
             .addDimensions(Dimension.newBuilder().setKey("animal").setValue("cat").build())
-            .setValue(Datum.newBuilder().setDoubleValue(3.14d).build())
+            .setValue(Datum.newBuilder().setDoubleValue(3.15d).build())
             .build();
     Mockito.verify(session).setDatapoint(Mockito.eq(datapoint));
     Mockito.verify(session).close();
diff --git a/exporters/stats/stackdriver/src/test/java/io/opencensus/exporter/stats/stackdriver/StackdriverExporterWorkerTest.java b/exporters/stats/stackdriver/src/test/java/io/opencensus/exporter/stats/stackdriver/StackdriverExporterWorkerTest.java
index ac739a8f..9aa91a80 100644
--- a/exporters/stats/stackdriver/src/test/java/io/opencensus/exporter/stats/stackdriver/StackdriverExporterWorkerTest.java
+++ b/exporters/stats/stackdriver/src/test/java/io/opencensus/exporter/stats/stackdriver/StackdriverExporterWorkerTest.java
@@ -55,9 +55,7 @@ import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
 import org.junit.Before;
-import org.junit.Rule;
 import org.junit.Test;
-import org.junit.rules.ExpectedException;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
 import org.mockito.Mock;
@@ -84,8 +82,6 @@ public class StackdriverExporterWorkerTest {
   private static final MonitoredResource DEFAULT_RESOURCE =
       MonitoredResource.newBuilder().setType("global").build();
 
-  @Rule public final ExpectedException thrown = ExpectedException.none();
-
   @Mock private ViewManager mockViewManager;
 
   @Mock private MetricServiceStub mockStub;
diff --git a/exporters/stats/stackdriver/src/test/java/io/opencensus/exporter/stats/stackdriver/StackdriverStatsConfigurationTest.java b/exporters/stats/stackdriver/src/test/java/io/opencensus/exporter/stats/stackdriver/StackdriverStatsConfigurationTest.java
index 74701560..cff8ce3b 100644
--- a/exporters/stats/stackdriver/src/test/java/io/opencensus/exporter/stats/stackdriver/StackdriverStatsConfigurationTest.java
+++ b/exporters/stats/stackdriver/src/test/java/io/opencensus/exporter/stats/stackdriver/StackdriverStatsConfigurationTest.java
@@ -24,9 +24,7 @@ import com.google.auth.oauth2.AccessToken;
 import com.google.auth.oauth2.GoogleCredentials;
 import io.opencensus.common.Duration;
 import java.util.Date;
-import org.junit.Rule;
 import org.junit.Test;
-import org.junit.rules.ExpectedException;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
 
@@ -34,8 +32,6 @@ import org.junit.runners.JUnit4;
 @RunWith(JUnit4.class)
 public class StackdriverStatsConfigurationTest {
 
-  @Rule public final ExpectedException thrown = ExpectedException.none();
-
   private static final Credentials FAKE_CREDENTIALS =
       GoogleCredentials.newBuilder().setAccessToken(new AccessToken("fake", new Date(100))).build();
   private static final String PROJECT_ID = "project";