Tracing: Add AttributeValueDouble. (#1442)

Also update Trace exporters and ZPages, and fix a few typos.

4 files changed, 30 insertions, 1 deletions

diff --git a/exporters/trace/instana/src/main/java/io/opencensus/exporter/trace/instana/InstanaExporterHandler.java b/exporters/trace/instana/src/main/java/io/opencensus/exporter/trace/instana/InstanaExporterHandler.java
index fd329c4a..1bbb665a 100644
--- a/exporters/trace/instana/src/main/java/io/opencensus/exporter/trace/instana/InstanaExporterHandler.java
+++ b/exporters/trace/instana/src/main/java/io/opencensus/exporter/trace/instana/InstanaExporterHandler.java
@@ -127,6 +127,7 @@ final class InstanaExporterHandler extends SpanExporter.Handler {
         returnToString,
         returnToString,
         returnToString,
+        returnToString,
         Functions.</*@Nullable*/ String>returnNull());
   }
 
diff --git a/exporters/trace/jaeger/src/main/java/io/opencensus/exporter/trace/jaeger/JaegerExporterHandler.java b/exporters/trace/jaeger/src/main/java/io/opencensus/exporter/trace/jaeger/JaegerExporterHandler.java
index 9ee7fab2..e0a16296 100644
--- a/exporters/trace/jaeger/src/main/java/io/opencensus/exporter/trace/jaeger/JaegerExporterHandler.java
+++ b/exporters/trace/jaeger/src/main/java/io/opencensus/exporter/trace/jaeger/JaegerExporterHandler.java
@@ -97,6 +97,17 @@ final class JaegerExporterHandler extends SpanExporter.Handler {
         }
       };
 
+  private static final Function<? super Double, Tag> doubleAttributeConverter =
+      new Function<Double, Tag>() {
+        @Override
+        public Tag apply(final Double value) {
+          final Tag tag = new Tag();
+          tag.setVType(TagType.DOUBLE);
+          tag.setVDouble(value);
+          return tag;
+        }
+      };
+
   private static final Function<? super Long, Tag> longAttributeConverter =
       new Function<Long, Tag>() {
         @Override
@@ -281,6 +292,7 @@ final class JaegerExporterHandler extends SpanExporter.Handler {
                   stringAttributeConverter,
                   booleanAttributeConverter,
                   longAttributeConverter,
+                  doubleAttributeConverter,
                   defaultAttributeConverter);
       tag.setKey(entry.getKey());
       tags.add(tag);
diff --git a/exporters/trace/stackdriver/src/main/java/io/opencensus/exporter/trace/stackdriver/StackdriverV2ExporterHandler.java b/exporters/trace/stackdriver/src/main/java/io/opencensus/exporter/trace/stackdriver/StackdriverV2ExporterHandler.java
index 16a880c2..9237ded5 100644
--- a/exporters/trace/stackdriver/src/main/java/io/opencensus/exporter/trace/stackdriver/StackdriverV2ExporterHandler.java
+++ b/exporters/trace/stackdriver/src/main/java/io/opencensus/exporter/trace/stackdriver/StackdriverV2ExporterHandler.java
@@ -133,6 +133,17 @@ final class StackdriverV2ExporterHandler extends SpanExporter.Handler {
           return attributeValueBuilder.build();
         }
       };
+  private static final Function<Double, /*@Nullable*/ AttributeValue> doubleAttributeValueFunction =
+      new Function<Double, /*@Nullable*/ AttributeValue>() {
+        @Override
+        public AttributeValue apply(Double doubleValue) {
+          Builder attributeValueBuilder = AttributeValue.newBuilder();
+          // TODO: set double value if Stackdriver Trace support it in the future.
+          attributeValueBuilder.setStringValue(
+              toTruncatableStringProto(String.valueOf(doubleValue)));
+          return attributeValueBuilder.build();
+        }
+      };
 
   private final String projectId;
   private final TraceServiceClient traceServiceClient;
@@ -426,6 +437,7 @@ final class StackdriverV2ExporterHandler extends SpanExporter.Handler {
         stringAttributeValueFunction,
         booleanAttributeValueFunction,
         longAttributeValueFunction,
+        doubleAttributeValueFunction,
         Functions.</*@Nullable*/ AttributeValue>returnNull());
   }
 
diff --git a/exporters/trace/zipkin/src/main/java/io/opencensus/exporter/trace/zipkin/ZipkinExporterHandler.java b/exporters/trace/zipkin/src/main/java/io/opencensus/exporter/trace/zipkin/ZipkinExporterHandler.java
index 5a655f1e..711dcaa9 100644
--- a/exporters/trace/zipkin/src/main/java/io/opencensus/exporter/trace/zipkin/ZipkinExporterHandler.java
+++ b/exporters/trace/zipkin/src/main/java/io/opencensus/exporter/trace/zipkin/ZipkinExporterHandler.java
@@ -182,7 +182,11 @@ final class ZipkinExporterHandler extends SpanExporter.Handler {
 
   private static String attributeValueToString(AttributeValue attributeValue) {
     return attributeValue.match(
-        returnToString, returnToString, returnToString, Functions.<String>returnConstant(""));
+        returnToString,
+        returnToString,
+        returnToString,
+        returnToString,
+        Functions.<String>returnConstant(""));
   }
 
   @Override