diff options
author | Yang Song <songy23@users.noreply.github.com> | 2018-09-18 16:25:14 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-09-18 16:25:14 -0700 |
commit | 7da904c4e75d68eaf77ecaca59e82fa932251e0c (patch) | |
tree | facb0f32924df0ad6d60a0d1cc54dc101c22efd7 /exporters | |
parent | 0a3fb9761fbc0d31e06a60dcb650c9e9a8d5f5f3 (diff) | |
download | opencensus-java-7da904c4e75d68eaf77ecaca59e82fa932251e0c.tar.gz |
Common: Add an API Functions.returnToString(). (#1443)
* Common: Add an API Functions.returnToString().
* Fix comments and add tests.
Diffstat (limited to 'exporters')
2 files changed, 5 insertions, 13 deletions
diff --git a/exporters/trace/instana/src/main/java/io/opencensus/exporter/trace/instana/InstanaExporterHandler.java b/exporters/trace/instana/src/main/java/io/opencensus/exporter/trace/instana/InstanaExporterHandler.java index 1bbb665a..649a026f 100644 --- a/exporters/trace/instana/src/main/java/io/opencensus/exporter/trace/instana/InstanaExporterHandler.java +++ b/exporters/trace/instana/src/main/java/io/opencensus/exporter/trace/instana/InstanaExporterHandler.java @@ -114,12 +114,7 @@ final class InstanaExporterHandler extends SpanExporter.Handler { // The return type needs to be nullable when this function is used as an argument to 'match' in // attributeValueToString, because 'match' doesn't allow covariant return types. private static final Function<Object, /*@Nullable*/ String> returnToString = - new Function<Object, /*@Nullable*/ String>() { - @Override - public String apply(Object input) { - return input.toString(); - } - }; + Functions.returnToString(); @javax.annotation.Nullable private static String attributeValueToString(AttributeValue attributeValue) { diff --git a/exporters/trace/zipkin/src/main/java/io/opencensus/exporter/trace/zipkin/ZipkinExporterHandler.java b/exporters/trace/zipkin/src/main/java/io/opencensus/exporter/trace/zipkin/ZipkinExporterHandler.java index 711dcaa9..70bc725c 100644 --- a/exporters/trace/zipkin/src/main/java/io/opencensus/exporter/trace/zipkin/ZipkinExporterHandler.java +++ b/exporters/trace/zipkin/src/main/java/io/opencensus/exporter/trace/zipkin/ZipkinExporterHandler.java @@ -172,14 +172,11 @@ final class ZipkinExporterHandler extends SpanExporter.Handler { // The return type needs to be nullable when this function is used as an argument to 'match' in // attributeValueToString, because 'match' doesn't allow covariant return types. - private static final Function<Object, String> returnToString = - new Function<Object, String>() { - @Override - public String apply(Object input) { - return input.toString(); - } - }; + private static final Function<Object, /*@Nullable*/ String> returnToString = + Functions.returnToString(); + // TODO: Fix the Checker Framework warning. + @SuppressWarnings("nullness") private static String attributeValueToString(AttributeValue attributeValue) { return attributeValue.match( returnToString, |