diff options
author | Yang Song <songy23@users.noreply.github.com> | 2018-04-16 12:13:59 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-04-16 12:13:59 -0700 |
commit | 3e4352b3684b4646a82eef4f2da66038531d821e (patch) | |
tree | 167f5835f480364427692f153c8d5a0da9fc2a7a /impl_core/src/test/java/io/opencensus/implcore | |
parent | b964cdfceb9ddcb5323aad99e1d75cbd417b1c5a (diff) | |
download | opencensus-java-3e4352b3684b4646a82eef4f2da66038531d821e.tar.gz |
Move toMillis(Duration) to Utils so that it can be reused. (#1114)
* Add toMillis() method to TimeUtils.
* Reuse toMillis() method in impl and exporters.
* Add a note about overflow and precision loss.
* Move toMillis() to Duration.
Diffstat (limited to 'impl_core/src/test/java/io/opencensus/implcore')
-rw-r--r-- | impl_core/src/test/java/io/opencensus/implcore/stats/MutableViewDataTest.java | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/impl_core/src/test/java/io/opencensus/implcore/stats/MutableViewDataTest.java b/impl_core/src/test/java/io/opencensus/implcore/stats/MutableViewDataTest.java index b4b4c85b..bde75232 100644 --- a/impl_core/src/test/java/io/opencensus/implcore/stats/MutableViewDataTest.java +++ b/impl_core/src/test/java/io/opencensus/implcore/stats/MutableViewDataTest.java @@ -17,10 +17,8 @@ package io.opencensus.implcore.stats; import static com.google.common.truth.Truth.assertThat; -import static io.opencensus.implcore.stats.MutableViewData.toMillis; import com.google.common.collect.ImmutableMap; -import io.opencensus.common.Duration; import io.opencensus.common.Timestamp; import io.opencensus.implcore.stats.MutableAggregation.MutableCount; import io.opencensus.implcore.stats.MutableAggregation.MutableDistribution; @@ -134,14 +132,4 @@ public class MutableViewDataTest { Arrays.asList(new Long[] {0L, 0L, 0L, 0L}))) .inOrder(); } - - @Test - public void testDurationToMillis() { - assertThat(toMillis(Duration.create(0, 0))).isEqualTo(0); - assertThat(toMillis(Duration.create(0, 987000000))).isEqualTo(987); - assertThat(toMillis(Duration.create(3, 456000000))).isEqualTo(3456); - assertThat(toMillis(Duration.create(0, -1000000))).isEqualTo(-1); - assertThat(toMillis(Duration.create(-1, 0))).isEqualTo(-1000); - assertThat(toMillis(Duration.create(-3, -456000000))).isEqualTo(-3456); - } } |