From 05f5bdd7c1628a3e434542fa2af1ab2b5ccf20ce Mon Sep 17 00:00:00 2001 From: Kristen Kozak Date: Fri, 27 Apr 2018 13:08:48 -0700 Subject: Check for null in more public methods in Span and its subclasses. --- impl_core/src/main/java/io/opencensus/implcore/trace/SpanImpl.java | 3 +++ 1 file changed, 3 insertions(+) (limited to 'impl_core/src') diff --git a/impl_core/src/main/java/io/opencensus/implcore/trace/SpanImpl.java b/impl_core/src/main/java/io/opencensus/implcore/trace/SpanImpl.java index 81b27e32..59291685 100644 --- a/impl_core/src/main/java/io/opencensus/implcore/trace/SpanImpl.java +++ b/impl_core/src/main/java/io/opencensus/implcore/trace/SpanImpl.java @@ -268,6 +268,8 @@ public final class SpanImpl extends Span implements Element { @Override public void putAttribute(String key, AttributeValue value) { + Preconditions.checkNotNull(key, "key"); + Preconditions.checkNotNull(value, "value"); if (!getOptions().contains(Options.RECORD_EVENTS)) { return; } @@ -381,6 +383,7 @@ public final class SpanImpl extends Span implements Element { @Override public void end(EndSpanOptions options) { + Preconditions.checkNotNull(options, "options"); if (!getOptions().contains(Options.RECORD_EVENTS)) { return; } -- cgit v1.2.3