diff options
| author | Maksim Ivanov <emaxx@chromium.org> | 2020-09-26 00:14:32 +0200 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-09-26 00:29:12 +0000 |
| commit | ce233ef0eb7fe3ffb1a0160308daab8380526552 (patch) | |
| tree | 559bbced9e2527b0ab8460ccdb2ac56d71fa15a0 | |
| parent | c9b17d38858d4b6d95feb5e6d9560cc63ec7b1b5 (diff) | |
| download | openscreen-ce233ef0eb7fe3ffb1a0160308daab8380526552.tar.gz | |
Fix useless move() in //discovery/
Drop std::move() calls in places where there's no actual moving
happing, and only the "bugprone-use-after-move" clang-tidy
warning is triggered.
Bug: chromium:1122844
Change-Id: I69abd6193670fe77dcc24d1b8510796756c7a575
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2431966
Reviewed-by: Ryan Keane <rwkeane@google.com>
Commit-Queue: Ryan Keane <rwkeane@google.com>
| -rw-r--r-- | discovery/dnssd/impl/dns_data_graph.cc | 3 | ||||
| -rw-r--r-- | discovery/dnssd/impl/querier_impl.cc | 3 | ||||
| -rw-r--r-- | discovery/mdns/mdns_querier.cc | 3 |
3 files changed, 3 insertions, 6 deletions
diff --git a/discovery/dnssd/impl/dns_data_graph.cc b/discovery/dnssd/impl/dns_data_graph.cc index 2b46fa7a..036c7985 100644 --- a/discovery/dnssd/impl/dns_data_graph.cc +++ b/discovery/dnssd/impl/dns_data_graph.cc @@ -384,8 +384,7 @@ void DnsDataGraphImpl::StartTracking(const DomainName& domain, ScopedCallbackHandler creation_handler = GetScopedCreationHandler(std::move(on_start_tracking)); - auto pair = - nodes_.emplace(domain, std::make_unique<Node>(std::move(domain), this)); + auto pair = nodes_.emplace(domain, std::make_unique<Node>(domain, this)); OSP_DCHECK(pair.second); OSP_DCHECK(nodes_.find(domain) != nodes_.end()); diff --git a/discovery/dnssd/impl/querier_impl.cc b/discovery/dnssd/impl/querier_impl.cc index 94f54fc9..b98feff3 100644 --- a/discovery/dnssd/impl/querier_impl.cc +++ b/discovery/dnssd/impl/querier_impl.cc @@ -227,8 +227,7 @@ void QuerierImpl::StartQuery(const std::string& service, Callback* callback) { // Start tracking the new callback const ServiceKey key(service, kLocalDomain); - auto it = - callback_map_.emplace(std::move(key), std::vector<Callback*>{}).first; + auto it = callback_map_.emplace(key, std::vector<Callback*>{}).first; it->second.push_back(callback); const DomainName domain = key.GetName(); diff --git a/discovery/mdns/mdns_querier.cc b/discovery/mdns/mdns_querier.cc index 2ae7260e..9ace0cd2 100644 --- a/discovery/mdns/mdns_querier.cc +++ b/discovery/mdns/mdns_querier.cc @@ -635,8 +635,7 @@ void MdnsQuerier::ProcessCallbacks(const MdnsRecord& record, void MdnsQuerier::AddQuestion(const MdnsQuestion& question) { auto tracker = std::make_unique<MdnsQuestionTracker>( - std::move(question), sender_, task_runner_, now_function_, random_delay_, - config_); + question, sender_, task_runner_, now_function_, random_delay_, config_); MdnsQuestionTracker* ptr = tracker.get(); questions_.emplace(question.name(), std::move(tracker)); |