aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJordan Bayles <jophba@chromium.org>2021-06-07 21:56:56 -0700
committerJordan Bayles <jophba@chromium.org>2021-06-08 17:48:32 +0000
commit94090603e69d7c63f3383038b0689bde6f968459 (patch)
tree370d974436119f78464ab725e39e13d050a6a5eb
parent946f489bea5525e12f279b394850b2ed8329446c (diff)
downloadopenscreen-94090603e69d7c63f3383038b0689bde6f968459.tar.gz
[Cast Streaming] Document Android RTP Hack
After offline discussion, it has been determined that legacy Android TV devices, such as Nexus Player, and some 3P Android TV implementations may still need the Android RTP hack introduced in https://crbug.com/631828. This patch adds references to this CR bug to make the history of this hack easier to access. Bug: b/184438154 Change-Id: I1bcabc09c912040fc0a29023b9bd9975415a13ea Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2945376 Reviewed-by: mark a. foltz <mfoltz@chromium.org>
-rw-r--r--cast/standalone_sender/main.cc2
-rw-r--r--cast/streaming/sender_session.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/cast/standalone_sender/main.cc b/cast/standalone_sender/main.cc
index f17a11a2..c6680cd5 100644
--- a/cast/standalone_sender/main.cc
+++ b/cast/standalone_sender/main.cc
@@ -68,7 +68,7 @@ usage: %s <options> addr[:port] media_file
R"(
-a, --android-hack:
Use the wrong RTP payload types, for compatibility with older Android
- TV receivers.
+ TV receivers. See https://crbug.com/631828.
-t, --tracing: Enable performance tracing logging.
diff --git a/cast/streaming/sender_session.h b/cast/streaming/sender_session.h
index 5865668a..dce7ce2a 100644
--- a/cast/streaming/sender_session.h
+++ b/cast/streaming/sender_session.h
@@ -121,7 +121,7 @@ class SenderSession final {
std::string message_destination_id;
// Whether or not the android RTP value hack should be used (for legacy
- // android devices).
+ // android devices). For more information, see https://crbug.com/631828.
bool use_android_rtp_hack = true;
};