diff options
| author | Jordan Bayles <jophba@chromium.org> | 2021-04-07 13:43:27 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-04-08 20:43:20 +0000 |
| commit | 46b7d128bc08fceae9d109c0f675bc98c73ddda9 (patch) | |
| tree | 9ec05f69751444bddae2ca7ffd9ef0397e691fbf /cast/protocol | |
| parent | 98caf900d4681e679b7a6f29df02ae04f7603d55 (diff) | |
| download | openscreen-46b7d128bc08fceae9d109c0f675bc98c73ddda9.tar.gz | |
[Cast] Cleanup Resolution + ReceiverSession
This patch changes the way Dimensions and Resolution objects are
used in Open Screen--consolidating them into just one set
of Dimensions and Resolution objects that can be used throughout
the library, and updates the mirroring control protocol specification to be
crisper about the difference between Resolution objects and Dimensions
objects--and removing frame rates where they don't really make sense.
As part of this cleanup, it also refactors the
ReceiverSession to not expose the Answer messaging system at all,
instead using new publicly exposed types. Finally, the capture
recommendations are removed from the Receiver side, in favor of shared
constants.
Bug: b/184186374
Change-Id: I5e6a1c6798d07cb7f388ff5179c0bfa325d89229
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2808336
Reviewed-by: Ryan Keane <rwkeane@google.com>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Diffstat (limited to 'cast/protocol')
| -rw-r--r-- | cast/protocol/castv2/streaming_examples/answer.json | 2 | ||||
| -rw-r--r-- | cast/protocol/castv2/streaming_schema.json | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/cast/protocol/castv2/streaming_examples/answer.json b/cast/protocol/castv2/streaming_examples/answer.json index 73c45ea2..1c95b394 100644 --- a/cast/protocol/castv2/streaming_examples/answer.json +++ b/cast/protocol/castv2/streaming_examples/answer.json @@ -16,7 +16,7 @@ }, "video": { "maxPixelsPerSecond": 62208000, - "minDimensions": {"width": 320, "height": 240, "frameRate": "23/3"}, + "minResolution": {"width": 320, "height": 240}, "maxDimensions": {"width": 1920, "height": 1080, "frameRate": "60"}, "minBitRate": 300000, "maxBitRate": 10000000, diff --git a/cast/protocol/castv2/streaming_schema.json b/cast/protocol/castv2/streaming_schema.json index 392d135c..a967264d 100644 --- a/cast/protocol/castv2/streaming_schema.json +++ b/cast/protocol/castv2/streaming_schema.json @@ -115,7 +115,7 @@ "video_constraints": { "properties": { "maxPixelsPerSecond": {"type": "number", "minimum": 0}, - "minDimensions": {"$ref": "#/definitions/dimensions"}, + "minResolution": {"$ref": "#/definitions/resolution"}, "maxDimensions": {"$ref": "#/definitions/dimensions"}, "minBitRate": {"type": "integer", "minimum": 300000}, "maxBitRate": {"type": "integer", "minimum": 300000}, |