diff options
| author | Abraham Corea Diaz <abrahamcd@google.com> | 2021-07-09 23:35:39 +0000 |
|---|---|---|
| committer | Openscreen LUCI CQ <openscreen-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2021-07-14 01:27:13 +0000 |
| commit | bffb5c2247c5705401499ff13b686b119d9918b6 (patch) | |
| tree | 37035bdd2216518204b6e52d7ba353368258febf /cast/sender | |
| parent | 7e167e2bc4c8c0c650f00b995e1e20cb1ae1f479 (diff) | |
| download | openscreen-bffb5c2247c5705401499ff13b686b119d9918b6.tar.gz | |
Define virtual destructors in Client interfaces.
This patch adds virtual destructors to all Client and Delegate
interfaces that did not have one.
Bug: b/156129407
Change-Id: I8b7365ab8a38b9e76a45ced08dd94d1aa595209b
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3011415
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Jordan Bayles <jophba@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Diffstat (limited to 'cast/sender')
| -rw-r--r-- | cast/sender/channel/sender_socket_factory.cc | 2 | ||||
| -rw-r--r-- | cast/sender/public/sender_socket_factory.h | 4 |
2 files changed, 6 insertions, 0 deletions
diff --git a/cast/sender/channel/sender_socket_factory.cc b/cast/sender/channel/sender_socket_factory.cc index abbabfd6..c0924836 100644 --- a/cast/sender/channel/sender_socket_factory.cc +++ b/cast/sender/channel/sender_socket_factory.cc @@ -16,6 +16,8 @@ using ::cast::channel::CastMessage; namespace openscreen { namespace cast { +SenderSocketFactory::Client::~Client() = default; + bool operator<(const std::unique_ptr<SenderSocketFactory::PendingAuth>& a, int b) { return a && a->socket->socket_id() < b; diff --git a/cast/sender/public/sender_socket_factory.h b/cast/sender/public/sender_socket_factory.h index f0247a28..0b9b05aa 100644 --- a/cast/sender/public/sender_socket_factory.h +++ b/cast/sender/public/sender_socket_factory.h @@ -7,6 +7,7 @@ #include <openssl/x509.h> +#include <memory> #include <set> #include <utility> #include <vector> @@ -33,6 +34,9 @@ class SenderSocketFactory final : public TlsConnectionFactory::Client, virtual void OnError(SenderSocketFactory* factory, const IPEndpoint& endpoint, Error error) = 0; + + protected: + virtual ~Client(); }; enum class DeviceMediaPolicy { |