diff options
| author | Jordan Bayles <jophba@chromium.org> | 2020-11-24 12:09:04 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-11-25 01:12:19 +0000 |
| commit | 759af7f402131028b48a107ca33d4b1ee2fdaeb6 (patch) | |
| tree | c99560660d00c132af6779fe9d2035d06e444109 /cast/sender | |
| parent | 185795f02ceb4300e1caef49b5b7052c8d453dc9 (diff) | |
| download | openscreen-759af7f402131028b48a107ca33d4b1ee2fdaeb6.tar.gz | |
Logging cleanups
This patch removes some test-specific logging code in favor of death tests, and
makes the OSP_NOTREACHED macro actually be annotated as [[noreturn]], so you
don't have to put a bogus return statement after it.
Change-Id: I6a6a271182061cbd98593ac0ae79347e48da5bc7
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2555597
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Diffstat (limited to 'cast/sender')
| -rw-r--r-- | cast/sender/cast_app_discovery_service_impl.cc | 1 | ||||
| -rw-r--r-- | cast/sender/channel/sender_socket_factory.cc | 3 |
2 files changed, 2 insertions, 2 deletions
diff --git a/cast/sender/cast_app_discovery_service_impl.cc b/cast/sender/cast_app_discovery_service_impl.cc index fd071ca2..4ca9a016 100644 --- a/cast/sender/cast_app_discovery_service_impl.cc +++ b/cast/sender/cast_app_discovery_service_impl.cc @@ -174,7 +174,6 @@ bool CastAppDiscoveryServiceImpl::ShouldRefreshAppAvailability( } OSP_NOTREACHED(); - return false; } void CastAppDiscoveryServiceImpl::RemoveAvailabilityCallback(uint32_t id) { diff --git a/cast/sender/channel/sender_socket_factory.cc b/cast/sender/channel/sender_socket_factory.cc index a1f24ef0..e971976b 100644 --- a/cast/sender/channel/sender_socket_factory.cc +++ b/cast/sender/channel/sender_socket_factory.cc @@ -59,7 +59,8 @@ void SenderSocketFactory::OnAccepted( TlsConnectionFactory* factory, std::vector<uint8_t> der_x509_peer_cert, std::unique_ptr<TlsConnection> connection) { - OSP_NOTREACHED() << "This factory is connect-only."; + OSP_NOTREACHED(); + OSP_LOG_FATAL << "This factory is connect-only"; } void SenderSocketFactory::OnConnected( |