[c++17] Make consistent use of noexcept

This change makes openscreen ready to be compiled with -std=c++17. In
particular, c++17 demands the consistent use of the noexcept keyword
accross declaration and definition.

Bug: chromium:752720
Change-Id: I4715cbc7ccc9576e33ad7dec0ce6c1f6ebd9935b
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2643286
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>

5 files changed, 6 insertions, 5 deletions

diff --git a/cast/receiver/channel/static_credentials.cc b/cast/receiver/channel/static_credentials.cc
index 09351420..ce031ac7 100644
--- a/cast/receiver/channel/static_credentials.cc
+++ b/cast/receiver/channel/static_credentials.cc
@@ -143,7 +143,7 @@ StaticCredentialsProvider::StaticCredentialsProvider(
       tls_cert_der(std::move(tls_cert_der)) {}
 
 StaticCredentialsProvider::StaticCredentialsProvider(
-    StaticCredentialsProvider&&) = default;
+    StaticCredentialsProvider&&) noexcept = default;
 StaticCredentialsProvider& StaticCredentialsProvider::operator=(
     StaticCredentialsProvider&&) = default;
 StaticCredentialsProvider::~StaticCredentialsProvider() = default;
diff --git a/cast/sender/public/cast_app_discovery_service.cc b/cast/sender/public/cast_app_discovery_service.cc
index 8299aff4..f2e39239 100644
--- a/cast/sender/public/cast_app_discovery_service.cc
+++ b/cast/sender/public/cast_app_discovery_service.cc
@@ -12,7 +12,8 @@ CastAppDiscoveryService::Subscription::Subscription(
     uint32_t id)
     : discovery_service_(discovery_service), id_(id) {}
 
-CastAppDiscoveryService::Subscription::Subscription(Subscription&& other)
+CastAppDiscoveryService::Subscription::Subscription(
+    Subscription&& other) noexcept
     : discovery_service_(other.discovery_service_), id_(other.id_) {
   other.discovery_service_ = nullptr;
 }
diff --git a/cast/streaming/encoded_frame.cc b/cast/streaming/encoded_frame.cc
index 8b89adf3..1aaf1127 100644
--- a/cast/streaming/encoded_frame.cc
+++ b/cast/streaming/encoded_frame.cc
@@ -10,7 +10,7 @@ namespace cast {
 EncodedFrame::EncodedFrame() = default;
 EncodedFrame::~EncodedFrame() = default;
 
-EncodedFrame::EncodedFrame(EncodedFrame&&) = default;
+EncodedFrame::EncodedFrame(EncodedFrame&&) noexcept = default;
 EncodedFrame& EncodedFrame::operator=(EncodedFrame&&) = default;
 
 void EncodedFrame::CopyMetadataTo(EncodedFrame* dest) const {
diff --git a/cast/streaming/frame_crypto.cc b/cast/streaming/frame_crypto.cc
index e08eb4e5..567e41ca 100644
--- a/cast/streaming/frame_crypto.cc
+++ b/cast/streaming/frame_crypto.cc
@@ -23,7 +23,7 @@ EncryptedFrame::EncryptedFrame() {
 
 EncryptedFrame::~EncryptedFrame() = default;
 
-EncryptedFrame::EncryptedFrame(EncryptedFrame&& other)
+EncryptedFrame::EncryptedFrame(EncryptedFrame&& other) noexcept
     : EncodedFrame(static_cast<EncodedFrame&&>(other)),
       owned_data_(std::move(other.owned_data_)) {
   data = absl::Span<uint8_t>(owned_data_);
diff --git a/cast/streaming/receiver_session.h b/cast/streaming/receiver_session.h
index 3ef09309..b448bd00 100644
--- a/cast/streaming/receiver_session.h
+++ b/cast/streaming/receiver_session.h
@@ -90,7 +90,7 @@ class ReceiverSession final {
 
     Preferences(Preferences&&) noexcept;
     Preferences(const Preferences&) = delete;
-    Preferences& operator=(Preferences&&);
+    Preferences& operator=(Preferences&&) noexcept;
     Preferences& operator=(const Preferences&) = delete;
 
     std::vector<VideoCodec> video_codecs{VideoCodec::kVp8, VideoCodec::kH264};