diff options
| author | btolsch <btolsch@chromium.org> | 2019-04-18 16:21:23 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-04-18 23:28:19 +0000 |
| commit | 333aecd2a7ec171558f476d0cf9b118f86dd580f (patch) | |
| tree | a450749d22c60b22874c0aded97a73e4674a201c /infra | |
| parent | 2acc208dc32c7d97469a47ec1fba1236e7e96284 (diff) | |
| download | openscreen-333aecd2a7ec171558f476d0cf9b118f86dd580f.tar.gz | |
Reland "Improve presubmit support"
This version renames the presubmit bot to openscreen_presubmit based on
the standard bot naming the configuration prefers.
This is a reland of f0be9de6149a73efbd98506541a6758c970f1b0f
Original change's description:
> Improve presubmit support
>
> This change improves our presubmit in two ways:
> 1. It adds our PRESUBMIT.sh as a step in PRESUBMIT.py which is normally
> run by git-cl commands.
> 2. Adds a presubmit bot which runs our PRESUBMIT.py as part of the
> commit queue.
>
> Moving the PRESUBMIT.sh checks into python or adding other checks will
> be left to future CLs.
>
> Bug: openscreen:43
> Change-Id: I7d95fe92b9b6c715344bc65868cd1eb91e7be643
> Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1570449
> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
TBR=mfoltz@chromium.org
Bug: openscreen:43
Change-Id: I854d7fae53dcc888b4918acb24ad3db3826f509a
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1575005
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Diffstat (limited to 'infra')
| -rw-r--r-- | infra/config/global/commit-queue.cfg | 3 | ||||
| -rw-r--r-- | infra/config/global/cr-buildbucket.cfg | 10 |
2 files changed, 13 insertions, 0 deletions
diff --git a/infra/config/global/commit-queue.cfg b/infra/config/global/commit-queue.cfg index 031a96a8..7e58538a 100644 --- a/infra/config/global/commit-queue.cfg +++ b/infra/config/global/commit-queue.cfg @@ -31,6 +31,9 @@ config_groups { builders { name: "openscreen/try/mac_debug" } + builders { + name: "openscreen/try/openscreen_presubmit" + } retry_config { single_quota: 1 global_quota: 2 diff --git a/infra/config/global/cr-buildbucket.cfg b/infra/config/global/cr-buildbucket.cfg index bc3074b8..4d417e03 100644 --- a/infra/config/global/cr-buildbucket.cfg +++ b/infra/config/global/cr-buildbucket.cfg @@ -156,6 +156,16 @@ buckets: { mixins: "debug" mixins: "x64" } + + builders { + name: "openscreen_presubmit" + recipe { + name: "run_presubmit" + properties: "repo_name:openscreen" + } + mixins: "linux" + mixins: "x64" + } } } |