diff options
| author | Yuri Wiitala <miu@chromium.org> | 2020-01-08 18:15:38 -0800 |
|---|---|---|
| committer | Yuri Wiitala <miu@chromium.org> | 2020-01-09 02:16:59 +0000 |
| commit | a8321f82403b826281174ffd44275f1783c620a5 (patch) | |
| tree | 491303e738d6d6c41158abe72ee8089e6c777660 /infra | |
| parent | 7e26aedaa56a1592c792472bc9076dc0daaeab65 (diff) | |
| download | openscreen-a8321f82403b826281174ffd44275f1783c620a5.tar.gz | |
infra config: Add back the comment about how the OSX_SDK recipe works.
Relands only the comments that were added to our cr-buildbucket.cfg in
the reverted commit 1a5032f91662568ed3f. These comments are very useful
for helping us find where our build recipes are in the chromium //build
repo, and how everything comes together in the actual build on the bots.
There is no configuration or other functional change being made here.
TBR=jophba@chromium.org
Bug: openscreen:86
Change-Id: I8edbc8107d094525ad6881ba68a9ebbb0f337ab7
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1992823
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Diffstat (limited to 'infra')
| -rw-r--r-- | infra/config/global/cr-buildbucket.cfg | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/infra/config/global/cr-buildbucket.cfg b/infra/config/global/cr-buildbucket.cfg index 5a96f4be..f9e88cf6 100644 --- a/infra/config/global/cr-buildbucket.cfg +++ b/infra/config/global/cr-buildbucket.cfg @@ -74,7 +74,22 @@ builder_mixins { builder_mixins { name: "mac" + + # NOTE: The OS version here will determine which version of XCode is being + # used. Relevant links; so you and I never have to spend hours finding this + # stuff all over again to fix things like https://crbug.com/openscreen/86: + # + # 1. The recipe code that uses the "osx_sdk" recipe module: + # + # https://cs.chromium.org/chromium/build/scripts/slave/recipes + # /openscreen.py?rcl=671f9f1c5f5bef81d0a39973aa8729cc83bb290e&l=74 + # + # 2. The XCode version look-up table in the "osx_sdk" recipe module: + # + # https://cs.chromium.org/chromium/tools/depot_tools/recipes/recipe_modules + # /osx_sdk/api.py?rcl=fe18a43d590a5eac0d58e7e555b024746ba290ad&l=26 dimensions: "os:Mac-10.13" + caches: { # Cache for mac_toolchain tool and XCode.app used in recipes. name: "osx_sdk" |