aboutsummaryrefslogtreecommitdiff
path: root/osp
diff options
context:
space:
mode:
authorTakumi Fujimoto <takumif@chromium.org>2019-10-21 10:56:21 -0700
committerCommit Bot <commit-bot@chromium.org>2019-10-21 18:10:31 +0000
commitebcffaea45a6e756b30d95b2dc43a47779cbe7be (patch)
tree19735b949c6f7ad09565906196f0fdbc3ee7001b /osp
parentd0f315b3fac883c1e34c1ea2d768118efeffb3bc (diff)
downloadopenscreen-ebcffaea45a6e756b30d95b2dc43a47779cbe7be.tar.gz
Format TODO URLs as TODO(crbug.com/openscreen/000)
Put crbug URLs in TODOs to make it easier to open the bug pages. Change-Id: Ibc8fce98a795d7e8c714627bf1ecd970a3865563 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1872176 Reviewed-by: Max Yakimakha <yakimakha@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Diffstat (limited to 'osp')
-rw-r--r--osp/impl/discovery/mdns/mdns_demo.cc2
-rw-r--r--osp/impl/discovery/mdns/mdns_responder_adapter_impl.cc4
-rw-r--r--osp/impl/internal_services.cc2
-rw-r--r--osp/impl/mdns_responder_service.cc3
-rw-r--r--osp/impl/presentation/presentation_connection.cc2
-rw-r--r--osp/impl/presentation/presentation_controller.cc6
-rw-r--r--osp/impl/presentation/presentation_receiver.cc6
-rw-r--r--osp/impl/quic/quic_client.cc6
-rw-r--r--osp/impl/quic/quic_connection_factory_impl.cc2
-rw-r--r--osp/impl/quic/quic_connection_impl.cc4
-rw-r--r--osp/impl/quic/quic_server.cc6
-rw-r--r--osp/public/endpoint_request_ids.cc4
-rw-r--r--osp/public/presentation/presentation_receiver.h4
13 files changed, 26 insertions, 25 deletions
diff --git a/osp/impl/discovery/mdns/mdns_demo.cc b/osp/impl/discovery/mdns/mdns_demo.cc
index f8a5466f..92b0fef9 100644
--- a/osp/impl/discovery/mdns/mdns_demo.cc
+++ b/osp/impl/discovery/mdns/mdns_demo.cc
@@ -59,7 +59,7 @@ class DemoSocketClient : public platform::UdpSocket::Client {
DemoSocketClient(mdns::MdnsResponderAdapterImpl* mdns) : mdns_(mdns) {}
void OnError(platform::UdpSocket* socket, Error error) override {
- // TODO(issue/66): Change to OSP_LOG_FATAL.
+ // TODO(crbug.com/openscreen/66): Change to OSP_LOG_FATAL.
OSP_LOG_ERROR << "configuration failed for interface " << error.message();
OSP_CHECK(false);
}
diff --git a/osp/impl/discovery/mdns/mdns_responder_adapter_impl.cc b/osp/impl/discovery/mdns/mdns_responder_adapter_impl.cc
index 8b868a58..04485e68 100644
--- a/osp/impl/discovery/mdns/mdns_responder_adapter_impl.cc
+++ b/osp/impl/discovery/mdns/mdns_responder_adapter_impl.cc
@@ -339,13 +339,13 @@ void MdnsResponderAdapterImpl::OnRead(
void MdnsResponderAdapterImpl::OnSendError(platform::UdpSocket* socket,
Error error) {
- // TODO(issue/67): Implement this method.
+ // TODO(crbug.com/openscreen/67): Implement this method.
OSP_UNIMPLEMENTED();
}
void MdnsResponderAdapterImpl::OnError(platform::UdpSocket* socket,
Error error) {
- // TODO(issue/67): Implement this method.
+ // TODO(crbug.com/openscreen/67): Implement this method.
OSP_UNIMPLEMENTED();
}
diff --git a/osp/impl/internal_services.cc b/osp/impl/internal_services.cc
index c5a4afe5..8b456d2c 100644
--- a/osp/impl/internal_services.cc
+++ b/osp/impl/internal_services.cc
@@ -216,7 +216,7 @@ void InternalServices::OnError(platform::UdpSocket* socket, Error error) {
}
void InternalServices::OnSendError(platform::UdpSocket* socket, Error error) {
- // TODO(issue/67): Implement this method.
+ // TODO(crbug.com/openscreen/67): Implement this method.
OSP_UNIMPLEMENTED();
}
diff --git a/osp/impl/mdns_responder_service.cc b/osp/impl/mdns_responder_service.cc
index bf290bd5..aac68c4b 100644
--- a/osp/impl/mdns_responder_service.cc
+++ b/osp/impl/mdns_responder_service.cc
@@ -347,7 +347,8 @@ void MdnsResponderService::StopListening() {
}
void MdnsResponderService::StartService() {
- // TODO(issue/45): This should really be a library-wide whitelist.
+ // TODO(crbug.com/openscreen/45): This should really be a library-wide
+ // whitelist.
if (!bound_interfaces_.empty() && !interface_index_whitelist_.empty()) {
// TODO(btolsch): New interfaces won't be picked up on this path, but this
// also highlights a larger issue of the interface list being frozen while
diff --git a/osp/impl/presentation/presentation_connection.cc b/osp/impl/presentation/presentation_connection.cc
index cee8a60e..adcfde17 100644
--- a/osp/impl/presentation/presentation_connection.cc
+++ b/osp/impl/presentation/presentation_connection.cc
@@ -18,7 +18,7 @@
#include "platform/api/logging.h"
#include "util/std_util.h"
-// TODO(issue/27): Address TODOs in this file
+// TODO(crbug.com/openscreen/27): Address TODOs in this file
namespace openscreen {
namespace presentation {
diff --git a/osp/impl/presentation/presentation_controller.cc b/osp/impl/presentation/presentation_controller.cc
index fa62a3df..b91e1e2f 100644
--- a/osp/impl/presentation/presentation_controller.cc
+++ b/osp/impl/presentation/presentation_controller.cc
@@ -428,9 +428,9 @@ Controller::Controller(platform::ClockNowFunctionPtr now_function) {
const std::vector<ServiceInfo>& receivers =
NetworkServiceManager::Get()->GetMdnsServiceListener()->GetReceivers();
for (const auto& info : receivers) {
- // TODO(issue/33): Replace service_id with endpoint_id when endpoint_id is
- // more than just an IPEndpoint counter and actually relates to a device's
- // identity.
+ // TODO(crbug.com/openscreen/33): Replace service_id with endpoint_id when
+ // endpoint_id is more than just an IPEndpoint counter and actually relates
+ // to a device's identity.
receiver_endpoints_.emplace(info.service_id, info.v4_endpoint.port
? info.v4_endpoint
: info.v6_endpoint);
diff --git a/osp/impl/presentation/presentation_receiver.cc b/osp/impl/presentation/presentation_receiver.cc
index 5c3cd0d1..5590561e 100644
--- a/osp/impl/presentation/presentation_receiver.cc
+++ b/osp/impl/presentation/presentation_receiver.cc
@@ -321,9 +321,9 @@ ErrorOr<size_t> Receiver::OnStreamMessage(uint64_t endpoint_id,
}
}
-// TODO(issue/31): Remove singletons in the embedder API and protocol
-// implementation layers and in presentation_connection, as well as unit tests.
-// static
+// TODO(crbug.com/openscreen/31): Remove singletons in the embedder API and
+// protocol implementation layers and in presentation_connection, as well as
+// unit tests. static
Receiver* Receiver::Get() {
static Receiver& receiver = *new Receiver();
return &receiver;
diff --git a/osp/impl/quic/quic_client.cc b/osp/impl/quic/quic_client.cc
index 7c4fcc47..7b3b0bff 100644
--- a/osp/impl/quic/quic_client.cc
+++ b/osp/impl/quic/quic_client.cc
@@ -151,9 +151,9 @@ void QuicClient::OnConnectionClosed(uint64_t endpoint_id,
delete_connections_.emplace_back(connection_entry);
- // TODO(issue/42): If we reset request IDs when a connection is closed, we
- // might end up re-using request IDs when a new connection is created to the
- // same endpoint.
+ // TODO(crbug.com/openscreen/42): If we reset request IDs when a connection is
+ // closed, we might end up re-using request IDs when a new connection is
+ // created to the same endpoint.
endpoint_request_ids_.ResetRequestId(endpoint_id);
}
diff --git a/osp/impl/quic/quic_connection_factory_impl.cc b/osp/impl/quic/quic_connection_factory_impl.cc
index dfa37f00..0b5fbd95 100644
--- a/osp/impl/quic/quic_connection_factory_impl.cc
+++ b/osp/impl/quic/quic_connection_factory_impl.cc
@@ -215,7 +215,7 @@ void QuicConnectionFactoryImpl::OnError(platform::UdpSocket* socket,
void QuicConnectionFactoryImpl::OnSendError(platform::UdpSocket* socket,
Error error) {
- // TODO(issue/67): Implement this method.
+ // TODO(crbug.com/openscreen/67): Implement this method.
OSP_UNIMPLEMENTED();
}
diff --git a/osp/impl/quic/quic_connection_impl.cc b/osp/impl/quic/quic_connection_impl.cc
index 26135589..3821ecae 100644
--- a/osp/impl/quic/quic_connection_impl.cc
+++ b/osp/impl/quic/quic_connection_impl.cc
@@ -89,12 +89,12 @@ void QuicConnectionImpl::OnRead(platform::UdpSocket* socket,
}
void QuicConnectionImpl::OnSendError(platform::UdpSocket* socket, Error error) {
- // TODO(issue/67): Implement this method.
+ // TODO(crbug.com/openscreen/67): Implement this method.
OSP_UNIMPLEMENTED();
}
void QuicConnectionImpl::OnError(platform::UdpSocket* socket, Error error) {
- // TODO(issue/67): Implement this method.
+ // TODO(crbug.com/openscreen/67): Implement this method.
OSP_UNIMPLEMENTED();
}
diff --git a/osp/impl/quic/quic_server.cc b/osp/impl/quic/quic_server.cc
index 7aa00a9d..c1ec14e7 100644
--- a/osp/impl/quic/quic_server.cc
+++ b/osp/impl/quic/quic_server.cc
@@ -141,9 +141,9 @@ void QuicServer::OnConnectionClosed(uint64_t endpoint_id,
delete_connections_.emplace_back(connection_entry);
- // TODO(issue/42): If we reset request IDs when a connection is closed, we
- // might end up re-using request IDs when a new connection is created to the
- // same endpoint.
+ // TODO(crbug.com/openscreen/42): If we reset request IDs when a connection is
+ // closed, we might end up re-using request IDs when a new connection is
+ // created to the same endpoint.
endpoint_request_ids_.ResetRequestId(endpoint_id);
}
diff --git a/osp/public/endpoint_request_ids.cc b/osp/public/endpoint_request_ids.cc
index 15e9be1e..69fd275f 100644
--- a/osp/public/endpoint_request_ids.cc
+++ b/osp/public/endpoint_request_ids.cc
@@ -17,8 +17,8 @@ uint64_t EndpointRequestIds::GetNextRequestId(uint64_t endpoint_id) {
}
void EndpointRequestIds::ResetRequestId(uint64_t endpoint_id) {
- // TODO(issue/42): Consider using a timeout to drop the request id counter,
- // and/or possibly set the initial value as part of the handshake.
+ // TODO(crbug.com/openscreen/42): Consider using a timeout to drop the request
+ // id counter, and/or possibly set the initial value as part of the handshake.
request_ids_by_endpoint_id_.erase(endpoint_id);
}
diff --git a/osp/public/presentation/presentation_receiver.h b/osp/public/presentation/presentation_receiver.h
index d12bbd89..5f5d5e15 100644
--- a/osp/public/presentation/presentation_receiver.h
+++ b/osp/public/presentation/presentation_receiver.h
@@ -61,8 +61,8 @@ class ReceiverDelegate {
class Receiver final : public MessageDemuxer::MessageCallback,
public Connection::ParentDelegate {
public:
- // TODO(issue/31): Remove singletons in the embedder API and protocol
- // implementation layers
+ // TODO(crbug.com/openscreen/31): Remove singletons in the embedder API and
+ // protocol implementation layers.
static Receiver* Get();
void Init();
void Deinit();