diff options
| author | Jordan Bayles <jophba@chromium.org> | 2020-09-21 11:39:32 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-09-22 21:34:30 +0000 |
| commit | 0cd3cde8398ce63ea3b6334990e0382185aa197f (patch) | |
| tree | e2c2ecab3c4ddc2cf493b45af468dffcfcfa9b11 /third_party | |
| parent | ee059e975840e66ae4baa28ffde5e31f9e26b68a (diff) | |
| download | openscreen-0cd3cde8398ce63ea3b6334990e0382185aa197f.tar.gz | |
Add note about Abseil StrFormat
Currently, we don't have StrFormat in the code base due to binary size
concerns (it adds ~350kB to the openscreen_unittests binary, and
presumably will add similar amounts when our library is linked in
projects that don't use Abseil). This patch removes the str_format.h
header from our Abseil source set, as well as adds a comment to ensure
that this exclusion is continued in the future.
Change-Id: I1a7055d64f1e3ec995adc970cf6d74ea6850b1d4
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2422366
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Diffstat (limited to 'third_party')
| -rw-r--r-- | third_party/abseil/BUILD.gn | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/third_party/abseil/BUILD.gn b/third_party/abseil/BUILD.gn index a4ca3d53..8f4c56a2 100644 --- a/third_party/abseil/BUILD.gn +++ b/third_party/abseil/BUILD.gn @@ -6,9 +6,7 @@ import("//build_overrides/build.gni") if (build_with_chromium) { source_set("abseil") { - public_deps = [ - "//third_party/abseil-cpp:absl", - ] + public_deps = [ "//third_party/abseil-cpp:absl" ] } } else { config("abseil_config") { @@ -22,6 +20,8 @@ if (build_with_chromium) { ] } + # NOTE: StrFormat is specifically excluded from the Abseil source set due + # to binary size concerns. source_set("abseil") { sources = [ "src/absl/base/attributes.h", @@ -74,7 +74,6 @@ if (build_with_chromium) { "src/absl/strings/numbers.h", "src/absl/strings/str_cat.cc", "src/absl/strings/str_cat.h", - "src/absl/strings/str_format.h", "src/absl/strings/str_join.h", "src/absl/strings/str_replace.cc", "src/absl/strings/str_replace.h", |