diff options
| author | Jordan Bayles <jophba@chromium.org> | 2020-05-12 12:20:31 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-05-13 17:17:19 +0000 |
| commit | 16d3fc7f371e93e6d8879885046a6fb89f35f949 (patch) | |
| tree | 07d929b97fe03a3856ad320cfd6dc3f6c52743d4 /third_party | |
| parent | 4410e8e8f34e0fd8029cea7543fd1f8a191e03d1 (diff) | |
| download | openscreen-16d3fc7f371e93e6d8879885046a6fb89f35f949.tar.gz | |
Fix visibility linker warning
Currently, since we are manually overriding visibility settings for
abseil, after the recent introduction of the 128 bit headers we are now
seeing a linker warning on Mac:
ld: warning: direct access in function 'unsigned long std::__1::__str_rfind<char, unsigned long, std::__1::char_traits<char>, 18446744073709551615ul>(char const*, unsigned long, char const*, unsigned long, unsigned long)' from file 'obj/platform/base/base.ip_address.o' to global weak symbol 'std::__1::char_traits<char>::eq(char, char)' from file 'obj/third_party/abseil/src/absl/numeric/abseil.int128.o' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings.
This patch fixes that linker warning by not explicitly setting
visibility.
Change-Id: I28395f5ad6952d86a4710937de3d2eaa2577659f
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2196903
Reviewed-by: Ryan Keane <rwkeane@google.com>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Diffstat (limited to 'third_party')
| -rw-r--r-- | third_party/abseil/BUILD.gn | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/third_party/abseil/BUILD.gn b/third_party/abseil/BUILD.gn index c96d7e72..5f006f96 100644 --- a/third_party/abseil/BUILD.gn +++ b/third_party/abseil/BUILD.gn @@ -93,9 +93,6 @@ if (build_with_chromium) { "src/absl/types/variant.h", ] - configs -= [ "//build/config:symbol_visibility_hidden" ] - configs += [ "//build/config:symbol_visibility_default" ] - configs += [ ":private_abseil_config" ] public_configs = [ ":abseil_config" ] } |