diff options
| author | Jordan Bayles <jophba@chromium.org> | 2019-05-08 17:03:24 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-05-17 18:03:01 +0000 |
| commit | 9ade415f62a7f5d2b4233a103488c5a5cf08fc45 (patch) | |
| tree | 4fd853c25a79f2292f609de2621718d6d4fd38f5 /tools | |
| parent | 3fede56ad75622bea99c15ec1da062da3f38380e (diff) | |
| download | openscreen-9ade415f62a7f5d2b4233a103488c5a5cf08fc45.tar.gz | |
Clean up logging dependencies
Currently, our CDDL executable requires logging definitions that must be
provided by the embedder. Since CDDL is an executable target, it is
linked separately, before the embedder's logging implementation can be
build and linked. On top of this, we probably don't even want it using
the embedder's logging system... This patch changes the CDDL executable's
behavior to instead depend on the default logger, even when built inside
of an embedder.
Change-Id: I6a55e6d3779f2fdff0677972c48744d7f20f8918
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1601669
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/cddl/BUILD.gn | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/cddl/BUILD.gn b/tools/cddl/BUILD.gn index 96cfc900..dab91dc4 100644 --- a/tools/cddl/BUILD.gn +++ b/tools/cddl/BUILD.gn @@ -16,7 +16,10 @@ executable("cddl") { ] deps = [ + # CDDL always uses the default logger, even when embedded. + "../../platform:default_logger", "../../platform", "../../third_party/abseil", ] + configs += [ "../../build:allow_build_from_embedder" ] } |