aboutsummaryrefslogtreecommitdiff
path: root/util
diff options
context:
space:
mode:
authormark a. foltz <mfoltz@chromium.org>2020-07-28 17:28:06 -0700
committerCommit Bot <commit-bot@chromium.org>2020-07-29 01:06:33 +0000
commitd6a5a2271e6ed06e41aa24f550dd7be5e98dc183 (patch)
treee7b6f129ce0073aab44b7831ba6b78320d55b364 /util
parent8c11e26c0dfd54e7308b1825fe9ffbf4bc5882a8 (diff)
downloadopenscreen-d6a5a2271e6ed06e41aa24f550dd7be5e98dc183.tar.gz
[Open Screen] Adds a unit test for logging macros.
- Adds unit tests for the macros defined in util/osp_logging.h - Adds testing hooks to logging_posix.h Tests both behavior in _DEBUG and !_DEBUG builds. Change-Id: I5fa3382d5455fbdf5e5b75d0d519cd43c5960d12 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2289036 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Diffstat (limited to 'util')
-rw-r--r--util/osp_logging.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/util/osp_logging.h b/util/osp_logging.h
index 441bb3b2..65dd3e41 100644
--- a/util/osp_logging.h
+++ b/util/osp_logging.h
@@ -73,7 +73,6 @@ class Voidify {
#define OSP_VLOG_IF(condition) !(condition) ? (void)0 : OSP_VLOG
#define OSP_LOG_IF(level, condition) !(condition) ? (void)0 : OSP_LOG_##level
-// TODO(btolsch): Add tests for (D)OSP_CHECK and possibly logging.
#define OSP_CHECK(condition) \
OSP_LOG_IF(FATAL, !(condition)) << "OSP_CHECK(" << #condition << ") failed: "