diff options
-rw-r--r-- | cast/receiver/channel/static_credentials.cc | 2 | ||||
-rw-r--r-- | cast/sender/public/cast_app_discovery_service.cc | 3 | ||||
-rw-r--r-- | cast/streaming/encoded_frame.cc | 2 | ||||
-rw-r--r-- | cast/streaming/frame_crypto.cc | 2 | ||||
-rw-r--r-- | cast/streaming/receiver_session.h | 2 | ||||
-rw-r--r-- | discovery/mdns/mdns_records.cc | 20 | ||||
-rw-r--r-- | osp/impl/presentation/presentation_controller.cc | 5 | ||||
-rw-r--r-- | osp/impl/quic/quic_service_common.cc | 8 | ||||
-rw-r--r-- | osp/public/message_demuxer.cc | 5 | ||||
-rw-r--r-- | platform/api/task_runner.h | 2 | ||||
-rw-r--r-- | platform/base/udp_packet.cc | 2 | ||||
-rw-r--r-- | util/url.cc | 4 |
12 files changed, 32 insertions, 25 deletions
diff --git a/cast/receiver/channel/static_credentials.cc b/cast/receiver/channel/static_credentials.cc index 09351420..ce031ac7 100644 --- a/cast/receiver/channel/static_credentials.cc +++ b/cast/receiver/channel/static_credentials.cc @@ -143,7 +143,7 @@ StaticCredentialsProvider::StaticCredentialsProvider( tls_cert_der(std::move(tls_cert_der)) {} StaticCredentialsProvider::StaticCredentialsProvider( - StaticCredentialsProvider&&) = default; + StaticCredentialsProvider&&) noexcept = default; StaticCredentialsProvider& StaticCredentialsProvider::operator=( StaticCredentialsProvider&&) = default; StaticCredentialsProvider::~StaticCredentialsProvider() = default; diff --git a/cast/sender/public/cast_app_discovery_service.cc b/cast/sender/public/cast_app_discovery_service.cc index 8299aff4..f2e39239 100644 --- a/cast/sender/public/cast_app_discovery_service.cc +++ b/cast/sender/public/cast_app_discovery_service.cc @@ -12,7 +12,8 @@ CastAppDiscoveryService::Subscription::Subscription( uint32_t id) : discovery_service_(discovery_service), id_(id) {} -CastAppDiscoveryService::Subscription::Subscription(Subscription&& other) +CastAppDiscoveryService::Subscription::Subscription( + Subscription&& other) noexcept : discovery_service_(other.discovery_service_), id_(other.id_) { other.discovery_service_ = nullptr; } diff --git a/cast/streaming/encoded_frame.cc b/cast/streaming/encoded_frame.cc index 8b89adf3..1aaf1127 100644 --- a/cast/streaming/encoded_frame.cc +++ b/cast/streaming/encoded_frame.cc @@ -10,7 +10,7 @@ namespace cast { EncodedFrame::EncodedFrame() = default; EncodedFrame::~EncodedFrame() = default; -EncodedFrame::EncodedFrame(EncodedFrame&&) = default; +EncodedFrame::EncodedFrame(EncodedFrame&&) noexcept = default; EncodedFrame& EncodedFrame::operator=(EncodedFrame&&) = default; void EncodedFrame::CopyMetadataTo(EncodedFrame* dest) const { diff --git a/cast/streaming/frame_crypto.cc b/cast/streaming/frame_crypto.cc index e08eb4e5..567e41ca 100644 --- a/cast/streaming/frame_crypto.cc +++ b/cast/streaming/frame_crypto.cc @@ -23,7 +23,7 @@ EncryptedFrame::EncryptedFrame() { EncryptedFrame::~EncryptedFrame() = default; -EncryptedFrame::EncryptedFrame(EncryptedFrame&& other) +EncryptedFrame::EncryptedFrame(EncryptedFrame&& other) noexcept : EncodedFrame(static_cast<EncodedFrame&&>(other)), owned_data_(std::move(other.owned_data_)) { data = absl::Span<uint8_t>(owned_data_); diff --git a/cast/streaming/receiver_session.h b/cast/streaming/receiver_session.h index 3ef09309..b448bd00 100644 --- a/cast/streaming/receiver_session.h +++ b/cast/streaming/receiver_session.h @@ -90,7 +90,7 @@ class ReceiverSession final { Preferences(Preferences&&) noexcept; Preferences(const Preferences&) = delete; - Preferences& operator=(Preferences&&); + Preferences& operator=(Preferences&&) noexcept; Preferences& operator=(const Preferences&) = delete; std::vector<VideoCodec> video_codecs{VideoCodec::kVp8, VideoCodec::kH264}; diff --git a/discovery/mdns/mdns_records.cc b/discovery/mdns/mdns_records.cc index 9923d2c4..4768e2e4 100644 --- a/discovery/mdns/mdns_records.cc +++ b/discovery/mdns/mdns_records.cc @@ -115,7 +115,7 @@ DomainName::DomainName(std::vector<std::string> labels, size_t max_wire_size) DomainName::DomainName(const DomainName& other) = default; -DomainName::DomainName(DomainName&& other) = default; +DomainName::DomainName(DomainName&& other) noexcept = default; DomainName& DomainName::operator=(const DomainName& rhs) = default; @@ -196,7 +196,7 @@ RawRecordRdata::RawRecordRdata(const uint8_t* begin, size_t size) RawRecordRdata::RawRecordRdata(const RawRecordRdata& other) = default; -RawRecordRdata::RawRecordRdata(RawRecordRdata&& other) = default; +RawRecordRdata::RawRecordRdata(RawRecordRdata&& other) noexcept = default; RawRecordRdata& RawRecordRdata::operator=(const RawRecordRdata& rhs) = default; @@ -228,7 +228,7 @@ SrvRecordRdata::SrvRecordRdata(uint16_t priority, SrvRecordRdata::SrvRecordRdata(const SrvRecordRdata& other) = default; -SrvRecordRdata::SrvRecordRdata(SrvRecordRdata&& other) = default; +SrvRecordRdata::SrvRecordRdata(SrvRecordRdata&& other) noexcept = default; SrvRecordRdata& SrvRecordRdata::operator=(const SrvRecordRdata& rhs) = default; @@ -260,7 +260,7 @@ ARecordRdata::ARecordRdata(IPAddress ipv4_address, ARecordRdata::ARecordRdata(const ARecordRdata& other) = default; -ARecordRdata::ARecordRdata(ARecordRdata&& other) = default; +ARecordRdata::ARecordRdata(ARecordRdata&& other) noexcept = default; ARecordRdata& ARecordRdata::operator=(const ARecordRdata& rhs) = default; @@ -291,7 +291,7 @@ AAAARecordRdata::AAAARecordRdata(IPAddress ipv6_address, AAAARecordRdata::AAAARecordRdata(const AAAARecordRdata& other) = default; -AAAARecordRdata::AAAARecordRdata(AAAARecordRdata&& other) = default; +AAAARecordRdata::AAAARecordRdata(AAAARecordRdata&& other) noexcept = default; AAAARecordRdata& AAAARecordRdata::operator=(const AAAARecordRdata& rhs) = default; @@ -319,7 +319,7 @@ PtrRecordRdata::PtrRecordRdata(DomainName ptr_domain) PtrRecordRdata::PtrRecordRdata(const PtrRecordRdata& other) = default; -PtrRecordRdata::PtrRecordRdata(PtrRecordRdata&& other) = default; +PtrRecordRdata::PtrRecordRdata(PtrRecordRdata&& other) noexcept = default; PtrRecordRdata& PtrRecordRdata::operator=(const PtrRecordRdata& rhs) = default; @@ -372,7 +372,7 @@ TxtRecordRdata::TxtRecordRdata(std::vector<std::string> texts, TxtRecordRdata::TxtRecordRdata(const TxtRecordRdata& other) = default; -TxtRecordRdata::TxtRecordRdata(TxtRecordRdata&& other) = default; +TxtRecordRdata::TxtRecordRdata(TxtRecordRdata&& other) noexcept = default; TxtRecordRdata& TxtRecordRdata::operator=(const TxtRecordRdata& rhs) = default; @@ -441,7 +441,7 @@ NsecRecordRdata::NsecRecordRdata(DomainName next_domain_name, NsecRecordRdata::NsecRecordRdata(const NsecRecordRdata& other) = default; -NsecRecordRdata::NsecRecordRdata(NsecRecordRdata&& other) = default; +NsecRecordRdata::NsecRecordRdata(NsecRecordRdata&& other) noexcept = default; NsecRecordRdata& NsecRecordRdata::operator=(const NsecRecordRdata& rhs) = default; @@ -523,7 +523,7 @@ OptRecordRdata::OptRecordRdata(std::vector<Option> options) OptRecordRdata::OptRecordRdata(const OptRecordRdata& other) = default; -OptRecordRdata::OptRecordRdata(OptRecordRdata&& other) = default; +OptRecordRdata::OptRecordRdata(OptRecordRdata&& other) noexcept = default; OptRecordRdata& OptRecordRdata::operator=(const OptRecordRdata& rhs) = default; @@ -571,7 +571,7 @@ MdnsRecord::MdnsRecord(DomainName name, MdnsRecord::MdnsRecord(const MdnsRecord& other) = default; -MdnsRecord::MdnsRecord(MdnsRecord&& other) = default; +MdnsRecord::MdnsRecord(MdnsRecord&& other) noexcept = default; MdnsRecord& MdnsRecord::operator=(const MdnsRecord& rhs) = default; diff --git a/osp/impl/presentation/presentation_controller.cc b/osp/impl/presentation/presentation_controller.cc index ab090200..6d948ce1 100644 --- a/osp/impl/presentation/presentation_controller.cc +++ b/osp/impl/presentation/presentation_controller.cc @@ -358,7 +358,8 @@ Controller::ReceiverWatch::ReceiverWatch(Controller* controller, ReceiverObserver* observer) : urls_(urls), observer_(observer), controller_(controller) {} -Controller::ReceiverWatch::ReceiverWatch(Controller::ReceiverWatch&& other) { +Controller::ReceiverWatch::ReceiverWatch( + Controller::ReceiverWatch&& other) noexcept { swap(*this, other); } @@ -392,7 +393,7 @@ Controller::ConnectRequest::ConnectRequest(Controller* controller, request_id_(request_id), controller_(controller) {} -Controller::ConnectRequest::ConnectRequest(ConnectRequest&& other) { +Controller::ConnectRequest::ConnectRequest(ConnectRequest&& other) noexcept { swap(*this, other); } diff --git a/osp/impl/quic/quic_service_common.cc b/osp/impl/quic/quic_service_common.cc index d1980254..0a84252d 100644 --- a/osp/impl/quic/quic_service_common.cc +++ b/osp/impl/quic/quic_service_common.cc @@ -5,6 +5,7 @@ #include "osp/impl/quic/quic_service_common.h" #include <memory> +#include <utility> #include "util/osp_logging.h" @@ -62,11 +63,12 @@ ServiceStreamPair::ServiceStreamPair( protocol_connection(std::move(protocol_connection)) {} ServiceStreamPair::~ServiceStreamPair() = default; -ServiceStreamPair::ServiceStreamPair(ServiceStreamPair&& other) = default; - -ServiceStreamPair& ServiceStreamPair::operator=(ServiceStreamPair&& other) = +ServiceStreamPair::ServiceStreamPair(ServiceStreamPair&& other) noexcept = default; +ServiceStreamPair& ServiceStreamPair::operator=( + ServiceStreamPair&& other) noexcept = default; + ServiceConnectionDelegate::ServiceConnectionDelegate(ServiceDelegate* parent, const IPEndpoint& endpoint) : parent_(parent), endpoint_(endpoint) {} diff --git a/osp/public/message_demuxer.cc b/osp/public/message_demuxer.cc index f9166942..986bac9b 100644 --- a/osp/public/message_demuxer.cc +++ b/osp/public/message_demuxer.cc @@ -84,7 +84,8 @@ MessageDemuxer::MessageWatch::MessageWatch(MessageDemuxer* parent, endpoint_id_(endpoint_id), message_type_(message_type) {} -MessageDemuxer::MessageWatch::MessageWatch(MessageDemuxer::MessageWatch&& other) +MessageDemuxer::MessageWatch::MessageWatch( + MessageDemuxer::MessageWatch&& other) noexcept : parent_(other.parent_), is_default_(other.is_default_), endpoint_id_(other.endpoint_id_), @@ -107,7 +108,7 @@ MessageDemuxer::MessageWatch::~MessageWatch() { } MessageDemuxer::MessageWatch& MessageDemuxer::MessageWatch::operator=( - MessageWatch&& other) { + MessageWatch&& other) noexcept { using std::swap; swap(parent_, other.parent_); swap(is_default_, other.is_default_); diff --git a/platform/api/task_runner.h b/platform/api/task_runner.h index c061086f..d90a9d83 100644 --- a/platform/api/task_runner.h +++ b/platform/api/task_runner.h @@ -22,7 +22,7 @@ namespace openscreen { // B runs (even if A and B run on different threads). class TaskRunner { public: - using Task = std::packaged_task<void() noexcept>; + using Task = std::packaged_task<void()>; virtual ~TaskRunner() = default; diff --git a/platform/base/udp_packet.cc b/platform/base/udp_packet.cc index 0410c9f5..7ef620c1 100644 --- a/platform/base/udp_packet.cc +++ b/platform/base/udp_packet.cc @@ -19,7 +19,7 @@ UdpPacket::UdpPacket(size_type size, uint8_t fill_value) assert(size <= kUdpMaxPacketSize); } -UdpPacket::UdpPacket(UdpPacket&& other) = default; +UdpPacket::UdpPacket(UdpPacket&& other) noexcept = default; UdpPacket::UdpPacket(std::initializer_list<uint8_t> init) : std::vector<uint8_t>(init) { diff --git a/util/url.cc b/util/url.cc index efefeb0e..eccb370f 100644 --- a/util/url.cc +++ b/util/url.cc @@ -6,6 +6,8 @@ #include <limits.h> +#include <utility> + #include "third_party/mozilla/url_parse.h" #include "third_party/mozilla/url_parse_internal.h" @@ -74,7 +76,7 @@ Url::Url(const std::string& source) { Url::Url(const Url&) = default; -Url::Url(Url&& other) +Url::Url(Url&& other) noexcept : is_valid_(other.is_valid_), has_host_(other.has_host_), has_port_(other.has_port_), |