Age | Commit message (Collapse) | Author |
|
f367710da5 am: 58adcd624e am: da27832bbb
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1662593
Change-Id: Ib86d4381161ec9a8e12fcd6d9f650d47cc836a22
|
|
f367710da5 am: 58adcd624e
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1662593
Change-Id: If55d183358933b6dbe0ebdb75414055f6aad9f02
|
|
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1662593
Change-Id: Id38fbe6bfefebbf0fecb3eef5cbe87bc99f277f3
|
|
Test: make
Change-Id: I82665b4db5d30e87c87582b483f1404a5fcabe7e
|
|
This change removes OperationLoop because it's only used in one place
and is arguably confusing. OperationLoop mixes sleep() and select()
usage, with separate timeouts, which has resulted in some "tuning" bugs
in the past. Since there's no benefit to the sleep portion and it is
also what causes the confusion, this change removes it and thing
directly uses SocketHandleWaiter in PlatformClientPosix.
Bug: None
Change-Id: I9f62c9253bee7d29b26d1838d34c1399f4d472b5
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2798852
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Jordan Bayles <jophba@chromium.org>
|
|
This change resets needs_key_frame to false after the encoding loop sees
it once to pass it to the vp8 encoder. Previously, once a key frame is
needed, every frame thereafter would become a key frame.
Bug: None
Change-Id: Ia64ab56fd800892462cf8d103c4a9e454d1c850f
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2798115
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Jordan Bayles <jophba@chromium.org>
|
|
This patch makes the maxDelay and maxPixelsPerSecond fields optional.
Bug: 1154956
Change-Id: I0afc8b31a657a5a6224a74a7c168273fb86ac59b
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2794863
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
|
|
This patch renames SenderSession Negotiate to NegotiateMirroring and
OnNegotiated to OnMirroringNegotiated, in advance of a larger patch that
exposes remoting on the SenderSession.
Bug: b/184186374
Change-Id: Ibfa38a822d6fdf5a39ebb83ef493442451fcc91e
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2798518
Reviewed-by: Ryan Keane <rwkeane@google.com>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
|
|
Over the last year, the standalone sender and receiver applications have
gone through some major changes, and unfortunately a few regressions
have been introduced.
This patch fixes the poor performance. This was actually caused by a "fix" to the
PlatformClientPosix implementation, where we were using inappropriate
values for network looping (50ms, which is an eternity).
Bug: b/182937147
Change-Id: I39af927401ce940b81829e5b2992e06bc544ef01
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2792912
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
|
|
Currently, the bandwidth estimator always reports 0kbps, even though we
are successfully sending packets.
Turns out, the LoopingFileSender is erroneously using a second
SenderPacketRouter that is separate from the SenderSession's instance,
so it has no packets to report. This feature is now exposed on the
SenderSession, since bandwidth estimation is a helpful signal for
embedders to throttle capture.
Bug: b/183996401
Change-Id: I932085dfe00df29d8ae79a184ee10b1d3fe5594d
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2792913
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
|
|
This patch fixes a bug where PTR expire updates with a different TTL
from the current record are not considered to be updates, leaving the
now expired record in the graph and returning an error.
A new equality operator, "IsUpdateOf", is added to MdnsRecord to allow
for checking this specific case.
Bug: b/168800070
Change-Id: I5c5d4372d3ded791d102cb95cc37fdf5e944d404
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2785583
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Ryan Keane <rwkeane@google.com>
|
|
This patch improves offer message error handling, adding a specific case
for unencrypted offers--meaning that either the aesKey or aesIvMask is
missing or not properly set.
Bug: b/183070430
Change-Id: Iec27f254dfd4d379318cbdbc4855955c24d49db1
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2771244
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
|
|
This change makes the IP address record the standalone receiver
publishes consistent with the one on which it's listening. It still
prioritizes listening on IPv4 addresses, but previously it might also
advertise an IPv6 address via mDNS.
Bug: None
Change-Id: Ic9496d63e7c075b2e2dab708042dfeec963e5337
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2765985
Reviewed-by: Ryan Keane <rwkeane@google.com>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
|
|
This change adds audio/video out device capabilities to the standalone
receiver's mDNS advertisement.
Bug: b/182937156
Change-Id: I7ef402960df6f88a1a9c1c20dd3c138123725f06
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2765986
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Jordan Bayles <jophba@chromium.org>
|
|
This change moves the log that reports the endpoint to which the
standalone sender is connected. The current log point has an incorrect
port because the answer message hasn't been received yet.
Bug: None
Change-Id: I34e8ba39e99202513cb65c909832eaa3409b1cf7
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2765987
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Jordan Bayles <jophba@chromium.org>
|
|
PiperOrigin-RevId: 355200754
Change-Id: Ic9f1e51d5b6df49074b777a3b7261493c55125a4
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2750548
Reviewed-by: Ryan Keane <rwkeane@google.com>
Commit-Queue: Ryan Keane <rwkeane@google.com>
|
|
The previous failures when building in a chromium tree no longer repro
so this change re-enables it to verify they're also working on bots.
Bug: b/159955844
TBR=jophba@chromium.org
Change-Id: I6334c722755520af9ce9cc75dbfdca71aab442a8
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2739535
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
|
|
I missed these earlier.
Change-Id: I53873874f850193839003c8cb812a0bf68074453
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2740099
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
|
|
This avoids repurposing BoringSSL's internal fields, which would break
if the X509 objects were ever passed into BoringSSL functions that used
those fields.
Change-Id: I84b11dba5dfda5483da00b71e0c4a9f672c20174
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2737735
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
|
|
EXFLAG_SI is recomputed in each loop anyway, so there is no point
storing it with the certificate in the first place. It is also, in this
code, not *entirely* path-independent due to the is_root check. This
fixes a potential bug where checking one path impacts the behavior of
another path.
Change-Id: If9b0d157dd49c44723c1a8e2f83eebfc3fc2779c
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2737756
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
|
|
This CL is needed to compile with the latest revision of BoringSSL.
We're in the process of aligning with OpenSSL upstream and switching
the X509 structure from direct struct access to accessors. This CL fixes
most instances leaves the mutation of x509->nc and x509->ex_flags
(which, even before the struct became opaque, was unsupported), since
they're a little more subtle.
This also switches from X509V3_EXT_d2i to X509_get_ext_d2i, which saves
some code. Note, however, both the old and new version of the CL do not
correctly handle encoding errors in the extensions. For this CL, I've
preserved the original bugs and have focused on resolving the direct
struct accesses, rather than doing a thorough review for correctness.
Change-Id: Ib7c535b726684719baa15c76a84e95a18e0d8114
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2737755
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
|
|
Open Screen is currently reaching into and even mutating BoringSSL's
private X509 structures. This will break in the future, and mutating the
private structure is *especially* unsupported and already broken. Before
I can upload CLs to fix those, I need to update BoringSSL. This updates
to the revision currently used in Chromium.
Change-Id: If9260ca69a407c3e191b3c2178f7f85984cadda5
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2737064
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
|
|
This change makes VerifyTypeImplementsAbslHashCorrectly a nop when
compiling in Chromium, because we aren't allowed to use abseil's
hash_testing.h due to component build + DEPS issues. The unittests will
still work the same outside of Chromium, and in Chromium, everything
other than the hash checking is the same.
Bug: 1159046
Change-Id: I8997bbf2fb080a6ef1b5b475f239d229204b258c
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2691326
Reviewed-by: Ryan Keane <rwkeane@google.com>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
|
|
This fixes an incorrect usage of ErrorOr in Environment that was
triggering an assert in debug mode. The code was not properly
checking that the result was a value before using it.
Change-Id: I2f1c5cc18a66c3293d33e0c758f7b5f51848e688
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2698270
Reviewed-by: Jordan Bayles <jophba@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
|
|
72c40a034b am: a24e2563ed
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1588870
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: Ia6afa34a994bc5eb65d42ec1b9977b90492acfc8
|
|
72c40a034b
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1588870
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I91b7c77db620367223f2769bd4d2af5ad41d0d76
|
|
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1588870
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: Id223fe966b33eb57c7b085e1c8f5e9da53b2d320
|
|
Added SPDX-license-identifier-Apache-2.0 SPDX-license-identifier-BSD
SPDX-license-identifier-ISC SPDX-license-identifier-MIT
SPDX-license-identifier-NCSA SPDX-license-identifier-OpenSSL
SPDX-license-identifier-Zlib legacy_unencumbered
to:
Android.bp
Added SPDX-license-identifier-Apache-2.0 SPDX-license-identifier-BSD
legacy_unencumbered
to:
third_party/abseil/Android.bp
Bug: 68860345
Bug: 151177513
Bug: 151953481
Test: m all
Exempt-From-Owner-Approval: janitorial work
Change-Id: I793d059d1592fc3242590ec7e5f5d9d4a5c48a6f
|
|
This change removes IPAddress and std::vector static initializers from
//discovery/mdns to comply with Chromium rules about no static
initializers. IPAddress constructors were made constexpr and
std::vector was changed to std::array.
Bug: 1159043, 1159045, 1159046
Change-Id: I5935242da3b80836111bc43caa418c871ee95c0b
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2685482
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Ryan Keane <rwkeane@google.com>
|
|
8a643445ad am: 446c71ab1f am: 12bd1aeb5e
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1582703
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I1ed1c73d48bd5e2959bf46056872463d4a825463
|
|
8a643445ad am: 446c71ab1f
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1582703
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: Ic6e725f0fec4ec6b74e694dbc948e24c8addfda1
|
|
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1582703
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I52247070a2e6a2e3fa28ba3ee18fff276fde232f
|
|
Test: make
Change-Id: Ibded80f41034de5725807574938bbf8b9cc22777
|
|
2e0bfd0b1e am: 1886419065 am: e6d1351c81
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1580897
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I84d4a70888885d5c6f44264e197dffac30c61450
|
|
5594fad4a1 am: cd7b055e9f
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1580896
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I5f363284a53c93168cba2225479a668412006e73
|
|
2e0bfd0b1e am: 1886419065
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1580897
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I0ba7f95600482b7cc6fca34f6621e26923fb3d72
|
|
5594fad4a1
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1580896
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I8b174021a156cdb20b913a7aee3d40db57270938
|
|
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1580897
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I81de504991c3ae330d2ebdaa0619ad699276b862
|
|
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1580896
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I78e70ac687411964aee4c4abed5a4b3cc184d5c6
|
|
Bug: 1159043, 1159044, 1159045, 1159046, 1159047
Bug: 1159048, 1159049, 1159050, 1159051
Change-Id: I4c01784608057662fc432f4ac35ced7c0be9b601
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2678725
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
|
|
Test: make
Change-Id: I7d2a9b41a4fd7d81660ccf4121bbd5073fb7dc96
|
|
Change-Id: Ib08d8d8b3b228eee0a3faa857b7260a742258945
|
|
This is a followup patch to:
https://chromium-review.googlesource.com/c/openscreen/+/2643397
To make it RFC compliant, we now send to the multicast
group address, not to ANY. We also bind to ANY address instead of the
local address of the interface, since binding filters multicast traffic
to only bound addresses. Joining the multicast group is what filters
the traffic instead.
Bug: b/178102949
Change-Id: I1d7e44b5e90d2f1f1d395cb9a8a689edf16bfafb
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2665304
Reviewed-by: Ryan Keane <rwkeane@google.com>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
|
|
mktime return localized timezone result.
Certification uses UTC time zone,
so call timegm/_mkgmtime to match with certification.
Change-Id: I338ca14bb75e75d45c1de1ab976a61ec2e51eeca
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2658656
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
|
|
This patch fixes a potential timing issue where we attempt to send an
Answer message before the UDP socket is bound.
The current behavior is
that we construct an Answer with a UDP port value of 0, which results in
the Answer failing validation and an error Answer message being sent
back to the sender.
The new behavior is that the Answer message is not sent until the
environment is notified that the UDP socket has been bound. This is
accomplished by an addition to the UDPSocket::Client abstract class, a
new OnBound event.
Bug: b/174501332
Change-Id: I4bcebe78d8d41c29bb4b4698c5565f0dd9ef2c17
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2645893
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Jordan Bayles <jophba@chromium.org>
|
|
c308a78ef3 am: 1223527d4d am: aad0dc8440
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1559188
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: Ia4cbfb5b7bda96462afcac5a5bbc03b5c4dc1ded
|
|
This change makes openscreen ready to be compiled with -std=c++17. In
particular, c++17 demands the consistent use of the noexcept keyword
accross declaration and definition.
Bug: chromium:752720
Change-Id: I4715cbc7ccc9576e33ad7dec0ce6c1f6ebd9935b
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2643286
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
|
|
c308a78ef3 am: 1223527d4d
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1559188
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: Iee092e4e8ed2c0d56d237daca079ed9aa3dc8f75
|
|
This patch fixes a bug in the mDNS service where the incorrect address
is used for UDP socket binding. New behavior:
1. Bind the interface's local IPv4 and IPv6 addresses.
2. Join the multicast group with the default mDNS group address on the
specific network interface.
3. Send to the any address on the default multicast mDNS port.
Bug: b/178102949
Change-Id: I23235fce8d70e2b248ab42381167c2f01568f713
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2643397
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Ryan Keane <rwkeane@google.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/external/openscreen/+/1559188
MUST ONLY BE SUBMITTED BY AUTOMERGER
Change-Id: I7e912d002993a8f5b9ebd42ae9b47fb1f3505bd0
|