aboutsummaryrefslogtreecommitdiff
path: root/cast
AgeCommit message (Collapse)Author
2021-08-24[Open Screen] Generate unique id for loopback.mark a. foltz
The standalone receiver was not initiating discovery when passed the loopback interface, because it has no hardware address. Re-enable discovery for interfaces without hardware addresses, and generate a random unique ID as a fallback for receivers with missing addesses. Bug: b/197659239 Change-Id: I7d72ee8616f1b463220320b06a8b0318798d040e Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3116549 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org>
2021-08-23Fix AV1 bug in standalone sender/receiverKennan Gumbs
This patch fixes a crash that occurs when using AV1 with the standalone sender and receiver. Change-Id: I1cb6abd31b40d6c919e18eed527894ebae543618 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3111610 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org>
2021-08-17Add missing initializer for ConfiguredSendersFabrice de Gans
The audio_sender and video_sender properties were not initialized to nullptr, resulting in incorrect values being sent to the embedder. Bug: crbug.com/1240354 Change-Id: I4f286f041ba78764d7cbc7fd7bf4f4ccb9ac1b95 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3097162 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2021-08-12[Remoting] Updates to RPCMessenger for downstream usageJordan Bayles
This patch contains several changes for allowing the RPCMessenger to more easily integrate downstream in media/remoting. Bug: b/184683535 Change-Id: I4bb9d088d25a6b9acb827b072e9765812e1f6986 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3089653 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Ryan Keane <rwkeane@google.com>
2021-08-11Enable AV1 codec in standalone sender and receiverKennan Gumbs
This patch adds support for AV1 using libaom. It also adds documentation for compiling libaom from source, since the version provided by the Linux package manager is too slow for realistic use. Change-Id: Icd0bb3001a1107087749de9e24a9781b3b8b04d4 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3066030 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org>
2021-08-11Add VP9 and AV1 testing to standalone_e2e.pyKennan Gumbs
Currently the python script responsible for testing the standalone sender and receiver only tests VP8. This patch adds tests for VP9 and AV1. Change-Id: I7b348b01975484c2c58380b464494e78a8470e94 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3086189 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org>
2021-08-04Fix use of win32 gmtime_sbtolsch
This change fixes the error condition of gmtime_s, which is that it returns 0 in success and non-zero on error. Bug: chromium:1236616 Change-Id: I7d4cbab7e547c3bd10dbc6df78f5122eeec2b35b Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3072865 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
2021-08-04Internal changeAnirudh Tadakamala
PiperOrigin-RevId: 386265931 Change-Id: I8ac2fe3457000320e5145dcb20087bed25e20cb9 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3072042 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Ryan Keane <rwkeane@google.com>
2021-08-02Add informational cast standalone botJordan Bayles
This PR adds an experimental (i.e. non-blocking) bot called linux64_cast_debug, that builds the standalone cast binaries in order to run the standalone_e2e.py test script in a later patch. This does NOT add the dependency libs for cast standalone, which will need future work with the infrastructure team. Finally, this patch adds some improved logging to the cast standalone script. Change-Id: I02448420c44a0e9184f260fa2ce02710c90693b5 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3063815 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Ryan Keane <rwkeane@google.com>
2021-08-02Update SampleFormat to match media::SampleFormatThomas Guilbert
This adds a kSampleFormatPlanarU8, to mirror the changes in the chromium media code. Bug: chromium:1231734 Change-Id: I6046c31b28b032ba49c8f723504f4dc8510ef4ec Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3044460 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2021-07-29[Cast Streaming] Add standalone python test scriptJordan Bayles
This patch adds standalone_e2e.py, a simple-ish script that exercises the standalone sender and receiver executables. Change-Id: Ibf8c8580ebf6759f03fa17c41e9034bb91f93513 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3001104 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
2021-07-27Add AOM as a third_party dependencyKennan Gumbs
This patch adds a dependency on the AOM library to be used for AV1 codec support. Change-Id: If1cf68a3c64e7cb419bfb2378b5ef9ff29fd8d6d Bug: b/194189589 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3039421 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org>
2021-07-27[Cast Standalone] Implement Play/PauseJordan Bayles
This patch adds play/pause support to the standalone receiver and sender classes while remoting. The implementation uses SDL keyboard event bindings to pick up on spacebar presses when the SDL player window (e.g. the standalone receiver video) is in focus. This event binding results in a SetPlaybackRate message being sent over the RPCMessenger, and then the standalone sender class uses the message's double value to toggle playback on the simulated capturer implementations. While falling far short of a full media player implementation, this patch may help embedders see the basics of how RPC messenging and keeping the sender and receiver media streams in sync can behave. Change-Id: I4d2e1ed7f6d69f8a24385c9139320492c2101600 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3034990 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2021-07-27[Open Screen] Fix mdns build issues.mark a. foltz
This patch adds some missing DEPS from the recent mDNS refactor in SHA1 hash f9715c5369c7dca34da0cb7b416efe65ed52a474. This was copied from https://chromium-review.googlesource.com/c/openscreen/+/3048521 TBR=rwkeane@google.com Bug: b/179705382 Change-Id: I839ed82a46a9ddebd674e565b3d2d70e6f728ac8 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3055792 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org>
2021-07-26Add AuthContext::CreateForTest for fuzzerbtolsch
This change adds the ability for tests to create an AuthContext using a fixed data string for the nonce. This is to facilitate reproducibility of fuzz tests and is a direct copy of the existing upstream version. Bug: b/185815206 Change-Id: Ifef4e4cca641e6113356e5818bed2006e814a4de Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3053623 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
2021-07-21[Open Screen] Create a //discovery:public targetmark a. foltz
This creates a :public GN target for other Open Screen modules (or embedders) to depend on. It also: - Consolidates the DNS-SD public APIs. - Adds DEPS rules to enforce use of public headers. - Adds DEPS rules to enforce layering inside of //discovery (with some exceptions). - Adjusts deps for the //discovery targets. Bug: b/179705382 Change-Id: Ice48b8d8937d3c68351d693b348a2928f14dfb4b Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3032947 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Ryan Keane <rwkeane@google.com>
2021-07-17Fix a few more accesses of private BoringSSL structures.David Benjamin
This CL is needed to unblock the BoringSSL roll in Chromium. Change-Id: I95734ee6aa3c78b543ac921c3f3ca273950ef7a8 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3036087 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
2021-07-16Enable VP9 codec in standalone sender and receiverAbraham Corea Diaz
This patch adds support for the VP9 video codec by modifying the former streaming VP8 encoder to a general streaming VPX encoder that handles both VP8 and VP9. It also adds a command line argument to the sender to allow choosing which codec to use. Change-Id: Ia254df071c37dddcbe8ea136aaaee47bc8db80a2 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3028642 Reviewed-by: Jordan Bayles <jophba@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org>
2021-07-16[Cast Streaming] Add codec parameterJordan Bayles
This patch adds a new codec parameter to the OFFER/ANSWER exchange. This field respects the format laid out in RFC 6381, and is a strictly optional field that allows senders to provide more information about a given codec configuration. Bug: b/184429130 Change-Id: Ibd537f05e579b3bb2a488712b688edb407784841 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2984452 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
2021-07-14Fix Ordering Issue in HeaderRyan Keane
This CL fixes an issue where the #endif include guard occurs in the wrong place, leading to compile errors if the header is included more than once. Change-Id: I7973e6c36ab236f9496e48a70264a3a0a3496b54 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3024946 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Ryan Keane <rwkeane@google.com>
2021-07-14Define virtual destructors in Client interfaces.Abraham Corea Diaz
This patch adds virtual destructors to all Client and Delegate interfaces that did not have one. Bug: b/156129407 Change-Id: I8b7365ab8a38b9e76a45ced08dd94d1aa595209b Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3011415 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
2021-07-14Remove abseil dependency from HexEncode methodKennan Gumbs
Currently the HexEncode method defined in util/stringprintf.h depends on absl::Span, which is part of abseil. This patch removes the dependency, allowing the method to be more widely used. Bug: b/158660166 Change-Id: I37715271391000b5c61d5a657f604db2bc6c882e Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3001949 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2021-07-14Add a new constant for AV1 codec.Abraham Corea Diaz
This patch adds a new constant representing the AV1 video codec and a unit test for it. It also adds AV1 and VP9 constants to RtpPayloadType. Change-Id: I3233ea97c3fb9759805b9c8f3d6faecbf9fa3e30 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3012119 Reviewed-by: Jordan Bayles <jophba@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
2021-07-09[Open Screen] Capture error messages in cast_auth_util_internal.cc.mark a. foltz
This converts DVLOGs which were removed in 3001340 to messages passed along with the Error object returned by functions in cast_auth_util_internal.cc. It then propagates the messages via the wrapped Error returned by VerifyCredentialsImpl(). Bug: b/159172782 Change-Id: I2a2b801aeaec71648ff195f7e917d40574ae05f8 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3012114 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org>
2021-07-08Improve codec filtering in streaming_schema.jsonKennan Gumbs
Currently the codecName property in streaming_schema.json accepts any string. This patch modifies it to only accept supported codecs. Change-Id: If0e02e88feba7d03219a9e1808fc95c5290f26b2 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3010321 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org>
2021-07-03Rename Device to ReceiverAbraham Corea Diaz
This patch renames relevant usages of Device to Receiver. Bug: b/155337619 Change-Id: Ib21c99ee7ceb6a7f73247e00c0e2638a92c342c1 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2998268 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org>
2021-07-02Remove DVLOG debug logging throughout LibCastAbraham Corea Diaz
This patch removes instances of OSP_DVLOG in LibCast or changes them to OSP_VLOG as needed. Bug: b/159172782 Change-Id: I2fab57cece82af0dc67ad9a596404d563e7707cd Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/3001340 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org>
2021-07-01[Cast Streaming] Add codec negotiation over RPCJordan Bayles
This patch adds support for negotiating codec information over the RPC messenger class for both the standalone sender and receiver. Although a full remoting implementation in the standalone implementations is not a goal and not particularly practical, it is important that we exercise the public remoting APIs and get basic usage and flows handled in our library. To that end, this patch specifically adds support for sending RPC_DS_INITIALIZE and RPC_DS_INITIALIZE_CALLBACK messages, simulating the process of setting up a remoting media stream and demuxer in Chrome. NOTE: this does not enable "true" remoting--the standalone sender is still decoding and reencoding the video. For "true" remoting support we need the ability to unpack raw frames (probably exclusively from a WebM container that holds VP8 frames) and pass them directly. In future patches, we can also consider adding additional features to the standalone implementation, such as play/pause and volume control methods. Bug: b/190078859 Change-Id: I49c2acb537aa3c647b8c3a53c9545f5eb3893982 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2973373 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
2021-07-01Update message util to use EnumNameTableJordan Bayles
This patch updates CastMessageType to use EnumNameTable, closing out a TODO and somewhat cleaning up the code. Change-Id: Icae46033db8487e71ea7e15c5d0cc40275794db8 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2994034 Reviewed-by: Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2021-06-30Rename ServiceInfo to ReceiverInfoAbraham Corea Diaz
This patch renames ServiceInfo and all related usages to ReceiverInfo. Bug: b/155337619 Change-Id: I9337dbb7f64339bf60f079726f21af9a2452cddb Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2994467 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org>
2021-06-30Fix Wunreachable-code-aggressive.Peter Kasting
Bug: chromium:1066980 Change-Id: Ie1ad4660e4c418a625efad488864617583501501 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2995900 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
2021-06-29[Cast] Fix merge conflictJordan Bayles
An incorrect merge resolution causes a compile error on some compilers. This patch is a simple fix for the standalone sender build. Change-Id: I2673386434a7bdbee553b75dc52adf8610ce7137 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2994462 Reviewed-by: Ryan Keane <rwkeane@google.com>
2021-06-29Update Cast Core API depsbtolsch
This change updates the deps for the build rules to match the includes of the protos. Bug: b/172295002 Change-Id: I4cd0bef9c95e19b4650bdbf9becdb68bf737d6aa Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2992819 Reviewed-by: Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
2021-06-29[Cast Streaming] Allow playing file only onceJordan Bayles
Currently, the looping file sender plays the video over and over again. In some cases, like testing, we want to only play the video once. This patch adds a new command line argument that stops the sender after the video finishes playing. Bug: b/191492654 Change-Id: I97a2f1e211037abd09ac21ee482c9f95502ba821 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2986060 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Ryan Keane <rwkeane@google.com>
2021-06-28Add Cast Core API BUILD.gnbtolsch
This change upstreams the BUILD.gn for Cast Core gRPC API files. These will only build when included in chromium in order to avoid duplicating the rather complicated build setup required for importing gRPC as chromium does. Bug: b/172295002 Change-Id: I0585f8453207bd1ca4f0403a91808fe28cae317a Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2992818 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
2021-06-28Fix compile error due to initialization issueKennan Gumbs
Currently the standalone sender does not build due to how a class is set up. This patch fixes it by changing the class initialization. Change-Id: Icf7845179b019330d87f5f9b568cc8e746ebe072 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2993319 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org>
2021-06-25Fix AutorollerRyan Keane
Autoroller is failing as shown here: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20MSan%20Tests/28940/overview This CL should fix it Change-Id: I94a9b1d8e683337fd04968632a92b573d5b82c97 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2989631 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Ryan Keane <rwkeane@google.com>
2021-06-24Add SupportsAllAllowedBy() function to ReceiverSession inner classesRyan Keane
This CL does the following: - Add copy ctors for ReceiverSession inner classes. This is required so that a Preferences object may be copied to a unique_ptr for initialization of the `cast_streaming` component in Chromium, while also maintaining a local instance for use with the below function. - Add SupportsAllAllowedBy() functions for comparing the support provided by two different Preferences instances. This is required because the Cast Web Runtime allows for updating of supported AV settings during runtime, so it must be validated that the configuration used for negotiation is no more strict than that supported at any time by the runtime. Bug: 182427395 Change-Id: Ie7a8625ffbf8156e49e36c13dbcb91e8da214e7b Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2983166 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Ryan Keane <rwkeane@google.com>
2021-06-24Internal changeGoogler
PiperOrigin-RevId: 373407178 Change-Id: Ica1520f3a0f004f976840ce7b32ecb2d219bc600 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2984101 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Ryan Keane <rwkeane@google.com>
2021-06-24Fix GN check issuesJordan Bayles
This patch fixes various issues found through `gn check` throughout the repository, including some fuzzing issues. Bug: b/155434332 Change-Id: I2dffa42f5dfd291a7c59653eb7ca16ec680bfddb Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2964569 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2021-06-12[Cast Streaming] Update receiver commentingJordan Bayles
This patch updates the receiver commenting to remove some out of date comments and clarify some finer points of the API. Change-Id: Ic22083308408bfdf666c4c8769e083dd7e925baf Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2954247 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2021-06-12[Cast Streaming] RpcBroker -> RpcMessengerJordan Bayles
This patch renames Open Screen's RpcBroker to RpcMessenger, in order to avoid confusion when discussing this implementation versus Chrome's RpcBroker implementation--which will be going away soon. Change-Id: I23127074db3f7d807c6f70c26c7b596b6edb503a Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2953900 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2021-06-10[Cast Streaming] Add DCHECK for codec typesJordan Bayles
This patch improves error checking in the ReceiverSession, by ensuring that kNotSpecified is not passed as a codec preference to the session. Change-Id: Ifab5626da4de4617721ed2c8a4187fc47bbfc24a Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2950432 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Ryan Keane <rwkeane@google.com>
2021-06-10[Cast Streaming] Improve remoting in ReceiverSession APIJordan Bayles
This patch continues the process of wrapping up remoting support, by adding some support to the standalone implementations and cleaning up the ReceiverSession API. From here, the actual media stream will have to be mocked out/a standalone implementation created so that we can properly test the entire remoting flow and set the stage for integration into chrome. Bug: b/184186390 Change-Id: Ib2a5526ce5db71cb093f228acbc64cf3060e677d Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2939634 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Ryan Keane <rwkeane@google.com>
2021-06-10[Cast Streaming] Messager -> MessengerJordan Bayles
Messager, while being proper English, is archaic and generally not in use. This patch updates SessionMessager and its related types to be named SessionMessenger. Change-Id: I8d9caa685f86fa5863db56b4514a4d16ed5f1a33 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2950433 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2021-06-08[Cast Streaming] Document Android RTP HackJordan Bayles
After offline discussion, it has been determined that legacy Android TV devices, such as Nexus Player, and some 3P Android TV implementations may still need the Android RTP hack introduced in https://crbug.com/631828. This patch adds references to this CR bug to make the history of this hack easier to access. Bug: b/184438154 Change-Id: I1bcabc09c912040fc0a29023b9bd9975415a13ea Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2945376 Reviewed-by: mark a. foltz <mfoltz@chromium.org>
2021-06-08[Hotfix v2] Fix deprecated Offer::Parse declarationJordan Bayles
A previous hotfix patch didn't factor in the change in signature between Offer::Parse and Offer::TryParse. This patch remedies the change, offering a proper, deprecated declaration of Offer::Parse. TBR=rwkeane@chromium.org Change-Id: Id6e8b67226070fd507bebe64a65a1ac9b99e4228 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2945631 Reviewed-by: Jordan Bayles <jophba@chromium.org> Reviewed-by: Ryan Keane <rwkeane@google.com>
2021-06-07[Hotfix] readd deprecated declarationJordan Bayles
This patch fixes the Chrome build by readding a deprecated declaration. TBR=rwkeane@google.com Change-Id: Ibb506764ac47dde09e56b1cb1ddf7f31f4cd2dd6 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2944213 Reviewed-by: Jordan Bayles <jophba@chromium.org> Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2021-06-04[Cast Streaming] Cleanup OFFER/ANSWERJordan Bayles
This patch finishes handling a TODO around json deserialization for offer messages, and removes some of the duplicate code in the json_helpers.h header. One more followup patch after this: ParseAndValidate* methods be simply renamed to Parse* methods. Change-Id: I36db01f1841731793597e5f89e904edb36d027ef Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2911769 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Ryan Keane <rwkeane@google.com>
2021-05-28[Open Screen] Allow deprecated ffmpeg initialization.mark a. foltz
This is an updated version of https://chromium-review.googlesource.com/c/openscreen/+/2658659. Original commit description: Call av_register_all, avcodec_register_all for < ffmpeg 4 In ubuntu, `apt` installs ffmpeg 3.x (In 20.04, ffmpeg 3.4 installed). Before ffmpeg 4, without av_register_all(), avcodec_register_all() ffmpeg's api should fail. Change-Id: I7cde9b90b968a5d03bd7317974fab30a9d548e36 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2920374 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-04 23:16:55 +0000