aboutsummaryrefslogtreecommitdiff
path: root/infra
AgeCommit message (Collapse)Author
2020-05-19Fix code coverage bot--blocking checkinJordan Bayles
Currently there are some naming mismatches for the new code coverage bot, refererring to it as linux64_coverage_debug in some places, and code_coverage in others. This patch is an attempt to fix the build system by unifying the names of the bot. Change-Id: Ie4702db7fecf89d1238ef9cdd83e85b4631926ab TBR=rwkeane@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2207638 Reviewed-by: Jordan Bayles <jophba@chromium.org>
2020-05-19Code Coverage: Add missing buildbot configRyan Keane
Change-Id: I9db029e58629b4b68836e039f1c29f85e420549b Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2207632 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org>
2020-05-13Move Code Coverage to new FYI botRyan Keane
Currently, the Step module's step.nest command as used in the openscreen trybot and the code_coverage module does not function as documented: https://cs.corp.google.com/github/luci/recipes-py/recipe_modules/step/api.py?fromv2=true&l=208 This is a known issue and is being tracked by bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1078530 Until this bug is resolved, code coverage must be calculated in a separate trybot, or issues in code coverage can cause an otherwise passing trybot to fail. This CL adds an FYI bot to calculate code coverage, and removed the code coverage mixin from existing required bots. Change-Id: I47a9bf8429ce424262660b13911e1f14d14f49e4 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2182316 Commit-Queue: Ryan Keane <rwkeane@google.com> Reviewed-by: Jordan Bayles <jophba@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
2020-04-30Code Coverage: Add missing lineRyan Keane
Change-Id: I82402ef523e93617f4a0fe3b8dc620c70ed552ce Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2174268 Reviewed-by: Ryan Keane <rwkeane@google.com> Reviewed-by: Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Ryan Keane <rwkeane@google.com>
2020-04-28Code Coverage: Build ChangesRyan Keane
Add the required changes to the build for this repo to add code coverage to CLs submitted on Gerrit. This CL includes the following changes: - Add the merge_results.py script. In chromium, these scripts are run during the build, on each sharded test machine to gather up all '.profraw' files (the raw coverage files generated by unit tests when coverage is enabled), merge them, and generate a single '.profdata' file (the processed coverage data file). Currently, the merge step is unneeded for the openscreen library, but the conversion to .profdata files is still needed. This will be run by the buildbot, after the code_coverage module has been initialized and unit tests have been run, but before the generated coverage data can be used and uploaded. If, later, code coverage data for E2E tests is added as-well, this merge step will become useful :) - Updates to the openscreen buildbot config to support code coverage in buildbot builds. Change-Id: I500f1d1ac501e8005df4e6c62cfcb25968c78e9f Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2168541 Commit-Queue: Ryan Keane <rwkeane@google.com> Reviewed-by: Brandon Tolsch <btolsch@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org>
2020-04-23Readd Debian stretch for bot compilationJordan Bayles
Currently the ARM64 bots are using too new of a version of glib, so they are incompatible with all of the bots in the luci.flex.try pool that run ARM64. This patch readds the Debian stretch sysroot for cross compiling, so we link an older version of glib that is either the same or forwards compatible with the newer version linked in the Ubuntu 18.04 bots. Bug: openscreen/18 Change-Id: I3ada49ac5197844b0c49028194a17c993c7b2663 TBR=btolsch@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2163436 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2020-04-21Revert ARM64 bot to 16.04 due to linker problemsJordan Bayles
Currently, cross compiling on bionic is borked since there is an "unsupported GNU_PROPERTY_TYPE" on several of the compiler artifacts. This warning cannot be turned off or ignored with a flag, so the only way is to use a different linker version. This chain will have a follow up patch to force the swarming bot, since the swarming bot tests MUST be run on 18.04 instead of 16.04. It's a delicate flow, if 18.04 updates to a more recent linker version or if we can figure out how to roll our own linker tools in cross compile this will hopefully go away. Bug: openscreen/18 Change-Id: I1ccd4eba9d97020c56b0aa9af131dc673bd6b466 TBR=btolsch@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2158819 Reviewed-by: Jordan Bayles <jophba@chromium.org>
2020-04-13Fix typo in LUCI scheduler for ARM64 botbtolsch
Currently, the CI ARM64 bot is never run because the LUCI scheduler config has a typo in the name for the builder. This change fixes the typo so it should begin running. Change-Id: Ie555d374d3ed937c2fc43917d64f03a846480ad2 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2147818 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2020-04-13Move ARM64 bot back from stretch to sidJordan Bayles
The ARM64 bot has been upgraded to 18.04, so the stretch sysroot is no longer needed. This patch removes it. NOTE: this also includes removing almost all of the platform targeting code, since we only have one platform now they are dead code paths. Future developers should consider referring to this patch if we ever have multiple flavors of sysroots at the same time again. TBR due to buildbucket change, and this is 100% code removal. TBR=btolsch@chromium.org Bug: openscreen/18 Change-Id: Ic85f54bb7467f1317776a3cea3a1878bc6caae58 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2147773 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2020-04-11Upgrade ARM64 bot configurationJordan Bayles
This patch updates the ARM64 bot from Linux 1604 to Linux 1804, in order to request the new docker image for swarming. Note: a follow up patch in the openscreen.py infra file is likely. TBR so that I can test bot stability over the weekend, and it's a minimal change that shouldn't require much review. TBR=btolsch@chromium.org Bug: openscreen/18 Change-Id: I27d6728dee49375c0441d113277c3a3e13b8d44e Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2145630 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2020-04-08Change mixin name from jessie to stretchJordan Bayles
This patch changes the mixin name in the buildbucket.cfg. The buildbucket.cfg lags being picked up by the bot, so TBR to get this tested quickly. TBR=btolsch@chromium.org Change-Id: I2db7397b396879d0455c11da8751513554ec9f38 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2142318 Reviewed-by: Jordan Bayles <jophba@chromium.org>
2020-04-08Move from jessie to strechJordan Bayles
This patch removes the jessie sysroots, which are too old for the C++ features that we use, in favor of new stretch sysroots that I generated by pulling an old version of chromium/src and using the sysroot-creator.sh script with a stretch package configuration. TBR due to buildbucket.cfg changes, trying to get the bot landed today. TBR=btolsch@chromium.org Change-Id: I6dfae987c4be6aae24386ede3abe33d01596821e Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2142317 Reviewed-by: Jordan Bayles <jophba@chromium.org>
2020-04-08Add jessie mixin to arm64_debug trybotJordan Bayles
Missed a mixin, so the bot still isn't behaving properly. TBR=btolsch@chromium.org Change-Id: I7db2559a97aaa2afe0a61f918fbf500767200f77 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2142313 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2020-04-08Refactor properties in cr-buildbucket.cfgJordan Bayles
This patch is to fix a potential issue where the properties aren't being set correctly. TBR since our build system is dumb and refuses to use the cr-buildbucket.cfg file in LED builds unless it is checked in. TBR=btolsch@chromium.org Change-Id: I1b6738ce01f5de9472232505f5a92e3f770b179d Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2141013 Reviewed-by: Jordan Bayles <jophba@chromium.org>
2020-04-07Add legacy (Debian Jessie) sysrootJordan Bayles
Currently, the arm64 build bot fails because the sysroot image references a version of the standard library that is much too new for the build bot to run against. This patch lays the groundwork to resolve that issue by adding a new platform argument to openscreen, with Jessie sysroots that should fix the build issue. Change-Id: Ie2cd1de1a59281eab2d86b78d6d36897722185be TBR=btolsch@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2140478 Reviewed-by: Jordan Bayles <jophba@chromium.org>
2020-04-03Add recipe engine servers to buildbucket cfgJordan Bayles
This patch adds server configuration for the swarming and isolate servers to the buildbucket.cfg file, allowing the bot to upload isolates and start swarming tasks. Bug: openscreen:18 Change-Id: I4d5e9780f5320f3e5a963ebcddb7cdd7d0084c45 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2135505 Reviewed-by: Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2020-04-02Fix bot name in try bucketbtolsch
A luci.openscreen.ci bot snuck into the "try" console. This change just renames the path to the try version. Change-Id: I77f8c5019c2a9d07a1483d844e0d08efeec4f81b Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2134729 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
2020-03-27Hotfix for broken arm botJordan Bayles
This patch fixes the arm bot configuration, which is broken because the current setup uses the target_cpu and assumes I want a host_cpu that is also ARM64. TBR=mfoltz@chromium.org Change-Id: Ibcb87ac4fc977bad31283014dcd024be90be8e48 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2124589 Reviewed-by: Jordan Bayles <jophba@chromium.org>
2020-03-27Add ARM64 build botJordan Bayles
This patch adds a bot that builds on linux64 for a target cpu of ARM64. After this patch lands, we should have validation as part of checkin that our cross compile toolchain is working properly. Next step will be updating the scripts/slave/recipes/openscreen.py file to run the tests (QEMU or isolate TBD). Bug: openscreen/18 Change-Id: I744403788d055e09ab27931c8141dba09b268c58 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2122257 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
2020-01-22Issue 102: Make Chromium trybots non-optionalJordan Bayles
We have gotten to the point where our Chromium bots are pretty stable, and should start gating checkin. This patch changes our checkin process to make chromium trybot success mandatory. Bug: crbug.com/openscreen/102 Change-Id: If0b37ddd1bf3bbe57c7b606e09ba38e8f5b1897a Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2014884 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2020-01-15Revert "Add ARM buildbot, update configurations"Jordan Bayles
This patch reverts the ARM64 bot configuration, since it won't work until we cross compile and use an isolate for tests. TBR: miu@chromium.org Change-Id: I10b626c4cc9854e8101e0fe07a12bd03bcde9c42 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2003229 Reviewed-by: Jordan Bayles <jophba@chromium.org>
2020-01-14Make presubmit bot run gclient hooksbtolsch
This change makes the presubmit recipe run `gclient runhooks` to ensure the bot has a copy of clang-format, now that that's how it is expected to be downloaded. clang-format is used by the presubmit script, so this is required. Change-Id: Id3a026d69dbb26e76793e999fa12ed54317bfd22 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2001467 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
2020-01-09infra config: Add back the comment about how the OSX_SDK recipe works.Yuri Wiitala
Relands only the comments that were added to our cr-buildbucket.cfg in the reverted commit 1a5032f91662568ed3f. These comments are very useful for helping us find where our build recipes are in the chromium //build repo, and how everything comes together in the actual build on the bots. There is no configuration or other functional change being made here. TBR=jophba@chromium.org Bug: openscreen:86 Change-Id: I8edbc8107d094525ad6881ba68a9ebbb0f337ab7 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1992823 Reviewed-by: Yuri Wiitala <miu@chromium.org>
2020-01-08Fix milo config for try buildersbtolsch
This change adds the chromium try builders to the milo console and fixes the link to the linux_arm64 try builder (was to the ci bot). Change-Id: Ica0ef99476cfae1f53d5d35c0bde944cd8ba937f Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1992303 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2019-12-26Reland "Add ARM buildbot, update configurations"Jordan Bayles
This reverts commit c89ba142f1add0881ebd73071e89764e326d5c3d. Reason for revert: Fixed up ARM bot configurations Original change's description: > Revert "Add ARM buildbot, update configurations" > > This reverts commit b5ad11566a8da7fb844d2dd4e3f253dc607303ab. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Add ARM buildbot, update configurations > > > > This patch updates the build bots to use the most appropriate dimensions > > for the fleet at this time (Dec 2019), and adds a new ARM64 buildbot. > > > > Change-Id: I5c44619196654aa3f17bbc3519aa00344d5c6de5 > > > > Add ARM buildbot, update configurations > > > > This patch updates the build bots to use the most appropriate dimensions > > for the fleet at this time (Dec 2019), and adds a new ARM64 buildbot. > > > > Change-Id: I5c44619196654aa3f17bbc3519aa00344d5c6de5 > > Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1980849 > > Reviewed-by: Jordan Bayles <jophba@chromium.org> > > Reviewed-by: mark a. foltz <mfoltz@chromium.org> > > Commit-Queue: Jordan Bayles <jophba@chromium.org> > > TBR=mfoltz@chromium.org,miu@chromium.org,jophba@chromium.org > > Change-Id: Ie2b436883f2f9bb6c02eca03f2810993b4b1a80d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1982132 > Reviewed-by: Jordan Bayles <jophba@chromium.org> > Commit-Queue: Jordan Bayles <jophba@chromium.org> TBR=mfoltz@chromium.org,miu@chromium.org,jophba@chromium.org Change-Id: I3daddbe18bc3f93932172f610176c77a1c813cda No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1982809 Reviewed-by: Jordan Bayles <jophba@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2019-12-26Revert "Add ARM buildbot, update configurations"Jordan Bayles
This reverts commit b5ad11566a8da7fb844d2dd4e3f253dc607303ab. Reason for revert: <INSERT REASONING HERE> Original change's description: > Add ARM buildbot, update configurations > > This patch updates the build bots to use the most appropriate dimensions > for the fleet at this time (Dec 2019), and adds a new ARM64 buildbot. > > Change-Id: I5c44619196654aa3f17bbc3519aa00344d5c6de5 > > Add ARM buildbot, update configurations > > This patch updates the build bots to use the most appropriate dimensions > for the fleet at this time (Dec 2019), and adds a new ARM64 buildbot. > > Change-Id: I5c44619196654aa3f17bbc3519aa00344d5c6de5 > Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1980849 > Reviewed-by: Jordan Bayles <jophba@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> > Commit-Queue: Jordan Bayles <jophba@chromium.org> TBR=mfoltz@chromium.org,miu@chromium.org,jophba@chromium.org Change-Id: Ie2b436883f2f9bb6c02eca03f2810993b4b1a80d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1982132 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2019-12-26Add ARM buildbot, update configurationsJordan Bayles
This patch updates the build bots to use the most appropriate dimensions for the fleet at this time (Dec 2019), and adds a new ARM64 buildbot. Change-Id: I5c44619196654aa3f17bbc3519aa00344d5c6de5 Add ARM buildbot, update configurations This patch updates the build bots to use the most appropriate dimensions for the fleet at this time (Dec 2019), and adds a new ARM64 buildbot. Change-Id: I5c44619196654aa3f17bbc3519aa00344d5c6de5 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1980849 Reviewed-by: Jordan Bayles <jophba@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2019-12-10Revert "Upgrade Mac bot to 10.15, to auto-upgrade compiler/toolchain."Jordan Bayles
This reverts commit 1a5032f91662568ed3fec6da12e747838914cf58. Reason for revert: LUCI trybots only support 10.13, so unforunately this won't work as of this time. Original change's description: > Upgrade Mac bot to 10.15, to auto-upgrade compiler/toolchain. > > Bug: openscreen:86 > Change-Id: I6eaca1e376dedb509be3c3009b0c33cce322647e > Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1954824 > Reviewed-by: Jordan Bayles <jophba@chromium.org> > Commit-Queue: Jordan Bayles <jophba@chromium.org> TBR=miu@chromium.org,jophba@chromium.org Change-Id: I213a12dd4f1d93a5e7dd30138c3575a9c049daf4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: openscreen:86 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1959587 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2019-12-09Upgrade Mac bot to 10.15, to auto-upgrade compiler/toolchain.Yuri Wiitala
Bug: openscreen:86 Change-Id: I6eaca1e376dedb509be3c3009b0c33cce322647e Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1954824 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2019-10-21[Open Screen] Add scheduler for linux64_gcc_debug.mark a. foltz
Adds a missing scheduler config. Bug: openscreen:40 Change-Id: I6fe2557c8cd881d5e460fed01781723ca059096a Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1872543 Reviewed-by: Brandon Tolsch <btolsch@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org>
2019-10-16[Open Screen] Add linux64_gcc_debug to the LUCI waterfall page.mark a. foltz
This adds linux64_gcc_debug to the LUCI waterfall page. Bug: openscreen:40 Change-Id: I17fe1f4a8ca89fac60bc4a3f5975d6ea1eef5c20 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1860997 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org>
2019-08-29Add gcc try bot as experimentalbtolsch
This change re-enables the gcc try bot but on ubuntu 18.04 (for gcc 8) and marks it as experimental, meaning it will be run every time other try bots are run but its output won't influence CQ pass/fail status). Bug: openscreen:40 Change-Id: Ia32901643c681cb7efd31f43028c46fe050af124 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1776597 Reviewed-by: Max Yakimakha <yakimakha@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2019-08-23Add optional chromium try jobsbtolsch
This change copies the current chromium FYI CI bots into try bots and marks them as "experimental". This will let them run as try bots but not consider their success/failure as part of the CQ. Change-Id: I67ba7e766a2a9f28516ad2957bc30f3505ea66e9 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1769474 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org>
2019-08-21Remove gcc botsbtolsch
This change removes our test support for gcc for the following reasons: 1. Building on gcc 8 doesn't work and doesn't appear to be trivial to fix. This means local builds with gcc don't work, and upgrading our bots will break gcc support without fixes. 2. We aren't required to support gcc to build in Chromium. 3. In addition to missing flags and features due to the older version on the bots, there has also been a mysterious crash that also doesn't repro locally. Given these reasons, gcc is costing more than it's helping at this point. This change doesn't remove the is_gcc flag from the GN files or the bot recipe though, so it can continue to be improved in the background if that ends up being desirable. Bug: openscreen:40 Change-Id: I41142cb4370f469e0c8d185a49968b25f1d032ee Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1762533 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Max Yakimakha <yakimakha@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
2019-08-16Add tsan trybotbtolsch
This change adds a tsan trybot now that the CI bot has had a chance to run and succeed. Bug: openscreen:54 Change-Id: Ia33b578f7ea9acab79bd5cae3f6f70ffec9a1d68 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1745594 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by: Max Yakimakha <yakimakha@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org>
2019-08-08Add scheduler config for tsan botbtolsch
This change adds a scheduler trigger for the tsan CI bot to actually run. Bug: openscreen:54 Change-Id: I9aec55df28d207d37b3782da32674c7f3e696701 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1742809 Reviewed-by: Max Yakimakha <yakimakha@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
2019-08-07Add tsan CI botbtolsch
This change adds a bot running the is_tsan=true configuration. It deliberately doesn't add a trybot. A trybot will be added after we can confirm that HEAD is stable with tsan, since we haven't been developing with it up to this point. Bug: openscreen:54 Change-Id: Ib2df23a41c0544dc00390ba2c88a37e1489b9450 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1742645 Reviewed-by: Ryan Keane <rwkeane@google.com> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
2019-07-22Revert "Add config to test 18.04 try bots"Brandon Tolsch
This reverts commit c8bda28451bdce5cb5f02c1093d94e52ed0b46d3. Reason for revert: noexcept causing problems w/ and w/o -Wno-noexcept-type (for different reasons) and no apparent short-term fix. Original change's description: > Add config to test 18.04 try bots > > There is now an 18.04 bot in luci.flex.try that we can use. If we make > sure it works for our repo, they should also be adding one to > luci.flex.ci. > > Bug: openscreen:40 > Change-Id: I077ea916c10adc6cf5a6560d944f4d62a2849974 > Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1710958 > Reviewed-by: Max Yakimakha <yakimakha@chromium.org> > Commit-Queue: Brandon Tolsch <btolsch@chromium.org> TBR=btolsch@chromium.org,jophba@chromium.org,rwkeane@google.com,yakimakha@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: openscreen:40 Change-Id: Ibcb5028a666bdddeea1356abaaef7e9d72876855 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1713567 Reviewed-by: Brandon Tolsch <btolsch@chromium.org> Reviewed-by: Max Yakimakha <yakimakha@chromium.org>
2019-07-21Add config to test 18.04 try botsbtolsch
There is now an 18.04 bot in luci.flex.try that we can use. If we make sure it works for our repo, they should also be adding one to luci.flex.ci. Bug: openscreen:40 Change-Id: I077ea916c10adc6cf5a6560d944f4d62a2849974 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1710958 Reviewed-by: Max Yakimakha <yakimakha@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
2019-06-24Change chromium bots to trigger on chromium treebtolsch
Originally, we planned to have the chromium fyi bots only run for each new openscreen commit, but against chromium HEAD. The checked-in gclient config for the chromium recipe isn't intended for that though, as it was copied from v8's config. This results in the bots not finding a valid repo URL when they are triggered. I believe the two ways to fix this are: 1. Trigger on the chromium tree instead, so the bot is technically getting a chromium trigger, but then openscreen is set to HEAD by the current config in //s/s/r/chromium/gclient_config.py. 2. Change the config in //s/s/r/chromium/gclient_config.py to rewrite the gclient solution for the current trigger. It's unclear how to do this at the moment. This change takes approach 1 since, in addition to being easier, it has the added benefit of tracking our compile status in chromium without openscreen even changing. Bug: 951615 Change-Id: Ib34ffdf0ffb1f8abd5205b53348c93d8ba066194 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1674390 Reviewed-by: Max Yakimakha <yakimakha@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
2019-06-19Add chromium downstream bots for FYIbtolsch
This change adds CI bots that run the chromium_downstream recipe to try building the current openscreen revision as part of a Chromium checkout. These will not be added as try bots or as part of the CQ and instead just serve an FYI role. Change-Id: I99973501b82daa81922431b5fbdcf704d5b2e0b5 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1612183 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
2019-06-19Revert "Bump linux bot to Ubuntu 17.04"Brandon Tolsch
This reverts commit abe6e554908f1d868ab53033d499060e1765f4c1. Reason for revert: luci.flex.ci has 17.04, but luci.flex.try does not. Original change's description: > Bump linux bot to Ubuntu 17.04 > > Bug: openscreen:40 > Change-Id: If534f1fd489d34ed7a3fd0402d7c133164513ef4 > Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1666459 > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Commit-Queue: Brandon Tolsch <btolsch@chromium.org> TBR=mfoltz@chromium.org,miu@chromium.org,btolsch@chromium.org Change-Id: I2f97966d0ce5d5ca79b1547b380c78042e8c582c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: openscreen:40 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1666257 Reviewed-by: Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
2019-06-19Bump linux bot to Ubuntu 17.04btolsch
Bug: openscreen:40 Change-Id: If534f1fd489d34ed7a3fd0402d7c133164513ef4 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1666459 Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
2019-06-12Fix MILO bot namesbtolsch
luci-milo.cfg was incorrectly set to show the CI versions of two bots under the TRY category. This change points all links under the TRY group to actual try bots. Change-Id: I0b8e8f67052bd459b44a87d982f34635c90f0d46 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1656292 Reviewed-by: Max Yakimakha <yakimakha@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org>
2019-04-18Reland "Improve presubmit support"btolsch
This version renames the presubmit bot to openscreen_presubmit based on the standard bot naming the configuration prefers. This is a reland of f0be9de6149a73efbd98506541a6758c970f1b0f Original change's description: > Improve presubmit support > > This change improves our presubmit in two ways: > 1. It adds our PRESUBMIT.sh as a step in PRESUBMIT.py which is normally > run by git-cl commands. > 2. Adds a presubmit bot which runs our PRESUBMIT.py as part of the > commit queue. > > Moving the PRESUBMIT.sh checks into python or adding other checks will > be left to future CLs. > > Bug: openscreen:43 > Change-Id: I7d95fe92b9b6c715344bc65868cd1eb91e7be643 > Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1570449 > Commit-Queue: Brandon Tolsch <btolsch@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> TBR=mfoltz@chromium.org Bug: openscreen:43 Change-Id: I854d7fae53dcc888b4918acb24ad3db3826f509a Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1575005 Reviewed-by: Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
2019-04-18Revert "Improve presubmit support"Brandon Tolsch
This reverts commit f0be9de6149a73efbd98506541a6758c970f1b0f. Reason for revert: presubmit recipe is failing for an unknown reason, reverting until I can get more info from the infra team. Original change's description: > Improve presubmit support > > This change improves our presubmit in two ways: > 1. It adds our PRESUBMIT.sh as a step in PRESUBMIT.py which is normally > run by git-cl commands. > 2. Adds a presubmit bot which runs our PRESUBMIT.py as part of the > commit queue. > > Moving the PRESUBMIT.sh checks into python or adding other checks will > be left to future CLs. > > Bug: openscreen:43 > Change-Id: I7d95fe92b9b6c715344bc65868cd1eb91e7be643 > Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1570449 > Commit-Queue: Brandon Tolsch <btolsch@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> TBR=mfoltz@chromium.org,btolsch@chromium.org Change-Id: Ie7cf7688a74ee5168767428e48b5aeb4cdb00965 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: openscreen:43 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1573270 Reviewed-by: Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
2019-04-18Improve presubmit supportbtolsch
This change improves our presubmit in two ways: 1. It adds our PRESUBMIT.sh as a step in PRESUBMIT.py which is normally run by git-cl commands. 2. Adds a presubmit bot which runs our PRESUBMIT.py as part of the commit queue. Moving the PRESUBMIT.sh checks into python or adding other checks will be left to future CLs. Bug: openscreen:43 Change-Id: I7d95fe92b9b6c715344bc65868cd1eb91e7be643 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1570449 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
2019-04-10Add x86-64 dimension to bot requirementsbtolsch
Bug: 949424 Change-Id: I35dcac60076c0c4d4e2d3f4161cfb6d94e8ab38e Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1560387 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org>
2019-04-03Re-enable the mac_debug builder for the openscreen CQ.mark a. foltz
TBR=rwkeane@chromium.org Change-Id: I6b9775599008d9bdc3bb6acb2fecd808c7f5ab9d Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1552302 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org>
2019-04-03Update openscreen mac builds to target 10.13.6 instead of 10.13.4Ben Pastene
All of our 10.13 mac bots are in the process of being upgraded to 10.13.6. Bug: 948429 Change-Id: I9bec3594facb855bc6bbd3a2125bf805f65f5539 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1548638 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-16 18:36:25 +0000