| Age | Commit message (Collapse) | Author |
|---|
|
This patch fixes various issues found through `gn check` throughout the
repository, including some fuzzing issues.
Bug: b/155434332
Change-Id: I2dffa42f5dfd291a7c59653eb7ca16ec680bfddb
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/2964569
Reviewed-by: Ryan Keane <rwkeane@google.com>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
|
|
This change makes gmock depend on gtest to be consistent with both
Chromium and the upstream build. I hit this problem locally as linker
errors if code _never_ ends up including gtest but include gmock since
gmock does use gtest. We don't have any existing instances of this
(including `gn check`) that I could find.
Bug: None
Change-Id: If8304d2c6c7d6657edde873e77b4ab88d9efb070
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1970502
Reviewed-by: Ryan Keane <rwkeane@google.com>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
|
|
This patch contains preparation for running Open Screen unit tests in
Chrome, as well as successfully linking in the Chrome platform
implementation for Open Screen's platform target.
See the follow up patch here:
https://chromium-review.googlesource.com/c/chromium/src/+/1880544
Change-Id: I32c1bd728a43c5dbe155bcaa11527ad275c6b871
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1887717
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
|
|
Put crbug URLs in TODOs to make it easier to open the bug pages.
Change-Id: Ibc8fce98a795d7e8c714627bf1ecd970a3865563
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1872176
Reviewed-by: Max Yakimakha <yakimakha@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
|
|
1. Removes a couple of clang-specific flags from the gcc build.
2. Adds -Wno-noexcept-type to the gcc build.
Regarding #2:
Methods passing platform::api::Task were triggering noexcept warnings on gcc (check the
waterfall for examples).
However, after reviewing options, there does not seem to be a straightforward and
typesafe fix possible while maintaining the current TaskRunner APIs. Either we would
need to remove noexcept from platform::api::Task, or add extra template parameters to
specialize Task-passing methods.
The gcc bots are running Bionic Beaver, which defaults to gcc 7. Locally, the compilation
errors do not reproduce with gcc 8.3, leading me to believe that these were removed for this
specific case between gcc 7 and gcc 8. (I will try to hunt down documentation
if that is the case.)
I believe this is a reasonable solution until we can get bots upgraded to gcc 8.3.
Bug: openscreen:40
Change-Id: Ic4b0ee95a204319e3c85e7fef3dcbcdde4e0e5a7
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1857468
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Ryan Keane <rwkeane@google.com>
Reviewed-by: Max Yakimakha <yakimakha@chromium.org>
|
|
This change makes a few more incremental changes to keep Chromium
compilation compatibility so we can try to land the compilation
upstream.
Bug: 951615
Change-Id: I69fc9f074268657c4fbef46c57775d9b985cc8e6
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1580361
Reviewed-by: Ryan Keane <rwkeane@google.com>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
|
|
This change updates various BUILD.gn files to work in both standalone
builds and Chromium builds. There are several main changes that have to
take place:
1. Change abseil include paths so we can use any abseil location.
2. Change logging macros to use Chromium's //base/logging.h.
3. Separate out files with the GN variable build_with_chromium.
4. Add a new config to each target to maintain our include structure
and change over the logging macros.
Change-Id: I066698cd07b2315842c700b5adf01bdc656db9be
Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/1534469
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Peter Thatcher <pthatcher@google.com>
Reviewed-by: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
|
|
This patch removes our dependency on submodules, in favor of using
Chromium's gclient tool for managing depedencies. Although this is less
standard, the value add is that it will make integrating with Chromium
easier.
See also:
https://chromium-review.googlesource.com/c/chromium/tools/build/+/1484793
Change-Id: Ib6999768c0164c952d5dc139adb391a29ee70b3d
Reviewed-on: https://chromium-review.googlesource.com/c/1484794
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
|
|
1. Refactors the BUILDCONFIG-related files to allow for building on both
Linux and Mac (and leaves open the possibility for other platforms in
the future). Much of the new LOC are borrowed from the main Chromium
project. Also, ran `gn format` on all the touched BUILD.gn files.
2. Added Mac LLVM toolchain definitions. With this, almost everything
compiles on Mac. Upcoming changes will address this.
3. Increased strictness of compiler flags to match Chromium C++
standards. This includes: Disabling C++ exceptions and RTTI, disallowing
exit-time destructors, and enabling all warning flags except for a few.
For third-party code, some warnings have been disabled to allow them to
build. Some of the increased strictness is only enforced when building
with LLVM, not GCC.
4. While working on third_party/chromium_quic/build/base/BUILD.gn, it
was noticed that the allocator shim defined there was enabled. Since a
well-behaved library should not attempt to override malloc(), I've
disabled that.
5. Added miu@chromium.org to AUTHORS. Hi! :)
Change-Id: I1a3dd43bfc34dea5c3d62f2d7745b80a8020612f
Reviewed-on: https://chromium-review.googlesource.com/c/1308455
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
|
|
- Fix typo in #include guard.
- GMock does not add the 'override' keyword when mocking pure virtual methods (ref:
https://github.com/google/googletest/issues/533). This looks unlikely to be fixed
anytime soon, so suppress this warning.
Bug: openscreen:15
Change-Id: I54ae3c87b4a4aed8907fac9d3a63f2fd78900327
Reviewed-on: https://chromium-review.googlesource.com/1195590
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
|
|
Change-Id: I39d0b92b6edc3ff9b1e9e722d03cdc18ab7504d6
Reviewed-on: https://chromium-review.googlesource.com/978873
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
|
