diff options
| author | jonathanmetzman <31354670+jonathanmetzman@users.noreply.github.com> | 2021-07-28 07:25:59 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-07-28 07:25:59 -0700 |
| commit | 2dda5eedef1433dbfe47c280533d12af026f2577 (patch) | |
| tree | 026cd71c789af38700f682db55828b62a398d206 | |
| parent | 89da7cffced60508fa0f787465279ddf6a042a01 (diff) | |
| download | oss-fuzz-2dda5eedef1433dbfe47c280533d12af026f2577.tar.gz | |
[CIFuzz][NFC] Fix some comments. (#6130)
| -rw-r--r-- | infra/cifuzz/affected_fuzz_targets.py | 1 | ||||
| -rw-r--r-- | infra/cifuzz/build_fuzzers.py | 7 | ||||
| -rw-r--r-- | infra/cifuzz/get_coverage.py | 6 |
3 files changed, 9 insertions, 5 deletions
diff --git a/infra/cifuzz/affected_fuzz_targets.py b/infra/cifuzz/affected_fuzz_targets.py index 22924bbc8..be35c5cc5 100644 --- a/infra/cifuzz/affected_fuzz_targets.py +++ b/infra/cifuzz/affected_fuzz_targets.py @@ -27,6 +27,7 @@ def remove_unaffected_fuzz_targets(clusterfuzz_deployment, out_dir, """Removes all non affected fuzz targets in the out directory. Args: + clusterfuzz_deployment: The ClusterFuzz deployment object. out_dir: The location of the fuzz target binaries. files_changed: A list of files changed compared to HEAD. repo_path: The location of the OSS-Fuzz repo in the docker image. diff --git a/infra/cifuzz/build_fuzzers.py b/infra/cifuzz/build_fuzzers.py index 7831e0bf8..09d7c56cb 100644 --- a/infra/cifuzz/build_fuzzers.py +++ b/infra/cifuzz/build_fuzzers.py @@ -190,11 +190,14 @@ def check_fuzzer_build(workspace, """Checks the integrity of the built fuzzers. Args: - out_dir: The directory containing the fuzzer binaries. + workspace: The workspace used by CIFuzz. sanitizer: The sanitizer the fuzzers are built with. + language: The programming language the fuzzers are written in. + allowed_broken_targets_percentage (optional): A custom percentage of broken + targets to allow. Returns: - True if fuzzers are correct. + True if fuzzers pass OSS-Fuzz's build check. """ if not os.path.exists(workspace.out): logging.error('Invalid out directory: %s.', workspace.out) diff --git a/infra/cifuzz/get_coverage.py b/infra/cifuzz/get_coverage.py index f674e9553..a022e838e 100644 --- a/infra/cifuzz/get_coverage.py +++ b/infra/cifuzz/get_coverage.py @@ -44,7 +44,7 @@ class BaseCoverage: target: The name of the fuzz target whose coverage is requested. Returns: - A list of files that the fuzz targets covers or None. + A list of files that the fuzz target covers or None. """ raise NotImplementedError('Child class must implement method.') @@ -83,7 +83,7 @@ class OSSFuzzCoverage(BaseCoverage): target: The name of the fuzz target whose coverage is requested. Returns: - A list of files that the fuzz targets covers or None. + A list of files that the fuzz target covers or None. """ target_cov = self.get_target_coverage_report(target) if not target_cov: @@ -165,7 +165,7 @@ class FilesystemCoverage(BaseCoverage): target: The name of the fuzz target whose coverage is requested. Returns: - A list of files that the fuzz targets covers or None. + A list of files that the fuzz target covers or None. """ # TODO(jonathanmetzman): Implement this. raise NotImplementedError('Implementation TODO.') |