diff options
| author | Oliver Chang <oliverchang@users.noreply.github.com> | 2020-04-15 08:59:33 +1000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-04-15 08:59:33 +1000 |
| commit | 0399965d7e4f385739c67ce1e6f1678f5b56d9b7 (patch) | |
| tree | 3b22207b3f0df6ee838a5c8b987b127514dab406 /infra/bisector.py | |
| parent | 896ed726e28f8b540f8331cdbe1fccf135796343 (diff) | |
| download | oss-fuzz-0399965d7e4f385739c67ce1e6f1678f5b56d9b7.tar.gz | |
Allow bisecting with no old commit. (#3641)
Fixes #3598.
Diffstat (limited to 'infra/bisector.py')
| -rw-r--r-- | infra/bisector.py | 32 |
1 files changed, 16 insertions, 16 deletions
diff --git a/infra/bisector.py b/infra/bisector.py index fdb078b3d..ed7e87cf4 100644 --- a/infra/bisector.py +++ b/infra/bisector.py @@ -55,8 +55,7 @@ def main(): help='The newest commit SHA to be bisected.', required=True) parser.add_argument('--old_commit', - help='The oldest commit SHA to be bisected.', - required=True) + help='The oldest commit SHA to be bisected.') parser.add_argument('--fuzz_target', help='The name of the fuzzer to be built.', required=True) @@ -111,7 +110,7 @@ def bisect(old_commit, new_commit, test_case_path, fuzz_target, build_data): # """ with tempfile.TemporaryDirectory() as tmp_dir: repo_url, repo_path = build_specified_commit.detect_main_repo( - build_data.project_name, commit=old_commit) + build_data.project_name, commit=new_commit) if not repo_url or not repo_path: raise ValueError('Main git repo can not be determined.') @@ -120,7 +119,7 @@ def bisect(old_commit, new_commit, test_case_path, fuzz_target, build_data): # bisect_repo_manager = repo_manager.RepoManager( repo_url, host_src_dir, repo_name=os.path.basename(repo_path)) - commit_list = bisect_repo_manager.get_commit_list(old_commit, new_commit) + commit_list = bisect_repo_manager.get_commit_list(new_commit, old_commit) old_idx = len(commit_list) - 1 new_idx = 0 logging.info('Testing against new_commit (%s)', commit_list[new_idx]) @@ -132,18 +131,19 @@ def bisect(old_commit, new_commit, test_case_path, fuzz_target, build_data): # test_case_path) # Check if the error is persistent through the commit range - logging.info('Testing against old_commit (%s)', commit_list[old_idx]) - build_specified_commit.build_fuzzers_from_commit( - commit_list[old_idx], - bisect_repo_manager, - host_src_dir, - build_data, - ) - - if expected_error_code == helper.reproduce_impl(build_data.project_name, - fuzz_target, False, [], [], - test_case_path): - return commit_list[old_idx] + if old_commit: + logging.info('Testing against old_commit (%s)', commit_list[old_idx]) + build_specified_commit.build_fuzzers_from_commit( + commit_list[old_idx], + bisect_repo_manager, + host_src_dir, + build_data, + ) + + if expected_error_code == helper.reproduce_impl(build_data.project_name, + fuzz_target, False, [], + [], test_case_path): + return commit_list[old_idx] while old_idx - new_idx > 1: curr_idx = (old_idx + new_idx) // 2 |