diff options
Diffstat (limited to 'infra/presubmit.py')
| -rwxr-xr-x | infra/presubmit.py | 22 |
1 files changed, 19 insertions, 3 deletions
diff --git a/infra/presubmit.py b/infra/presubmit.py index 54c0efc23..7be16a80f 100755 --- a/infra/presubmit.py +++ b/infra/presubmit.py @@ -74,7 +74,7 @@ class ProjectYamlChecker: SECTIONS_AND_CONSTANTS = { 'sanitizers': {'address', 'none', 'memory', 'undefined', 'dataflow'}, 'architectures': {'i386', 'x86_64'}, - 'fuzzing_engines': {'afl', 'libfuzzer', 'honggfuzz', 'dataflow'} + 'fuzzing_engines': {'afl', 'libfuzzer', 'honggfuzz', 'dataflow'}, } # Note: this list must be updated when we allow new sections. @@ -89,8 +89,11 @@ class ProjectYamlChecker: 'sanitizers', 'vendor_ccs', 'view_restrictions', + 'language', ] + LANGUAGES_SUPPORTED = ['c', 'cpp', 'go', 'rust', 'python'] + # Note that some projects like boost only have auto-ccs. However, forgetting # primary contact is probably a mistake. REQUIRED_SECTIONS = ['primary_contact'] @@ -108,8 +111,11 @@ class ProjectYamlChecker: return True checks = [ - self.check_project_yaml_constants, self.check_required_sections, - self.check_valid_section_names, self.check_valid_emails + self.check_project_yaml_constants, + self.check_required_sections, + self.check_valid_section_names, + self.check_valid_emails, + self.check_valid_language, ] for check_function in checks: check_function() @@ -179,6 +185,16 @@ class ProjectYamlChecker: if '@' not in email_address or '.' not in email_address: self.error(email_address + ' is an invalid email address.') + def check_valid_language(self): + """Check that the language specified is valid.""" + language = self.data.get('language') + if not language: + return + + if language not in self.LANGUAGES_SUPPORTED: + self.error('{language} is not supported ({supported}).'.format( + language=language, supported=self.LANGUAGES_SUPPORTED)) + def _check_one_project_yaml(project_yaml_filename): """Do checks on the project.yaml file.""" |