summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorExE Boss <ExE-Boss@code.ExE-Boss.tech>2022-09-07 07:50:00 +0000
committerExE Boss <ExE-Boss@code.ExE-Boss.tech>2022-09-07 07:52:26 +0000
commitbe2b87ecedb3a3a2daefca432996c342fa406c76 (patch)
treec6417dca3fa8acba16029f2a1de4b0679f8f2305
parentb06844ff06740ccdbb7e24a898afa6530f1b66a1 (diff)
downloadow2-asm-be2b87ecedb3a3a2daefca432996c342fa406c76.tar.gz
fixup! Fix `SignatureWriter` when a generic type has a depth over 30
-rw-r--r--asm/src/main/java/org/objectweb/asm/signature/SignatureWriter.java2
-rw-r--r--asm/src/test/java/org/objectweb/asm/signature/SignatureWriterTest.java10
2 files changed, 8 insertions, 4 deletions
diff --git a/asm/src/main/java/org/objectweb/asm/signature/SignatureWriter.java b/asm/src/main/java/org/objectweb/asm/signature/SignatureWriter.java
index 327521af..c834eef0 100644
--- a/asm/src/main/java/org/objectweb/asm/signature/SignatureWriter.java
+++ b/asm/src/main/java/org/objectweb/asm/signature/SignatureWriter.java
@@ -250,7 +250,7 @@ public class SignatureWriter extends SignatureVisitor {
return (argumentStack & 1) == 1;
}
- private void pushArgStack(boolean state) {
+ private void pushArgStack(final boolean state) {
if (argumentStackDepth > 0 && (argumentStackDepth % 32) == 0) {
if (deepArgStack == null) {
deepArgStack = new ArrayList<>(5);
diff --git a/asm/src/test/java/org/objectweb/asm/signature/SignatureWriterTest.java b/asm/src/test/java/org/objectweb/asm/signature/SignatureWriterTest.java
index e9aefa62..6d037ce6 100644
--- a/asm/src/test/java/org/objectweb/asm/signature/SignatureWriterTest.java
+++ b/asm/src/test/java/org/objectweb/asm/signature/SignatureWriterTest.java
@@ -70,19 +70,23 @@ class SignatureWriterTest extends AsmTest {
@ParameterizedTest
@MethodSource("deepSignatures")
- void testWrite_deepSignature(int depth) {
+ void testWrite_deepSignature(final int depth) {
SignatureWriter signatureWriter = new SignatureWriter();
String expected = writeDeepSignature(signatureWriter, depth);
assertEquals(expected, signatureWriter.toString(), "depth=" + depth);
}
- private String writeDeepSignature(SignatureVisitor signatureVisitor, int maxDepth) {
+ private String writeDeepSignature(final SignatureVisitor signatureVisitor, final int maxDepth) {
StringBuilder expected = new StringBuilder();
writeDeepSignatureInner(signatureVisitor, expected, 0, maxDepth);
return expected.toString();
}
- private void writeDeepSignatureInner(SignatureVisitor signatureVisitor, StringBuilder expected, int currentDepth, int maxDepth) {
+ private void writeDeepSignatureInner(
+ final SignatureVisitor signatureVisitor,
+ final StringBuilder expected,
+ final int currentDepth,
+ final int maxDepth) {
signatureVisitor.visitClassType(TEST_GENERIC);
expected.append('L' + TEST_GENERIC);
if (currentDepth < maxDepth) {