aboutsummaryrefslogtreecommitdiff
path: root/core/fpdfdoc
diff options
context:
space:
mode:
authorTom Sepez <tsepez@chromium.org>2019-11-25 18:53:06 +0000
committerChromium commit bot <commit-bot@chromium.org>2019-11-25 18:53:06 +0000
commit09577266dfd569e3b40919f697127802277c11e3 (patch)
tree1b46ca8607fa9411fc796f34bc710e75b445b9a3 /core/fpdfdoc
parent473c98364ffad9454bffd1d5fbb39bbfe97a8658 (diff)
downloadpdfium-09577266dfd569e3b40919f697127802277c11e3.tar.gz
Improve embedder test coverage of FPDFBookmark_GetDest()/GetAction().
Pass an actual object instead of nullptr. - Remove uncalled method. - Remove duplicate nullptr test case. - Move buffer decls to first line of test since it looks better. Change-Id: Icb006f26040efb575d1ab84e05c55c43f0f0b26d Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/62690 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org>
Diffstat (limited to 'core/fpdfdoc')
-rw-r--r--core/fpdfdoc/cpdf_bookmark.cpp4
-rw-r--r--core/fpdfdoc/cpdf_bookmark.h1
2 files changed, 0 insertions, 5 deletions
diff --git a/core/fpdfdoc/cpdf_bookmark.cpp b/core/fpdfdoc/cpdf_bookmark.cpp
index 96752af5f..b08fba586 100644
--- a/core/fpdfdoc/cpdf_bookmark.cpp
+++ b/core/fpdfdoc/cpdf_bookmark.cpp
@@ -24,10 +24,6 @@ CPDF_Bookmark::CPDF_Bookmark(const CPDF_Dictionary* pDict) : m_pDict(pDict) {}
CPDF_Bookmark::~CPDF_Bookmark() = default;
-uint32_t CPDF_Bookmark::GetFontStyle() const {
- return m_pDict ? m_pDict->GetIntegerFor("F") : 0;
-}
-
WideString CPDF_Bookmark::GetTitle() const {
if (!m_pDict)
return WideString();
diff --git a/core/fpdfdoc/cpdf_bookmark.h b/core/fpdfdoc/cpdf_bookmark.h
index 400b869e3..b185c0374 100644
--- a/core/fpdfdoc/cpdf_bookmark.h
+++ b/core/fpdfdoc/cpdf_bookmark.h
@@ -24,7 +24,6 @@ class CPDF_Bookmark {
const CPDF_Dictionary* GetDict() const { return m_pDict.Get(); }
- uint32_t GetFontStyle() const;
WideString GetTitle() const;
CPDF_Dest GetDest(CPDF_Document* pDocument) const;
CPDF_Action GetAction() const;