diff options
| author | Tom Craig <tommycraig@gmail.com> | 2022-04-02 21:12:09 -0700 |
|---|---|---|
| committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-04-04 16:37:58 +0000 |
| commit | 507dcae2bf64868ae2db9c14fe90b0607ddb96e3 (patch) | |
| tree | 29ab20c233be6a824431ccb935d3d997c737af02 | |
| parent | 3e8e339edd764787269ec9a374b2d9c895420334 (diff) | |
| download | pigweed-507dcae2bf64868ae2db9c14fe90b0607ddb96e3.tar.gz | |
pw_system: Remove header visibility restrictions
Removes visibility restrictions on rules exposing public headers.
Previously, a user had to depend on the top-level pw_system GN group
to get some headers, however this could cause dependency cycles.
For example, if a user application injects a
pw_system_TARGET_HOOKS_BACKED which in turn depends on
pw_system/rpc_server.h, then previously we'd end up with a dependency
cycle like:
pw_system -> init -> target_hooks -> pw_system_TARGET_HOOKS_BACKEND
-> pw_system (becomes rpc_server with this change).
Change-Id: Ibc52afa4a76fabe1ed4e6358faec518e97c959ae
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89780
Reviewed-by: Armando Montanez <amontanez@google.com>
Commit-Queue: Armando Montanez <amontanez@google.com>
| -rw-r--r-- | pw_system/BUILD.gn | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/pw_system/BUILD.gn b/pw_system/BUILD.gn index 85ee99e37..089fbd1e2 100644 --- a/pw_system/BUILD.gn +++ b/pw_system/BUILD.gn @@ -102,7 +102,6 @@ pw_source_set("log_backend.impl") { pw_facade("rpc_server") { backend = pw_system_RPC_SERVER_BACKEND - visibility = [ ":*" ] public = [ "public/pw_system/rpc_server.h" ] public_configs = [ ":public_include_path" ] public_deps = [ @@ -113,7 +112,6 @@ pw_facade("rpc_server") { pw_facade("io") { backend = pw_system_IO_BACKEND - visibility = [ ":*" ] public_configs = [ ":public_include_path" ] public = [ "public/pw_system/io.h" ] public_deps = [ "$dir_pw_stream" ] @@ -148,7 +146,6 @@ pw_source_set("hdlc_rpc_server") { } pw_source_set("work_queue") { - visibility = [ ":*" ] public_configs = [ ":public_include_path" ] public = [ "public/pw_system/work_queue.h" ] sources = [ "work_queue.cc" ] |