soong: Remove host/vendor properties from defaults

The `vendor_available` property indicates that the module in question
may be linked by a vendor module, while `host_supported` allows a host
variant of the module to be built.

For concrete targets like libraries, these properties are very useful in
that they expand the configurations in which the module can be used.
However, the opposite effect occurs when set as part of `cc_defaults`
since these properties are now inherited by the including module and can
conflict with or restrict choices within that module.

One concrete example is the case of trying to build a vendor module that
incorporates a `cc_defaults` with these properties set. This will result
in a build break because it is not permissible to set both `vendor` and
`vendor_available` to true.

Another example is a module incorporating such a default while also
linking a library that was not built with `host_available`. This results
in a build break, because the parent module has inherited the
`host_available` property from the defaults, but it relies on modules
that are not host available.

Finally, note that even if these properties are not included in the
pigweed `cc_defaults`, the module including those defaults is still free
to set these properties as desired. Since there is no advantage to
setting these properties within pigweed `cc_defaults` and a number of
drawbacks, they should be removed.

Test: Full `m` build in Android environment
Change-Id: I5a050f6bb6d098bd46dd1a12542a3429aa8be796
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/165270
Reviewed-by: Carlos Chinchilla <cachinchilla@google.com>
Commit-Queue: Andrew Harper <aharp@google.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Victor Berchet <berchet@google.com>

1 files changed, 0 insertions, 2 deletions

diff --git a/pw_log_basic/Android.bp b/pw_log_basic/Android.bp
index 60a316d22..69fb19f8c 100644
--- a/pw_log_basic/Android.bp
+++ b/pw_log_basic/Android.bp
@@ -36,6 +36,4 @@ cc_defaults {
     export_header_lib_headers: [
       "pw_log_basic_include_dirs",
     ],
-    vendor_available: true,
-    host_supported: true,
 }
\ No newline at end of file