aboutsummaryrefslogtreecommitdiff
path: root/pw_tokenizer/base64_test.cc
diff options
context:
space:
mode:
authorWyatt Hepler <hepler@google.com>2020-10-22 17:51:02 -0700
committerCQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>2020-10-27 16:16:46 +0000
commit26632bc2dcb4df8f73022d1d0c8eb99152be8d41 (patch)
tree6eb8811eba14c74c9b8f6e53bb8c16c4f3b4fd43 /pw_tokenizer/base64_test.cc
parent05b48dfda3205af60e9cef453fc4463e3ebfeabe (diff)
downloadpigweed-26632bc2dcb4df8f73022d1d0c8eb99152be8d41.tar.gz
pw_tokenizer: Remove the Vector overload for Base64 encoding
pw::Vector is not the right abstraction for this because it doesn't guarantee that the null terminator after size() bytes stays when the pw::Vector is copied. Bug: 285 Change-Id: I76580d612c189b8c5a574e02a280427e0329ff53 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/22157 Reviewed-by: Armando Montanez <amontanez@google.com> Commit-Queue: Wyatt Hepler <hepler@google.com>
Diffstat (limited to 'pw_tokenizer/base64_test.cc')
-rw-r--r--pw_tokenizer/base64_test.cc24
1 files changed, 0 insertions, 24 deletions
diff --git a/pw_tokenizer/base64_test.cc b/pw_tokenizer/base64_test.cc
index fbbd06412..d751b8ee1 100644
--- a/pw_tokenizer/base64_test.cc
+++ b/pw_tokenizer/base64_test.cc
@@ -99,30 +99,6 @@ TEST_F(PrefixedBase64, Encode_NoRoomForNullAfterMessage_OnlyNullTerminates) {
EXPECT_EQ(kUnset, base64_[1]);
}
-TEST_F(PrefixedBase64, EncodeToVector_EmptyInput_WritesPrefix) {
- auto buffer = PrefixedBase64Encode(std::span<byte>());
- ASSERT_EQ(1u, buffer.size());
- EXPECT_EQ('$', buffer[0]);
- EXPECT_EQ('\0', buffer[1]);
-}
-
-TEST_F(PrefixedBase64, EncodeToVector_Successful) {
- auto buffer = PrefixedBase64Encode(kTestData[5].binary);
- ASSERT_EQ(buffer.size(), kTestData[5].base64.size());
- EXPECT_EQ(
- 0, std::memcmp(buffer.data(), kTestData[5].base64.data(), buffer.size()));
- EXPECT_EQ('\0', buffer[buffer.size()]);
-}
-
-TEST_F(PrefixedBase64, EncodeToVector_VectorTooSmall_OnlyNullTerminates) {
- constexpr byte big[Base64EncodedBufferSize(
- PW_TOKENIZER_CFG_ENCODING_BUFFER_SIZE_BYTES + 1)] = {};
-
- auto buffer = PrefixedBase64Encode(big);
- ASSERT_EQ(0u, buffer.size());
- EXPECT_EQ('\0', buffer[0]);
-}
-
TEST_F(PrefixedBase64, Base64EncodedBufferSize_Empty_RoomForPrefixAndNull) {
EXPECT_EQ(2u, Base64EncodedBufferSize(0));
}