aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-04-28Snap for 8512216 from 40fbb41c00454895867d7ae5d3ba20e3111073ba to ↵t_frc_adb_330444000android13-frc-adbd-releaseAndroid Build Coastguard Worker
tm-frc-adbd-release Change-Id: I2e718339981b7de92a81a9f21853e4f058a4f8ad
2022-04-05Merge remote-tracking branch 'goog/upstream-main' into synct_frc_odp_330442040t_frc_odp_330442000t_frc_ase_330444010android13-frc-odp-releaseAnthony Stange
Bug: 210138227 Test: presubmits Change-Id: I0c2ea271a28bb3b7543b99054f1d83fd0abc7faf
2022-04-05pw_log: Fix AndroidManifest.xml formatAnthony Stange
<?xml?> declaration needs to go at the top of the file rather than after the copyright. Change-Id: I009a9809907bff57768cb60544fa27340b1e3e20 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/90000 Reviewed-by: Alexei Frolov <frolv@google.com> Commit-Queue: Anthony Stange <stange@google.com>
2022-04-05pw_log: Fix Logger impl and build targetsAnthony Stange
The build targets didn't work when imported into Android and also showed a build error relating to using Level in a switch statement since it can't be converted to an int. Change-Id: Id461da0825257d615ca6b6b9e985562a89d4f63f Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89962 Reviewed-by: Wyatt Hepler <hepler@google.com> Commit-Queue: Anthony Stange <stange@google.com>
2022-04-05pw_tokenizer: Message parser for undecoded messagesWyatt Hepler
pw_tokenizer.parse_message decodes Base64 format tokenized messages as much as possible. It attempts to decode the arguments by trying different combinations of format specifiers. Change-Id: I5c876d0b253e4a46772b00ae2686806aaa15f7e4 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/44260 Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com> Reviewed-by: Keir Mierle <keir@google.com> Commit-Queue: Wyatt Hepler <hepler@google.com>
2022-04-04pw_system: Use AutoUpdatingDetokenizerWyatt Hepler
- Automatically reload the token database when database files change. - Add type annotations to AutoUpdatingDetokenizer. Change-Id: I086fbf3d9ad2c348dc12f134f8c5ee230ab0286b Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89642 Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com> Reviewed-by: Keir Mierle <keir@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-04-04pw_sys_io_emcraft_sf2: Add basic UART I/O supportskeys
Introduces a GN-based build for the Emcraft Smartfusion 2 SOM. * Adds 'emcraft_sf2_som' as a pw_system target. * Smartfusion MSS HAL added to 'third_party'. Change-Id: Ibdb4affdd11e5ba57659b90f8182ef0bc24ab9e7 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/86940 Reviewed-by: Keir Mierle <keir@google.com> Reviewed-by: Armando Montanez <amontanez@google.com> Commit-Queue: Sean Keys <skeys@google.com>
2022-04-04pw_rpc: Expand debug logs for pw_rpc activityWyatt Hepler
Add descriptive logs for each phase of an RPC call. Change-Id: I2ff5f4c833c9045dc97524635cc3d571f6262b34 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89700 Reviewed-by: Ted Pudlik <tpudlik@google.com> Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com> Reviewed-by: Anthony DiGirolamo <tonymd@google.com> Reviewed-by: Armando Montanez <amontanez@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-04-04pw_system: Use PySerial non-blocking modeAnthony DiGirolamo
This avoids delays each time the serial port is read from. The end effect of the old 1second timeout is that you could only issue one rpc per second. Change-Id: Idc0fb8de88b3f0e7885a6772340f601bb46f377c Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89940 Reviewed-by: Rob Oliver <rgoliver@google.com> Pigweed-Auto-Submit: Anthony DiGirolamo <tonymd@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-04-04docs: Add advice on presubmit & branchesTed Pudlik
Tested: By viewing the generated docs in a browser. Fixed: b/223242211 Change-Id: Ia749294e5e9a950814260055ac1a51765a4694ba Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89900 Pigweed-Auto-Submit: Ted Pudlik <tpudlik@google.com> Reviewed-by: Chad Norvell <chadnorvell@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-04-04pw_rpc: Function for reading channel ID from a packetWyatt Hepler
ExtractChannelId(ConstByteSpan) parses just the channel ID from an encoded pw_rpc packet. Fixed: b/216849468 Change-Id: I9fed3c9b11c139bb7f4da5b984923ac8b489f3fb Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89640 Reviewed-by: Alexei Frolov <frolv@google.com> Commit-Queue: Wyatt Hepler <hepler@google.com> Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>
2022-04-04pw_rpc: Restore Java client loggingWyatt Hepler
- Create dev.pigweed.pw_log.Logger to support logging to either a FluentLogger or the Android logger. - Restore the pw_rpc Java client logs using dev.pigweed.pw_log.Logger. Change-Id: I73a658deed6c0da3c6d9c8157f798c56dfbf9f10 Fixed: 611 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/81420 Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com> Reviewed-by: Ted Pudlik <tpudlik@google.com> Reviewed-by: Keir Mierle <keir@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-04-04pw_system: Remove header visibility restrictionsTom Craig
Removes visibility restrictions on rules exposing public headers. Previously, a user had to depend on the top-level pw_system GN group to get some headers, however this could cause dependency cycles. For example, if a user application injects a pw_system_TARGET_HOOKS_BACKED which in turn depends on pw_system/rpc_server.h, then previously we'd end up with a dependency cycle like: pw_system -> init -> target_hooks -> pw_system_TARGET_HOOKS_BACKEND -> pw_system (becomes rpc_server with this change). Change-Id: Ibc52afa4a76fabe1ed4e6358faec518e97c959ae Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89780 Reviewed-by: Armando Montanez <amontanez@google.com> Commit-Queue: Armando Montanez <amontanez@google.com>
2022-04-03roll: host_toolspigweed-roller
From: git_revision:194c5e100619fbbd1e3ace7347aaa647c39e143f To: git_revision:3f30a2e1ac848bd3dde1322ee2ace4d4f935c29d CQ-Do-Not-Cancel-Tryjobs: true Roller-URL: https://ci.chromium.org/b/8817869318094766017 Cq-Cl-Tag: roller-builder:host-tools-roller Cq-Cl-Tag: roller-bid:8817869318094766017 CQ-Do-Not-Cancel-Tryjobs: true Change-Id: Ie32b3e990f5d234f6ff654120e0fe0303ed182e3 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89820 Bot-Commit: Pigweed Roller <pigweed-roller@pigweed.google.com.iam.gserviceaccount.com> Commit-Queue: Pigweed Roller <pigweed-roller@pigweed.google.com.iam.gserviceaccount.com>
2022-04-02roll: cmakepigweed-roller
From: version:3.23.20220319-g6657551 To: version:3.23.20220402-g6733ad4 CQ-Do-Not-Cancel-Tryjobs: true Roller-URL: https://ci.chromium.org/b/8817971871466800161 Cq-Cl-Tag: roller-builder:cmake-roller Cq-Cl-Tag: roller-bid:8817971871466800161 CQ-Do-Not-Cancel-Tryjobs: true Change-Id: I9c4322e61e702a3dfc4be8968d2815125b3806fb Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89720 Bot-Commit: Pigweed Roller <pigweed-roller@pigweed.google.com.iam.gserviceaccount.com> Commit-Queue: Pigweed Roller <pigweed-roller@pigweed.google.com.iam.gserviceaccount.com>
2022-04-02pw_software_update: Log verification errorsAli Zhang
Make sure important verification failures are prominently logged. Change-Id: I329daf3b09172119ab1b19d01fe09857bfaf11a4 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89483 Reviewed-by: Yecheng Zhao <zyecheng@google.com> Commit-Queue: Ali Zhang <alizhang@google.com> Pigweed-Auto-Submit: Ali Zhang <alizhang@google.com>
2022-04-02pw_crypto: Move PW_LOG_MODULE_NAME to .ccAli Zhang
PW_LOG_MODULE_NAME is local and should be defined in .cc or "-D" overrides. Change-Id: I217990939301e3ffdb42a3f791ae1591a4c693f4 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89482 Reviewed-by: Yecheng Zhao <zyecheng@google.com> Pigweed-Auto-Submit: Ali Zhang <alizhang@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-04-02pw_rpc: Add ChannelManipulatorArmando Montanez
Adds a channel-level processor so RPC packets can be manipulated at ingress and egress points, increasing testing flexibility. Change-Id: If638910d534b41abfb7e69d52b0b46d42e8ebf11 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89383 Pigweed-Auto-Submit: Armando Montanez <amontanez@google.com> Reviewed-by: Alexei Frolov <frolv@google.com> Reviewed-by: Wyatt Hepler <hepler@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-04-01pw_watch: Fullscreen quit keybinding fixAnthony DiGirolamo
- Use pw_console prefs to manage quit keybindings. - Use quit confirm dialog box: Default binding is Ctrl-d. - Show status of each build incrementally as they run. Change-Id: Ibcb9695360eb3c7e4a93c6a2e3ca7570d1954edc Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89040 Reviewed-by: Keir Mierle <keir@google.com> Commit-Queue: Anthony DiGirolamo <tonymd@google.com>
2022-04-01pw_rpc: Add Java Nullable type annotationAnthony DiGirolamo
Change-Id: I88bbe1061c16083d0e13a94bf9e8c28900119a18 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89480 Reviewed-by: Ted Pudlik <tpudlik@google.com> Reviewed-by: Wyatt Hepler <hepler@google.com> Commit-Queue: Anthony DiGirolamo <tonymd@google.com>
2022-04-01pw_rpc: don't use pw::Result inside PW_TRY_ASSIGNDennis Kormalev
Change-Id: I9510a3c881f1c6cda4d8edfda5addedb9a21af85 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89540 Pigweed-Auto-Submit: Dennis Kormalev <denk@google.com> Reviewed-by: Alexei Frolov <frolv@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-04-01Merge remote-tracking branch 'goog/upstream-main' into syncAnthony Stange
Bug: 218592910 Test: verify targets still build Change-Id: I86743d719c99ba942402a19520d002a4078d491d
2022-04-01pw_log: Remove proto_utils.cc from Android.bpAnthony Stange
proto_utils.cc compilation requires other pw_rpc deps not currently set up for Android's build system. Change-Id: Ied44dad6c06ee066bbb1d2cd2b734aff2634238e Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89503 Reviewed-by: Wyatt Hepler <hepler@google.com> Commit-Queue: Anthony Stange <stange@google.com>
2022-04-01software_update: remove config.h from header fileDavid Rogers
Remove include of config.h in manifest_accessor.h. Having the include of config.h in an header file leaks the LOG_MODULE_NAME to the users of module and overwrites their LOG_MODULE_NAME. Change-Id: Ied6504d2cf802cc51668b08947f68f9875fe6ae3 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89387 Reviewed-by: Ali Zhang <alizhang@google.com> Pigweed-Auto-Submit: Ali Zhang <alizhang@google.com> Reviewed-by: Armando Montanez <amontanez@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-04-01Add and fix pw_log/pw_log_android Android.bp targetsAnthony Stange
Fixes Android breakage by defining libpw_log for use by Android targets and ensuring cc_library is used so that srcs can be defined for pw_log. Change-Id: I4e5617a5b25482dfee00e0159490084b1fb6e5b6 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89502 Reviewed-by: Keir Mierle <keir@google.com> Reviewed-by: Wyatt Hepler <hepler@google.com> Commit-Queue: Anthony Stange <stange@google.com>
2022-04-01pw_package: Add note about preferring submodulesRob Mohr
Change-Id: I6087b51aa3e20657974f52a0295e0d3f31f371fa Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89560 Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com> Reviewed-by: Keir Mierle <keir@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-04-01pw_build: Introduce a pip lockTed Pudlik
The pip lock prevents pip from being run concurrently with any other Python action. This should reduce flakiness due to modules being (un)installed while they're imported by other parts of the build. This version only works on Linux and Mac: it's a no-op on Windows. I'll develop a Windows version as a followup, but submitting this now to reduce user pain. Bug: b/227670947 Change-Id: Ife2cb66b2fbadbee8d61c0641165909dd50accba Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/88861 Reviewed-by: Keir Mierle <keir@google.com> Commit-Queue: Ted Pudlik <tpudlik@google.com>
2022-03-31pw_protobuf: Restructure docsScott James Remnant
To make the documentation easier to follow, especially once new support is documented, restructure so that code generation is a top-level item separate to encoding and decoding. Change-Id: I5ee30e16f0a0c257954020f5eca6c66b8eeb8c46 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89422 Pigweed-Auto-Submit: Scott James Remnant <keybuk@google.com> Reviewed-by: Alexei Frolov <frolv@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-03-31pw_protobuf: Rename test proto 'int' fieldScott James Remnant
Rename 'int' to 'integer' to avoid a conflict with C++ keywords after performing code generation. Change-Id: Iecf3166da6d472082fcc4e267fb60d576ac0e3db Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89421 Pigweed-Auto-Submit: Scott James Remnant <keybuk@google.com> Reviewed-by: Keir Mierle <keir@google.com> Commit-Queue: Scott James Remnant <keybuk@google.com>
2022-03-31pw_watch: Fix watch_app styling for highlighting text and showing resultElaine Hwang
Change-Id: Ifce84bf9650ae216a9324767eac57fb49f6b81c6 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/86560 Reviewed-by: Anthony DiGirolamo <tonymd@google.com> Reviewed-by: Wyatt Hepler <hepler@google.com> Commit-Queue: Elaine Hwang <elainehwang@google.com>
2022-03-30pw_rpc: Rename dev.pigweed.pw.rpc.internal packageTed Pudlik
For consistency with the dev.pigweed.pw_rpc package (which the rest of the Java pw_rpc code lives in), this is renamed to also use the underscore rather than the dot. Bug: b/227385728 Change-Id: I4772d06f7541d79b3935c7b732d97882d0deda03 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89400 Reviewed-by: Wyatt Hepler <hepler@google.com> Commit-Queue: Ted Pudlik <tpudlik@google.com>
2022-03-30docs: Expand automated analysis docsTed Pudlik
Change-Id: I8190e9c9ebbfd870bea9a5596e6bdb72ecdf8f6f Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89249 Reviewed-by: Keir Mierle <keir@google.com> Reviewed-by: Edwin Vane <revane@google.com> Reviewed-by: Chad Norvell <chadnorvell@google.com> Commit-Queue: Ted Pudlik <tpudlik@google.com>
2022-03-30pw_software_update: Make personalization optionalAli Zhang
Change-Id: I23dff3cbddbad8c854b8840338911b1cf37d65c5 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89321 Pigweed-Auto-Submit: Ali Zhang <alizhang@google.com> Reviewed-by: David Rogers <davidrogers@google.com> Commit-Queue: Ali Zhang <alizhang@google.com>
2022-03-28pw_transfer: Always set chunk type fieldAlexei Frolov
This updates the implementations of pw_transfer to always set a chunk type when encoding a chunk proto, including a new completion type. No significant behavioral changes are made in response to the chunk type field -- these will be rolled out in a future change. Change-Id: I9d39eecff814cfc21285eb24ff7a0b5166ce1ff4 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89101 Reviewed-by: Keir Mierle <keir@google.com> Reviewed-by: Wyatt Hepler <hepler@google.com> Commit-Queue: Alexei Frolov <frolv@google.com>
2022-03-28pw_rpc: Remove unused using statementRob Mohr
This was failing with a new version of clang: pwrev/89160. Change-Id: Iea502895b2c42e40112a691cf0e2f96e67c39a10 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89220 Pigweed-Auto-Submit: Rob Mohr <mohrr@google.com> Reviewed-by: Alexei Frolov <frolv@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-03-27roll: host_toolspigweed-roller
From: git_revision:3b4e1750fe517b670f1b075213ca65dae1783469 To: git_revision:194c5e100619fbbd1e3ace7347aaa647c39e143f CQ-Do-Not-Cancel-Tryjobs: true Roller-URL: https://ci.chromium.org/b/8818503497287181201 Cq-Cl-Tag: roller-builder:host-tools-roller Cq-Cl-Tag: roller-bid:8818503497287181201 CQ-Do-Not-Cancel-Tryjobs: true Change-Id: I3825f39e774249747e2e4d107c6162ea51c5065f Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89201 Bot-Commit: Pigweed Roller <pigweed-roller@pigweed.google.com.iam.gserviceaccount.com> Commit-Queue: Pigweed Roller <pigweed-roller@pigweed.google.com.iam.gserviceaccount.com>
2022-03-27pw_package: Add Pi Pico SDKArmando Montanez
Change-Id: I5a4c984a020c6a9ed6681249b7ea0268c150154c Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89147 Reviewed-by: Anthony DiGirolamo <tonymd@google.com> Pigweed-Auto-Submit: Armando Montanez <amontanez@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-03-27third_party/pico-sdk: Pi Pico GN buildArmando Montanez
Introduces a GN-based build for the Raspberry Pi Pico. Usage instructions: * clone the Pico SDK repo and then point PICO_SRC_DIR to the directory that the Pico SDK was cloned to. * ninja -C out Change-Id: I4ff058b1f32c737706a8625c916c52c21275e88f Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/88806 Pigweed-Auto-Submit: Armando Montanez <amontanez@google.com> Reviewed-by: Anthony DiGirolamo <tonymd@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-03-26pw_toolchain: Move --gc-sectionsArmando Montanez
Moves the --gc-sections and -dead_strip flags from generate_toolchain.gni to a pw_build config so it lives alongside similar size-reduction flags. Change-Id: Ie4a51a9357a41ecd997eba28bfa78ddf43471b72 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89146 Pigweed-Auto-Submit: Armando Montanez <amontanez@google.com> Reviewed-by: Anthony DiGirolamo <tonymd@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-03-26pw_transfer: Expand integration testWyatt Hepler
- Increase iterations to 5. - Add 8192 B test that sometimes failed in presubmit. Change-Id: I3b72d6a8acd326c1a2ac02f4b65916cd60cc43ad Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/71562 Reviewed-by: Erik Gilling <konkers@google.com> Commit-Queue: Wyatt Hepler <hepler@google.com>
2022-03-26pw_protobuf: Support encoding from pw::VectorScott James Remnant
Extend StreamEncoder (and MemoryEncoder) to have WriteRepeatedInt32 etc. methods that mirror the equivalent ReadRepeatedInt32 etc. methods on StreamDecoder. Likewise extend encoder codegen to have a WriteFoo override that accepts a vector. Change-Id: I09d374dfa60e36feea8bb3b9f6d5fb701eb7c9b4 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/88963 Reviewed-by: Armando Montanez <amontanez@google.com> Commit-Queue: Scott James Remnant <keybuk@google.com> Pigweed-Auto-Submit: Scott James Remnant <keybuk@google.com>
2022-03-25pw_system: Log log drop reason when availableCarlos Chinchilla
Change-Id: I91fd3f9beb6e747ff0383aff8e4c61dffe557e4a Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89041 Reviewed-by: Keir Mierle <keir@google.com> Reviewed-by: Armando Montanez <amontanez@google.com> Pigweed-Auto-Submit: Carlos Chinchilla <cachinchilla@google.com> Commit-Queue: Carlos Chinchilla <cachinchilla@google.com>
2022-03-25pw_transfer: Expand log for failure caseWyatt Hepler
Change-Id: I60e332c9c4354829c31819153a20d946466f4eb7 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89100 Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com> Reviewed-by: Alexei Frolov <frolv@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-03-25pw_protobuf: Support encoding packed bool fieldsScott James Remnant
Change-Id: I21b0f2b82f8761afa94216cebfa7ef7c4fe6e0d6 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/88962 Pigweed-Auto-Submit: Scott James Remnant <keybuk@google.com> Reviewed-by: Armando Montanez <amontanez@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-03-25pw_protobuf: Read repeated fields using pw::VectorScott James Remnant
Correct handling of protobuf repeated fields is surprisingly complex. In order to read a field of e.g. 'repeated uint32 foo = 1;' the caller must be able to handle two potential wire formats: 1. multiple single fields, each containing a value; 2. one or more delimited fields containing multiple packed values. The wire format in particular allows the encoder to, even when using packed values, break into multiple delimited fields. Provide StreamDecoder ReadRepeatedInt32 etc. methods that handle all of these cases by using pw::Vector as the output argument. For the codegen StreamDecoder, field-checked ReadFoo etc. wrappers are provided. Change-Id: Ifff92bfa894a8f70a1f58b4edffef155866f7151 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/88470 Reviewed-by: Armando Montanez <amontanez@google.com> Reviewed-by: Austin Foxley <afoxley@google.com> Pigweed-Auto-Submit: Scott James Remnant <keybuk@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-03-25pw_package: Add googletestTom Craig
Adds a googletest plugin to pw_package for users who want the full googletest/googlemock featureset. Change-Id: I06102da6f175690d6238a1817b0a85d2c7843513 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/88934 Reviewed-by: Rob Mohr <mohrr@google.com> Reviewed-by: Armando Montanez <amontanez@google.com> Commit-Queue: Armando Montanez <amontanez@google.com>
2022-03-24pw_protobuf: Refactor field parsingScott James Remnant
Refactor the field parsing of individual and packed fixed and varint fields to take the same basic approach, with a consistent internal API. Internal ReadFixedField, ReadVarintField, ReadPackedFixedField, and ReadPackedVarintField methods now consistently output into the passed span of bytes. This provides a better foundation API for future decoding extensions. Change-Id: I8306677a8639acca7525dcaf75d786cf2edd3ed8 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/88860 Pigweed-Auto-Submit: Scott James Remnant <keybuk@google.com> Reviewed-by: Keir Mierle <keir@google.com> Reviewed-by: Armando Montanez <amontanez@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-03-24pw_env_setup: Update default gni pathRob Mohr
Update the default environment gni file path to '//build_overrides/pigweed_environment.gni'. Most 1P projects already include this path in their .gitignore files and explicitly set this as the gni file path so this should have no effect. Change-Id: Iaba84acea929e4bcb6fbce217de4972c016432d0 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/88880 Reviewed-by: Joe Ethier <jethier@google.com> Commit-Queue: Rob Mohr <mohrr@google.com>
2022-03-24pw_bloat: Honor output contract in pw_size_reportDennis Kormalev
pw_size_report states both $target_name and ${target_name}.txt as outputs, while in case of full report only .txt is generated. When full_report=true and pw_size_report is added as a dependency to pw_doc_group it fails the build due to the non-existing file. This change copies ${target_name}.txt data as $target_name to keep the output contract honored. Change-Id: I743d1c5af63fe6c979fd1b4c2e71057a84370d09 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/89000 Reviewed-by: Alexei Frolov <frolv@google.com> Pigweed-Auto-Submit: Dennis Kormalev <denk@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
2022-03-24pw_log_rpc: Send drop reason messageCarlos Chinchilla
Independently track each log drop reason and report it in the log drop message when possible. Increase the minimum log encode buffer size to fit the largest error message. Fixes: 630 Change-Id: I18c8f73eb8e5a1ece7767a5b3309de72cfd1c3ec Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/85480 Reviewed-by: Armando Montanez <amontanez@google.com> Commit-Queue: Carlos Chinchilla <cachinchilla@google.com> Pigweed-Auto-Submit: Carlos Chinchilla <cachinchilla@google.com>